[OpenSIPS-Devel] [OpenSIPS/opensips] 9409de: [registrar] Proper init of delete_nh_he variable

[Bogdan Andrei IANCU]

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9409de0056f07c5ce30e8747c982da3e1e58743c
      https://github.com/OpenSIPS/opensips/commit/9409de0056f07c5ce30e8747c982da3e1e58743c
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/registrar/save.c

  Log Message:
  -----------
  [registrar] Proper init of delete_nh_he variable

The logic may end up to free_hostent(delete_nh_he) without actually using the delete_nh_he, leading to freeing so random pointers.

Reported by coverity CID 199942

(cherry picked from commit 3b20c9db07ea88bd84609676f2657011588b8b41)


  Commit: 1d94604055ab51dcb2be74eddec61be72e748fc7
      https://github.com/OpenSIPS/opensips/commit/1d94604055ab51dcb2be74eddec61be72e748fc7
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M net/net_tcp.c

  Log Message:
  -----------
  [core] proper checking on return code for getsockname()

Reported by coverity CID 200064

(cherry picked from commit c489f462d236fddb883e64a6cde7b04929a76191)


  Commit: fa32e61c662d2b3eab897050e01dcaa8149edef0
      https://github.com/OpenSIPS/opensips/commit/fa32e61c662d2b3eab897050e01dcaa8149edef0
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  [pua_dialoginfo] Fix bad test on resolving flag name

get_flag_id_by_name() may also return other negative codes than -1

Reported by coverity CID 207914

(cherry picked from commit f3530c10adc1d2a5b01340a9823f84db61c98e72)


  Commit: bfdf7468c10a202abc6d41878fbfd41261d3b5e6
      https://github.com/OpenSIPS/opensips/commit/bfdf7468c10a202abc6d41878fbfd41261d3b5e6
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/drouting/drouting.c

  Log Message:
  -----------
  [drouting] removed useless code

Makes no sense to select the table at db_con init time, as various queries (from various modules) may set and use different tables.

Related to coverity report CID 58405

(cherry picked from commit ab7d4430941263d20acd1f45bbbbf09c80a5040f)


  Commit: a1a57ccd45568668cb9b797837402448a4e49a97
      https://github.com/OpenSIPS/opensips/commit/a1a57ccd45568668cb9b797837402448a4e49a97
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/nathelper/nathelper.c

  Log Message:
  -----------
  [nathelper] Fix bad test on resolving flag name

get_flag_id_by_name() may also return other negative codes than -1

Reported by coverity CID 200026, 200005, 199906

(cherry picked from commit 249b80741ddbb0952c7f737af2a7c2473f05eacf)


  Commit: 75ec8229e1661374040d88d438ac65cc50f2b7c3
      https://github.com/OpenSIPS/opensips/commit/75ec8229e1661374040d88d438ac65cc50f2b7c3
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/nathelper/sip_pinger.h

  Log Message:
  -----------
  [nathelper] Proper testing upon extracting hash value

Be sure it is valid hexa and it it within the correct range. The lack of these tests may open the gate for some nasty exploits.

Reported by coverity CID 199958

(cherry picked from commit b1d796344aa674e25fc4408bda5d336bce2bc605)


  Commit: e68b9a24b63c6d3a4f05f97f56cf1a6c3612e1f2
      https://github.com/OpenSIPS/opensips/commit/e68b9a24b63c6d3a4f05f97f56cf1a6c3612e1f2
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/presence/presence.c

  Log Message:
  -----------
  [presence] fix ugly copy-paste error in MI output

Reported by coverity CID 200057

(cherry picked from commit d4abd53b202eeb5d0cd932fb6fa59e0074f3848e)


Compare: https://github.com/OpenSIPS/opensips/compare/b2e7a82016a1...e68b9a24b63c