[OpenSIPS-Devel] [OpenSIPS/opensips] cd2e43: [registrar] Proper init of delete_nh_he variable

[Bogdan Andrei IANCU]

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: cd2e430bbf5e40aaf7dd0146e3edec1821141562
      https://github.com/OpenSIPS/opensips/commit/cd2e430bbf5e40aaf7dd0146e3edec1821141562
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/registrar/save.c

  Log Message:
  -----------
  [registrar] Proper init of delete_nh_he variable

The logic may end up to free_hostent(delete_nh_he) without actually using the delete_nh_he, leading to freeing so random pointers.

Reported by coverity CID 199942

(cherry picked from commit 3b20c9db07ea88bd84609676f2657011588b8b41)


  Commit: acc3d039c5af6e0106a0225c2667513a5d0c07fc
      https://github.com/OpenSIPS/opensips/commit/acc3d039c5af6e0106a0225c2667513a5d0c07fc
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M net/net_tcp.c

  Log Message:
  -----------
  [core] proper checking on return code for getsockname()

Reported by coverity CID 200064

(cherry picked from commit c489f462d236fddb883e64a6cde7b04929a76191)


  Commit: 038128cdb8e0a51bda5f2d4c3fde473a317fd4fe
      https://github.com/OpenSIPS/opensips/commit/038128cdb8e0a51bda5f2d4c3fde473a317fd4fe
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  [pua_dialoginfo] Fix bad test on resolving flag name

get_flag_id_by_name() may also return other negative codes than -1

Reported by coverity CID 207914

(cherry picked from commit f3530c10adc1d2a5b01340a9823f84db61c98e72)


  Commit: f80ce5438805491227d7d9c9fba28738958544bf
      https://github.com/OpenSIPS/opensips/commit/f80ce5438805491227d7d9c9fba28738958544bf
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/drouting/drouting.c

  Log Message:
  -----------
  [drouting] removed useless code

Makes no sense to select the table at db_con init time, as various queries (from various modules) may set and use different tables.

Related to coverity report CID 58405

(cherry picked from commit ab7d4430941263d20acd1f45bbbbf09c80a5040f)


  Commit: b00f936510c18aec4f4416c7224d7d8a7b19fecc
      https://github.com/OpenSIPS/opensips/commit/b00f936510c18aec4f4416c7224d7d8a7b19fecc
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/nathelper/nathelper.c

  Log Message:
  -----------
  [nathelper] Fix bad test on resolving flag name

get_flag_id_by_name() may also return other negative codes than -1

Reported by coverity CID 200026, 200005, 199906

(cherry picked from commit 249b80741ddbb0952c7f737af2a7c2473f05eacf)


  Commit: 33b60d672b3195f05cfbee1ec31760e56a1a6d72
      https://github.com/OpenSIPS/opensips/commit/33b60d672b3195f05cfbee1ec31760e56a1a6d72
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/nathelper/sip_pinger.h

  Log Message:
  -----------
  [nathelper] Proper testing upon extracting hash value

Be sure it is valid hexa and it it within the correct range. The lack of these tests may open the gate for some nasty exploits.

Reported by coverity CID 199958

(cherry picked from commit b1d796344aa674e25fc4408bda5d336bce2bc605)


Compare: https://github.com/OpenSIPS/opensips/compare/d76e0b256994...33b60d672b31