[OpenSIPS-Devel] [OpenSIPS/opensips] 535c9c: [registrar] Proper init of delete_nh_he variable

[Bogdan Andrei IANCU]

  Branch: refs/heads/3.1
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 535c9c7c8cf3cdbd934614f88f42e39977c6530b
      https://github.com/OpenSIPS/opensips/commit/535c9c7c8cf3cdbd934614f88f42e39977c6530b
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/registrar/save.c

  Log Message:
  -----------
  [registrar] Proper init of delete_nh_he variable

The logic may end up to free_hostent(delete_nh_he) without actually using the delete_nh_he, leading to freeing so random pointers.

Reported by coverity CID 199942

(cherry picked from commit 3b20c9db07ea88bd84609676f2657011588b8b41)


  Commit: fa7127030c80191057d4ff87def9451699190868
      https://github.com/OpenSIPS/opensips/commit/fa7127030c80191057d4ff87def9451699190868
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/drouting/drouting.c

  Log Message:
  -----------
  [drouting] Avoid handling a NULL 'gw' upon bogus function call

Reported by coverity CID 211365

(cherry picked from commit b0135bb010c119328e9fb1ebb88f3f24c43fa27e)


  Commit: 416cbf1b42c22a15437fadffe82b4a6f12bfd5f5
      https://github.com/OpenSIPS/opensips/commit/416cbf1b42c22a15437fadffe82b4a6f12bfd5f5
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M net/net_tcp.c

  Log Message:
  -----------
  [core] proper checking on return code for getsockname()

Reported by coverity CID 200064

(cherry picked from commit c489f462d236fddb883e64a6cde7b04929a76191)


  Commit: a9d3da3d18c7f0647bafdc7f2856b5753f8879d1
      https://github.com/OpenSIPS/opensips/commit/a9d3da3d18c7f0647bafdc7f2856b5753f8879d1
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  [pua_dialoginfo] Fix bad test on resolving flag name

get_flag_id_by_name() may also return other negative codes than -1

Reported by coverity CID 207914

(cherry picked from commit f3530c10adc1d2a5b01340a9823f84db61c98e72)


  Commit: 9df5decf6fb0b1772610540b9af6466eec8878bc
      https://github.com/OpenSIPS/opensips/commit/9df5decf6fb0b1772610540b9af6466eec8878bc
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/presence/subscribe.c

  Log Message:
  -----------
  [presence] Proper testing for the return code of get_body()

Reported by coverity CID 207911

(cherry picked from commit 11e63b35941766c09810aceb48ed300c808a1ef1)


  Commit: 49947bbfef37648b029ffcf66148d18f0c805266
      https://github.com/OpenSIPS/opensips/commit/49947bbfef37648b029ffcf66148d18f0c805266
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/drouting/drouting.c

  Log Message:
  -----------
  [drouting] removed useless code

Makes no sense to select the table at db_con init time, as various queries (from various modules) may set and use different tables.

Related to coverity report CID 58405

(cherry picked from commit ab7d4430941263d20acd1f45bbbbf09c80a5040f)


  Commit: dce86d20f73aa2ffe9fc0d514899f0890aa9da56
      https://github.com/OpenSIPS/opensips/commit/dce86d20f73aa2ffe9fc0d514899f0890aa9da56
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/nathelper/nathelper.c

  Log Message:
  -----------
  [nathelper] Fix bad test on resolving flag name

get_flag_id_by_name() may also return other negative codes than -1

Reported by coverity CID 200026, 200005, 199906

(cherry picked from commit 249b80741ddbb0952c7f737af2a7c2473f05eacf)


  Commit: a06185abaedefa58a1a0199238ac5585e1e582cb
      https://github.com/OpenSIPS/opensips/commit/a06185abaedefa58a1a0199238ac5585e1e582cb
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/nathelper/sip_pinger.h

  Log Message:
  -----------
  [nathelper] Proper testing upon extracting hash value

Be sure it is valid hexa and it it within the correct range. The lack of these tests may open the gate for some nasty exploits.

Reported by coverity CID 199958

(cherry picked from commit b1d796344aa674e25fc4408bda5d336bce2bc605)


  Commit: 252078d09bb0ff55e47e38048678bd67039ad1dd
      https://github.com/OpenSIPS/opensips/commit/252078d09bb0ff55e47e38048678bd67039ad1dd
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/presence/presence.c

  Log Message:
  -----------
  [presence] fix ugly copy-paste error in MI output

Reported by coverity CID 200057

(cherry picked from commit d4abd53b202eeb5d0cd932fb6fa59e0074f3848e)


Compare: https://github.com/OpenSIPS/opensips/compare/3c97b34aec84...252078d09bb0