[OpenSIPS-Devel] [OpenSIPS/opensips] b36ed2: registrars: Correctly reply on all save() edge-cases

[Liviu Chircu]

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b36ed2f680e33c46f61716def1f025a8895c156f
      https://github.com/OpenSIPS/opensips/commit/b36ed2f680e33c46f61716def1f025a8895c156f
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2021-01-14 (Thu, 14 Jan 2021)

  Changed paths:
    M lib/reg/rerrno.c
    M lib/reg/rerrno.h
    M modules/mid_registrar/save.c
    M modules/registrar/save.c

  Log Message:
  -----------
  registrars: Correctly reply on all save() edge-cases

This patch fixes several corner-cases when calling
[mid_registrar]_save(), where:

    * the registrar would not send a reply
    * the registrar would send a bad reply (e.g. 200 OK on an error!)

(cherry picked from commit 46553a9aad6ab00d14a787a81300fd01599751f0)


  Commit: 863d55f90a213a020657fd1603e48926e89d5f80
      https://github.com/OpenSIPS/opensips/commit/863d55f90a213a020657fd1603e48926e89d5f80
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2021-01-14 (Thu, 14 Jan 2021)

  Changed paths:
    M etc/opensips.cfg
    M menuconfig/configs/opensips_residential.m4

  Log Message:
  -----------
  Sample opensips.cfg: Avoid double-replying after save()

(cherry picked from commit e4708c2aaf0ce1b0d87223407417679b5d6b4b29)


  Commit: 4238c35712ab35da290c7498388999c5a50128bc
      https://github.com/OpenSIPS/opensips/commit/4238c35712ab35da290c7498388999c5a50128bc
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2021-01-14 (Thu, 14 Jan 2021)

  Changed paths:
    M modules/mid_registrar/save.c
    M modules/registrar/save.c
    M modules/usrloc/ureplication.c

  Log Message:
  -----------
  registrars: Do not save() AoR URIs with no 'username'

Also add some protection on the receiving end of the cluster
communication for such strings which could crash the server.

Fixes #2232

(cherry picked from commit 6cd76760ece9665a88e5eaa5971777961e5b2806)


Compare: https://github.com/OpenSIPS/opensips/compare/210295f5e14e...4238c35712ab