[OpenSIPS-Devel] [OpenSIPS/opensips] d5f51d: registrars: Correctly reply on all save() edge-cases

[Liviu Chircu]

  Branch: refs/heads/3.1
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d5f51ddf3e5107a181ad0f087e833b9d27211948
      https://github.com/OpenSIPS/opensips/commit/d5f51ddf3e5107a181ad0f087e833b9d27211948
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2021-01-14 (Thu, 14 Jan 2021)

  Changed paths:
    M lib/reg/rerrno.c
    M lib/reg/rerrno.h
    M modules/mid_registrar/save.c
    M modules/registrar/save.c

  Log Message:
  -----------
  registrars: Correctly reply on all save() edge-cases

This patch fixes several corner-cases when calling
[mid_registrar]_save(), where:

    * the registrar would not send a reply
    * the registrar would send a bad reply (e.g. 200 OK on an error!)

(cherry picked from commit 46553a9aad6ab00d14a787a81300fd01599751f0)


  Commit: 36e606f0dab3a205e17ae1d395d8fdb9e329a021
      https://github.com/OpenSIPS/opensips/commit/36e606f0dab3a205e17ae1d395d8fdb9e329a021
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2021-01-14 (Thu, 14 Jan 2021)

  Changed paths:
    M etc/opensips.cfg
    M menuconfig/configs/opensips_residential.m4

  Log Message:
  -----------
  Sample opensips.cfg: Avoid double-replying after save()

(cherry picked from commit e4708c2aaf0ce1b0d87223407417679b5d6b4b29)


  Commit: 0701082ae1a83ae9067d6f4a8d417e203c9eb471
      https://github.com/OpenSIPS/opensips/commit/0701082ae1a83ae9067d6f4a8d417e203c9eb471
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2021-01-14 (Thu, 14 Jan 2021)

  Changed paths:
    M modules/mid_registrar/save.c
    M modules/registrar/save.c
    M modules/usrloc/ul_cluster.c
    M parser/test/test_parser.c

  Log Message:
  -----------
  registrars: Do not save() AoR URIs with no 'username'

Also add some protection on the receiving end of the cluster
communication for such strings which could crash the server.

Fixes #2232

(cherry picked from commit 6cd76760ece9665a88e5eaa5971777961e5b2806)


Compare: https://github.com/OpenSIPS/opensips/compare/2c1492bd5727...0701082ae1a8