[OpenSIPS-Devel] [OpenSIPS/opensips] 4bf9ec: sipcapture: establish the procs number at parsing

Răzvan Crainea noreply at github.com
Tue Apr 20 15:23:09 EST 2021


  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 4bf9ecd8ec07d9e1c534248e2831b349fc568f1e
      https://github.com/OpenSIPS/opensips/commit/4bf9ecd8ec07d9e1c534248e2831b349fc568f1e
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2021-04-20 (Tue, 20 Apr 2021)

  Changed paths:
    M modules/sipcapture/sipcapture.c

  Log Message:
  -----------
  sipcapture: establish the procs number at parsing

Updating the number of extra procs needed by the module in mod_init() is
a bad idea, since the attendant does not see any changes made by the
process that runs mod_init, thus it waits for more children tha it
should have, resulting in some bad pipe errors.
Credits go to @ghmj2417 for reporting this in #2259 and to Bogdan
Andrei IANCU (@bogdan-iancu) for brainstorming the final solution.

(cherry picked from commit 065784586cd83fd6af53c7121763edcfa2ca999e)


  Commit: 9ff7fa90615bbf95931f93d4b771ffdef68b6c8d
      https://github.com/OpenSIPS/opensips/commit/9ff7fa90615bbf95931f93d4b771ffdef68b6c8d
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2021-04-20 (Tue, 20 Apr 2021)

  Changed paths:
    M modules/rtpproxy/rtpproxy.c
    M modules/rtpproxy/timeout_process.c

  Log Message:
  -----------
  rtpproxy: fix initializing child

If a process is not started with flag PROC_FLAG_INITCHILD, OpenSIPS will
not be interested in its init status, thus the extra process will not be
able to report its initializing state.
If however it was doing that, it would hit the bug reported in
ticket #2259, where the attendant was badly couting the number of
processes that need to be initialized, due to the fact that it would not
see any updates (in this case of the exports.procs structure) the
process would be doing in its mod_init().
Credits go to @ghmj2417 for reporting this in #2259 and to Bogdan
Andrei IANCU (@bogdan-iancu) for brainstorming the final solution.

(cherry picked from commit 6a920dd3fd1e5605d08acbd79b0b9e9994008d00)


Compare: https://github.com/OpenSIPS/opensips/compare/9c2c8638e9c8...9ff7fa90615b



More information about the Devel mailing list