[OpenSIPS-Devel] [OpenSIPS/opensips] b8647a: rtpproxy: fix initializing child

[Răzvan Crainea]

  Branch: refs/heads/3.1
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b8647ad6f6484b59e8604577b82149dde1986328
      https://github.com/OpenSIPS/opensips/commit/b8647ad6f6484b59e8604577b82149dde1986328
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2021-04-20 (Tue, 20 Apr 2021)

  Changed paths:
    M modules/rtpproxy/notification_process.c
    M modules/rtpproxy/rtpproxy.c

  Log Message:
  -----------
  rtpproxy: fix initializing child

If a process is not started with flag PROC_FLAG_INITCHILD, OpenSIPS will
not be interested in its init status, thus the extra process will not be
able to report its initializing state.
If however it was doing that, it would hit the bug reported in
ticket #2259, where the attendant was badly couting the number of
processes that need to be initialized, due to the fact that it would not
see any updates (in this case of the exports.procs structure) the
process would be doing in its mod_init().
Credits go to @ghmj2417 for reporting this in #2259 and to Bogdan
Andrei IANCU (@bogdan-iancu) for brainstorming the final solution.

(cherry picked from commit 6a920dd3fd1e5605d08acbd79b0b9e9994008d00)


  Commit: 98b71f84fee3c5cf4690fc216003061644073ac2
      https://github.com/OpenSIPS/opensips/commit/98b71f84fee3c5cf4690fc216003061644073ac2
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2021-04-20 (Tue, 20 Apr 2021)

  Changed paths:
    M modules/sipcapture/sipcapture.c

  Log Message:
  -----------
  sipcapture: establish the procs number at parsing

Updating the number of extra procs needed by the module in mod_init() is
a bad idea, since the attendant does not see any changes made by the
process that runs mod_init, thus it waits for more children tha it
should have, resulting in some bad pipe errors.
Credits go to @ghmj2417 for reporting this in #2259 and to Bogdan
Andrei IANCU (@bogdan-iancu) for brainstorming the final solution.

(cherry picked from commit 065784586cd83fd6af53c7121763edcfa2ca999e)


Compare: https://github.com/OpenSIPS/opensips/compare/fda62f9575b5...98b71f84fee3