[OpenSIPS-Devel] [OpenSIPS/opensips] 7e623b: dialog: fix a replicated profiles counting issue

Vlad Pătrașcu noreply at github.com
Wed Mar 25 19:44:14 EST 2020


  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7e623b302191b6a34087b1527ef5383914ed1663
      https://github.com/OpenSIPS/opensips/commit/7e623b302191b6a34087b1527ef5383914ed1663
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2020-03-25 (Wed, 25 Mar 2020)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: fix a replicated profiles counting issue

The incorrect profile counting was caused by a race between the processing of
the replicated dialog create/update packets. While processing the create
packet, the lock was released before linking the dialog into a profile and
setting the sharing tag. As such, the process that handled the update packet
could insert the dialog into a profile itself, but with an improper sharing tag.

Thanks to 46Labs for reporting and help with troubleshooting this!





More information about the Devel mailing list