[OpenSIPS-Devel] [OpenSIPS/opensips] 167646: prevent leak in case of oom

[Răzvan Crainea]

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 16764690acece5afbcbe0495e69b998246342d55
      https://github.com/OpenSIPS/opensips/commit/16764690acece5afbcbe0495e69b998246342d55
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M cfg_pp.c

  Log Message:
  -----------
  prevent leak in case of oom

Fixes Coverity #211383


  Commit: de31a7ace32f462c0a5e2b59f750cb3cb3bb3307
      https://github.com/OpenSIPS/opensips/commit/de31a7ace32f462c0a5e2b59f750cb3cb3bb3307
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M evi/evi_params.h

  Log Message:
  -----------
  evi: annotate evi_param_set_int to fix Coverity

Fixes several Coverity alarms


  Commit: 6948c092dab68973feefb302e8f1513135bd13cf
      https://github.com/OpenSIPS/opensips/commit/6948c092dab68973feefb302e8f1513135bd13cf
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/tracer/tracer.c

  Log Message:
  -----------
  tracer: make sure vars are initialized

Fixes Coverity CID #200098


  Commit: b2bbb61ed799726a48f51bc5f96f1cf549613772
      https://github.com/OpenSIPS/opensips/commit/b2bbb61ed799726a48f51bc5f96f1cf549613772
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/db_text/dbt_file.c

  Log Message:
  -----------
  db_text: prevent buffer overflow

Fixes Coverity CID #200093


  Commit: 056e186540c3fa5c5b99dc3113aa78fa1cadeecc
      https://github.com/OpenSIPS/opensips/commit/056e186540c3fa5c5b99dc3113aa78fa1cadeecc
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/mi_html/http_fnc.c

  Log Message:
  -----------
  mi_html: fix improper free on error

Fixes Coverity CID #200040


  Commit: 4b9cad5a7e09e3474fa96e19b7a2e8f6d510381e
      https://github.com/OpenSIPS/opensips/commit/4b9cad5a7e09e3474fa96e19b7a2e8f6d510381e
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/qos/qos_ctx_helpers.c

  Log Message:
  -----------
  qos: fix getting SDP


  Commit: 6602950d243b84b4969075e07b5ccc71083e140f
      https://github.com/OpenSIPS/opensips/commit/6602950d243b84b4969075e07b5ccc71083e140f
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M parser/parse_to.c

  Log Message:
  -----------
  parse_to: add fallthrough comments/indications for coverity CID #200094


  Commit: 42f020494b2f6807ba43225a4ff8f0bf0874fc35
      https://github.com/OpenSIPS/opensips/commit/42f020494b2f6807ba43225a4ff8f0bf0874fc35
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/tm/cluster.c

  Log Message:
  -----------
  tm: cleanup replicated cancel msg

Fixes Coverity CID #200031


  Commit: 563e3600e2dcf03af6bac80a09ae65e8cf48455c
      https://github.com/OpenSIPS/opensips/commit/563e3600e2dcf03af6bac80a09ae65e8cf48455c
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/db_text/dbt_file.c

  Log Message:
  -----------
  db_text: fix no-op code

fixes Coverity CID #200004


  Commit: d15e5e66836e2e67be69de8a2dd65278c66a95f0
      https://github.com/OpenSIPS/opensips/commit/d15e5e66836e2e67be69de8a2dd65278c66a95f0
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  proto_smpp: smpp_bind_transceiver_resp_t system id

Reported by Coverity CID #199918


  Commit: 84f51c038630399127b47b34b883b6a0d91ecca6
      https://github.com/OpenSIPS/opensips/commit/84f51c038630399127b47b34b883b6a0d91ecca6
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M parser/sdp/sdp_helpr_funcs.c
    M xlog.c

  Log Message:
  -----------
  fix coverity detected false positives

CID #40557, #211391


  Commit: dc489bf6ebcede8010e42400ce9a0b377a4f78f7
      https://github.com/OpenSIPS/opensips/commit/dc489bf6ebcede8010e42400ce9a0b377a4f78f7
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_ws/proto_ws.c

  Log Message:
  -----------
  proto_ws: make sure we have destination to connect to

Fixes Coverity CID #58340


  Commit: e64627f2ae6a5d7392cb5af293e7975b52d64c3e
      https://github.com/OpenSIPS/opensips/commit/e64627f2ae6a5d7392cb5af293e7975b52d64c3e
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_smpp/db.c

  Log Message:
  -----------
  proto_smpp: skip entries with bad IP

Fixes Coverity CID #200075


  Commit: 518b78bd1c65957f538738498c28e581a62c9bfd
      https://github.com/OpenSIPS/opensips/commit/518b78bd1c65957f538738498c28e581a62c9bfd
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  proto_smpp: prevent NULL deref in case of bogus input

Fixes coverity CID #199973 and #199931


  Commit: e1463378f29835edf1676e0e5070ad26129d8b7e
      https://github.com/OpenSIPS/opensips/commit/e1463378f29835edf1676e0e5070ad26129d8b7e
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_hep/hep.c

  Log Message:
  -----------
  proto_hep: remove useless NULL check

Fixes Coverity CID #163991


  Commit: 85f32e9de0bc657c68786e8ef999d7b58f04044b
      https://github.com/OpenSIPS/opensips/commit/85f32e9de0bc657c68786e8ef999d7b58f04044b
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_wss/proto_wss.c

  Log Message:
  -----------
  proto_wss: add fall through indication

Fixes Coverity CID #58373


  Commit: f6bc3c1e528a4d4b6ddea3fb8739658887d8ddd6
      https://github.com/OpenSIPS/opensips/commit/f6bc3c1e528a4d4b6ddea3fb8739658887d8ddd6
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_tls/proto_tls.c

  Log Message:
  -----------
  proto_tls: make sure we have destination to connect to

Fixes Coverity CID #58361


  Commit: 3251e76822673c55aaf8d54972381677807d613e
      https://github.com/OpenSIPS/opensips/commit/3251e76822673c55aaf8d54972381677807d613e
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/db_text/dbt_file.c

  Log Message:
  -----------
  db_text: complete coverity CID #200093


  Commit: c8e8203eae7ea31390631de52ac4ede7e8ec7d04
      https://github.com/OpenSIPS/opensips/commit/c8e8203eae7ea31390631de52ac4ede7e8ec7d04
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/compression/gz_helpers.c
    M modules/cpl_c/cpl_parser.c
    M modules/db_berkeley/bdb_lib.c
    M modules/h350/h350_exp_fn.c
    M modules/jabber/jabber.c
    M modules/rabbitmq/rmq_servers.c
    M modules/rabbitmq_consumer/rmq_connection.c
    M modules/tls_mgm/tls_conn_ops.h
    M modules/tls_mgm/tls_conn_server.h

  Log Message:
  -----------
  fix more switch fall through

Coverity CID #199932, #199927, #164020, #164013, #150486, #58380,
    #58379, #58375, #58374, #40705, #40700, #40701


  Commit: 4428e07842330616124b77fc3403d3e1d27ac59d
      https://github.com/OpenSIPS/opensips/commit/4428e07842330616124b77fc3403d3e1d27ac59d
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M db/db_ut.c
    M db/db_ut.h
    M modules/db_berkeley/bdb_res.c
    M modules/db_berkeley/bdb_res.h
    M modules/db_berkeley/db_berkeley.c
    M modules/db_text/dbt_base.c
    M modules/db_text/dbt_lib.c
    M modules/db_text/dbt_lib.h
    M modules/db_text/dbt_res.c
    M modules/db_text/dbt_tb.c

  Log Message:
  -----------
  db: merge db_is_neq_type() in db_ut

Fix coverity CID #40717, #40718, #40719, #40720, #40721, #40722


  Commit: 3e24de754aa910491c08947ada3055379e2ccfa7
      https://github.com/OpenSIPS/opensips/commit/3e24de754aa910491c08947ada3055379e2ccfa7
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/rls/resource_notify.c

  Log Message:
  -----------
  rls: release memory in case of error

Fixes Coverity CID #199983


  Commit: df004396423fcd62b2476fd3fcab19402527f9eb
      https://github.com/OpenSIPS/opensips/commit/df004396423fcd62b2476fd3fcab19402527f9eb
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/pua_xmpp/simple2xmpp.c

  Log Message:
  -----------
  pua_xmpp: release memory in case of error

Fixes Coverity CID #199967


  Commit: 4f17d052eb8d1a883cf261412f9c3e09731d6c35
      https://github.com/OpenSIPS/opensips/commit/4f17d052eb8d1a883cf261412f9c3e09731d6c35
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  pua_dialoginfo: always parse callid

Fixes coverity CID #199930


Compare: https://github.com/OpenSIPS/opensips/compare/b4bf546faf7a...4f17d052eb8d