[OpenSIPS-Devel] [OpenSIPS/opensips] c72de0: prevent leak in case of oom

[Răzvan Crainea]

  Branch: refs/heads/3.1
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c72de0df58868d8fb47fed7474c2e61bf07a296e
      https://github.com/OpenSIPS/opensips/commit/c72de0df58868d8fb47fed7474c2e61bf07a296e
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M cfg_pp.c

  Log Message:
  -----------
  prevent leak in case of oom

Fixes Coverity #211383


  Commit: 7732d2054377866492ca8091631f0a23f8ad1935
      https://github.com/OpenSIPS/opensips/commit/7732d2054377866492ca8091631f0a23f8ad1935
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M lib/reg/common.c

  Log Message:
  -----------
  fix tcp_persistent_flag when list is not defined properly

Fixes Coverity #211381


  Commit: fbdf77b911307727e2c999d5a7346079d919fe6a
      https://github.com/OpenSIPS/opensips/commit/fbdf77b911307727e2c999d5a7346079d919fe6a
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/b2b_sca/sca_db_handler.c
    M modules/proto_ws/proto_ws.c
    M modules/speeddial/sdlookup.c
    M modules/tm/sip_msg.c
    M modules/tm/t_fifo.c
    M parser/parse_disposition.c
    M parser/parse_hname2.c
    M parser/parse_to.c
    M parser/parse_via.c
    M ut.c

  Log Message:
  -----------
  comment fall through switches

Fixes Coverity #40710, #211397, #40716, #40726, #40727, #40728, #40730,
    #40732, #58373, #58381, #199975, #200059, #200094, #211380, #211372,
    #211359


  Commit: 501573ef7e2d6320bb85b4b6c20f3fb7bc2655c4
      https://github.com/OpenSIPS/opensips/commit/501573ef7e2d6320bb85b4b6c20f3fb7bc2655c4
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/callops/callops.c

  Log Message:
  -----------
  callops: fix several coverity issues

CID #211388, #211360, #211378, #211373, #211369


  Commit: 878bc3361e54f205ef01a5fbd12da4079d143703
      https://github.com/OpenSIPS/opensips/commit/878bc3361e54f205ef01a5fbd12da4079d143703
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/rtpengine/rtpengine.c

  Log Message:
  -----------
  rtpengine: fix some coverity warnings

CID #211356 and #199981


  Commit: 6cbc49ccecf5e555e6aa1dffa896081e90effa8b
      https://github.com/OpenSIPS/opensips/commit/6cbc49ccecf5e555e6aa1dffa896081e90effa8b
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/rtpproxy/notification_process.c

  Log Message:
  -----------
  rtpproxy: fix coverity issues

CID #207908, #207917, #150494, #40688


  Commit: 401c6db8eb4ca67440e0b4dd904dcce2461f3577
      https://github.com/OpenSIPS/opensips/commit/401c6db8eb4ca67440e0b4dd904dcce2461f3577
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: fix coverity issues

CID #40640, #40494, #199944, #211361, #211358, #150473, #40673


  Commit: ac91cd4b9320d62620622f6d164945dd1348497e
      https://github.com/OpenSIPS/opensips/commit/ac91cd4b9320d62620622f6d164945dd1348497e
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M evi/evi_params.h

  Log Message:
  -----------
  evi: annotate evi_param_set_int to fix Coverity

Fixes several Coverity alarms


  Commit: 91bce48ccd3e8afb9990e15d752180eebdf2bc60
      https://github.com/OpenSIPS/opensips/commit/91bce48ccd3e8afb9990e15d752180eebdf2bc60
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/callops/callops.c

  Log Message:
  -----------
  callops: fix coverity CID #211388, #211360, #211369


  Commit: 6c5607697efd8544595c87119f2549cf665024f9
      https://github.com/OpenSIPS/opensips/commit/6c5607697efd8544595c87119f2549cf665024f9
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/callops/callops.c

  Log Message:
  -----------
  callops: rework coverity CID #211369


  Commit: 0d66a1dd1108d65df0227547cca003f2571201fd
      https://github.com/OpenSIPS/opensips/commit/0d66a1dd1108d65df0227547cca003f2571201fd
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: rework coverity fix CID #40640


  Commit: 80610da51d241cf02d834729c39669f51de99f35
      https://github.com/OpenSIPS/opensips/commit/80610da51d241cf02d834729c39669f51de99f35
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/dialog/dialog.c

  Log Message:
  -----------
  dialog: fix coverity CID #40494


  Commit: f8c1caef9200079ad727de4f6e51df43ae8b52e2
      https://github.com/OpenSIPS/opensips/commit/f8c1caef9200079ad727de4f6e51df43ae8b52e2
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: use correct dialog for sync (fix CID #40673)


  Commit: 22c4376a452cf997a7dccbe1601ea81e64722753
      https://github.com/OpenSIPS/opensips/commit/22c4376a452cf997a7dccbe1601ea81e64722753
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M evi/evi_params.h
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  rework some annotations to make coverity happy


  Commit: 3257fcd0884ec796371af58568874a707aa00d9f
      https://github.com/OpenSIPS/opensips/commit/3257fcd0884ec796371af58568874a707aa00d9f
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: initialize dummy value to sink CID #199944


  Commit: dbc9d07b0473d4142b3e2139e25577b042f0f8c0
      https://github.com/OpenSIPS/opensips/commit/dbc9d07b0473d4142b3e2139e25577b042f0f8c0
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: correctly handle str2int return code (CID #150473)


  Commit: cecbb3dbbb0a1b59420265f0bc6aaa9630c23af9
      https://github.com/OpenSIPS/opensips/commit/cecbb3dbbb0a1b59420265f0bc6aaa9630c23af9
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/tracer/tracer.c

  Log Message:
  -----------
  tracer: make sure vars are initialized

Fixes Coverity CID #200098


  Commit: b61c56bb2ab90be0375a808e39a562eb2ce14874
      https://github.com/OpenSIPS/opensips/commit/b61c56bb2ab90be0375a808e39a562eb2ce14874
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/db_text/dbt_file.c

  Log Message:
  -----------
  db_text: prevent buffer overflow

Fixes Coverity CID #200093


  Commit: 2998d371fed6a2091971bbdb97ea081f3ff4e319
      https://github.com/OpenSIPS/opensips/commit/2998d371fed6a2091971bbdb97ea081f3ff4e319
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/mi_html/http_fnc.c

  Log Message:
  -----------
  mi_html: fix improper free on error

Fixes Coverity CID #200040


  Commit: 7d0aed01b7571ee14f9488feae7607f07d7c7784
      https://github.com/OpenSIPS/opensips/commit/7d0aed01b7571ee14f9488feae7607f07d7c7784
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/drouting/drouting.c
    M modules/drouting/prefix_tree.c
    M modules/freeswitch/esl/src/esl.c
    M modules/mi_html/http_fnc.c
    M modules/rate_cacher/rate_cacher.c

  Log Message:
  -----------
  remove dead code

Fixes Coverity CID #163971, #40603, #163958, #163961, #200036, #211354,
      #211370, #211394


  Commit: aced94fdb5e8d0b00c0e29227b817dbdfe453cb0
      https://github.com/OpenSIPS/opensips/commit/aced94fdb5e8d0b00c0e29227b817dbdfe453cb0
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/qos/qos_ctx_helpers.c

  Log Message:
  -----------
  qos: fix getting SDP


  Commit: 2e67a655a6ec0537995d63881bbfbf86d3d7bb89
      https://github.com/OpenSIPS/opensips/commit/2e67a655a6ec0537995d63881bbfbf86d3d7bb89
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M parser/parse_to.c

  Log Message:
  -----------
  parse_to: add fallthrough comments/indications for coverity CID #200094


  Commit: 8bf39d3950d630bf402c8f7f026b129954f905a5
      https://github.com/OpenSIPS/opensips/commit/8bf39d3950d630bf402c8f7f026b129954f905a5
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/tm/cluster.c

  Log Message:
  -----------
  tm: cleanup replicated cancel msg

Fixes Coverity CID #200031


  Commit: ee98219b715c92124d613ea22b641c1d3e06457b
      https://github.com/OpenSIPS/opensips/commit/ee98219b715c92124d613ea22b641c1d3e06457b
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/db_text/dbt_file.c

  Log Message:
  -----------
  db_text: fix no-op code

fixes Coverity CID #200004


  Commit: cc02c7ee5a0901e80e2e73861dcf71bc4e621959
      https://github.com/OpenSIPS/opensips/commit/cc02c7ee5a0901e80e2e73861dcf71bc4e621959
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  proto_smpp: smpp_bind_transceiver_resp_t system id

Reported by Coverity CID #199918


  Commit: 8060e5548c2678dc55b38adb150c8a2dd0ba89ec
      https://github.com/OpenSIPS/opensips/commit/8060e5548c2678dc55b38adb150c8a2dd0ba89ec
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M parser/sdp/sdp_helpr_funcs.c
    M xlog.c

  Log Message:
  -----------
  fix coverity detected false positives

CID #40557, #211391


  Commit: 766b28ca0904911c3e43314162f0c7248b325d50
      https://github.com/OpenSIPS/opensips/commit/766b28ca0904911c3e43314162f0c7248b325d50
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_ws/proto_ws.c

  Log Message:
  -----------
  proto_ws: make sure we have destination to connect to

Fixes Coverity CID #58340


  Commit: 8fc31995c34717a49d837175b4ad107f71020036
      https://github.com/OpenSIPS/opensips/commit/8fc31995c34717a49d837175b4ad107f71020036
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_smpp/db.c

  Log Message:
  -----------
  proto_smpp: skip entries with bad IP

Fixes Coverity CID #200075


  Commit: 26c6d2fc494ecec22609c9fbe0e67c963223d8bd
      https://github.com/OpenSIPS/opensips/commit/26c6d2fc494ecec22609c9fbe0e67c963223d8bd
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  proto_smpp: prevent NULL deref in case of bogus input

Fixes coverity CID #199973 and #199931


  Commit: f3aca3506f9458ab5f468f9f87c17c4ddfb93a06
      https://github.com/OpenSIPS/opensips/commit/f3aca3506f9458ab5f468f9f87c17c4ddfb93a06
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_hep/hep.c

  Log Message:
  -----------
  proto_hep: remove useless NULL check

Fixes Coverity CID #163991


  Commit: d8cf269efdd5d5f8edfd8ec103a392e3356f538f
      https://github.com/OpenSIPS/opensips/commit/d8cf269efdd5d5f8edfd8ec103a392e3356f538f
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_wss/proto_wss.c

  Log Message:
  -----------
  proto_wss: add fall through indication

Fixes Coverity CID #58373


  Commit: 6043efdff0437591890495e0c03b1048f8b82fbb
      https://github.com/OpenSIPS/opensips/commit/6043efdff0437591890495e0c03b1048f8b82fbb
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/proto_tls/proto_tls.c

  Log Message:
  -----------
  proto_tls: make sure we have destination to connect to

Fixes Coverity CID #58361


  Commit: 1db0a9d6d3b39fa690830c8b830d9d042fa4df2d
      https://github.com/OpenSIPS/opensips/commit/1db0a9d6d3b39fa690830c8b830d9d042fa4df2d
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/b2b_entities/dlg.c
    M modules/b2b_logic/b2b_logic.c
    M modules/b2b_logic/entity_storage.c
    M modules/b2b_logic/logic.c
    M modules/b2b_logic/records.c
    M modules/b2b_sca/sca_logic.c

  Log Message:
  -----------
  b2b_logic: fix coverity errors

Fixes CID #200000, #211411, #211412, #211413, #211414, #211362, #40885,
      #40835, #40827, #40826, #40825, #40703, #40704


  Commit: 1c4be6cb1322f84c391f1fda44b2f0cc97514843
      https://github.com/OpenSIPS/opensips/commit/1c4be6cb1322f84c391f1fda44b2f0cc97514843
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/db_text/dbt_file.c

  Log Message:
  -----------
  db_text: complete coverity CID #200093


  Commit: 7dcd73b9bc295ba21c46f6a21615331ffff91476
      https://github.com/OpenSIPS/opensips/commit/7dcd73b9bc295ba21c46f6a21615331ffff91476
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/compression/gz_helpers.c
    M modules/cpl_c/cpl_parser.c
    M modules/db_berkeley/bdb_lib.c
    M modules/h350/h350_exp_fn.c
    M modules/jabber/jabber.c
    M modules/rabbitmq/rmq_servers.c
    M modules/rabbitmq_consumer/rmq_connection.c
    M modules/tls_mgm/tls_conn_ops.h
    M modules/tls_mgm/tls_conn_server.h

  Log Message:
  -----------
  fix more switch fall through

Coverity CID #199932, #199927, #164020, #164013, #150486, #58380,
    #58379, #58375, #58374, #40705, #40700, #40701


  Commit: a088d6b7f80e2a3532866b1d3b7ac208b77aab24
      https://github.com/OpenSIPS/opensips/commit/a088d6b7f80e2a3532866b1d3b7ac208b77aab24
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M db/db_ut.c
    M db/db_ut.h
    M modules/db_berkeley/bdb_res.c
    M modules/db_berkeley/bdb_res.h
    M modules/db_berkeley/db_berkeley.c
    M modules/db_text/dbt_base.c
    M modules/db_text/dbt_lib.c
    M modules/db_text/dbt_lib.h
    M modules/db_text/dbt_res.c
    M modules/db_text/dbt_tb.c

  Log Message:
  -----------
  db: merge db_is_neq_type() in db_ut

Fix coverity CID #40717, #40718, #40719, #40720, #40721, #40722


  Commit: 80a4005233af5c208d33d1447cb096f8c684d53f
      https://github.com/OpenSIPS/opensips/commit/80a4005233af5c208d33d1447cb096f8c684d53f
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/rls/resource_notify.c

  Log Message:
  -----------
  rls: release memory in case of error

Fixes Coverity CID #199983


  Commit: 1e74a83583caf521404030604af1b80270efcd9b
      https://github.com/OpenSIPS/opensips/commit/1e74a83583caf521404030604af1b80270efcd9b
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/pua_xmpp/simple2xmpp.c

  Log Message:
  -----------
  pua_xmpp: release memory in case of error

Fixes Coverity CID #199967


  Commit: ff8edcbcf46e8133615b6bf0029442344221b882
      https://github.com/OpenSIPS/opensips/commit/ff8edcbcf46e8133615b6bf0029442344221b882
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  pua_dialoginfo: always parse callid

Fixes coverity CID #199930


Compare: https://github.com/OpenSIPS/opensips/compare/2b9344075531...ff8edcbcf46e