[OpenSIPS-Devel] [OpenSIPS/opensips] e229e1: Revert "packaging: We no longer have atomic.h"

[Maxim Sobolev]

Just for the record: that fix for obscure compiler broke ongoing effort to
make OpenSIPS portable to anything but x86. Now ARM and MIPS builds are
down: :(

 https://travis-ci.org/github/OpenSIPS/opensips/builds/748559450

I am sorry to say that Liviu, but in the day and edge when Apple popping
out ARM64 laptops in millions, this hardly an acceptable solution to "defer
fix to the distant future".

Proper solution would be to test if stdatomic is usable and use it, falling
back to the non-portable "opensips atomics" when it's not present.

I'll work on a PR to add stdatomic as an option with fallback to atomic
when not available.

-Max

On Wed, Dec 9, 2020 at 6:30 AM Liviu Chircu <noreply at github.com> wrote:

>   Branch: refs/heads/master
>   Home:   https://github.com/OpenSIPS/opensips
>   Commit: e229e18e613c127105ccad70e6fd2256a51ad839
>
> https://github.com/OpenSIPS/opensips/commit/e229e18e613c127105ccad70e6fd2256a51ad839
>   Author: Liviu Chircu <liviu at opensips.org>
>   Date:   2020-12-09 (Wed, 09 Dec 2020)
>
>   Changed paths:
>     M packaging/debian/copyright
>
>   Log Message:
>   -----------
>   Revert "packaging: We no longer have atomic.h"
>
> This reverts commit 9dacffd696efcefe93e020adec0f25bb91aaeab7.
>
>
>   Commit: 670b203f2d7b4ebd6533062537167129609d08e3
>
> https://github.com/OpenSIPS/opensips/commit/670b203f2d7b4ebd6533062537167129609d08e3
>   Author: Liviu Chircu <liviu at opensips.org>
>   Date:   2020-12-09 (Wed, 09 Dec 2020)
>
>   Changed paths:
>     M mem/module_info.c
>
>   Log Message:
>   -----------
>   Revert "Fix last reference to atomic_set() (replace with atomic_init)."
>
> This reverts commit 4ed5ba188a969ab02829bbbb33bd5c87ac457b19.
>
>
>   Commit: dd417cb7e84ccb704d73eaa4450f7e8795dea8bb
>
> https://github.com/OpenSIPS/opensips/commit/dd417cb7e84ccb704d73eaa4450f7e8795dea8bb
>   Author: Liviu Chircu <liviu at opensips.org>
>   Date:   2020-12-09 (Wed, 09 Dec 2020)
>
>   Changed paths:
>     A atomic.h
>     M statistics.c
>     M statistics.h
>
>   Log Message:
>   -----------
>   Revert "Use stdatomic.h, which is part of C standard since C11."
>
> This reverts commit 18f4c3d9b34583c7464eba2e5ca8fe24f72e9fc9.
>
>
>   Commit: cff06b07f606537fb2976296cd6ee5c6705dae9a
>
> https://github.com/OpenSIPS/opensips/commit/cff06b07f606537fb2976296cd6ee5c6705dae9a
>   Author: Liviu Chircu <liviu at opensips.org>
>   Date:   2020-12-09 (Wed, 09 Dec 2020)
>
>   Changed paths:
>     M atomic.h
>
>   Log Message:
>   -----------
>   atomic.h: Add a deprecation notice
>
>
> Compare:
> https://github.com/OpenSIPS/opensips/compare/b95c2ed5a3cf...cff06b07f606
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>


-- 
Maksym Sobolyev
Sippy Software, Inc.
Internet Telephony (VoIP) Experts
Tel (Canada): +1-778-783-0474
Tel (Toll-Free): +1-855-747-7779
Fax: +1-866-857-6942
Web: http://www.sippysoft.com
MSN: sales at sippysoft.com
Skype: SippySoft
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20201209/4ea92ebc/attachment.html>