[OpenSIPS-Devel] [OpenSIPS/opensips] 525b30: port core script functions to the same interface a...

Maxim Sobolev sobomax at sippysoft.com
Fri Aug 2 16:18:02 EDT 2019


Bogdan & Vlad, just a suggestion in addition to a better documentation,
some change control process could be implemented. Maybe for those functions
that have to be deprecated in the future instead of killing them completely
in one shot you can turn it into the stub for one .x release, i.e. calling
say rewriteport(1234) would produce an error something like:

Aug 1 16:32:05 [22649] CRITICAL:core:yyerror: parse error in
opensips.cfg:63:23-24: <rewriteport("1234")>, function deprecated: use '$rp
= 1234' instead.

And then GC those stubs in one shot in the next minor or major release?

-Max

On Fri, Aug 2, 2019 at 9:57 AM Maxim Sobolev <sobomax at sippysoft.com> wrote:

> Thanks, Bogdan, much appreciated! We are on the right track now.
>
> https://travis-ci.org/sippy/voiptests/builds/567030834
>
> -Max
>
> On Fri, Aug 2, 2019 at 12:41 AM Bogdan-Andrei Iancu <bogdan at opensips.org>
> wrote:
>
>> Hi Maxim,
>>
>> point taken. Vlad will start working on the migration doc next week asap.
>> In the mean while, if you have any issues with any of the functions, just
>> let me know, I will try to help you.
>> In regards the rewriteport() - I guess it was dropped (I do not find it
>> in the exported list) as it can simply be replaced with "$rp = value"
>>
>> Thanks and regards,
>>
>> Bogdan-Andrei Iancu
>>
>> OpenSIPS Founder and Developer
>>   https://www.opensips-solutions.com
>> OpenSIPS Summit 2019
>>   https://www.opensips.org/events/Summit-2019Amsterdam/
>>
>> On 08/01/2019 08:13 PM, Maxim Sobolev wrote:
>>
>> Hi Vlad, this is rather invasive change which is going to affect lot
>> (most?) of OpenSIPS users. While understanding the value of re-organization
>> I am having troubles now what needs to be done to get those functions (such
>> as rewriteport() for example) to work properly.  Please supply some
>> documentation for conversion ASAP. In general it would be nice to have some
>> short reference in the commit message itself, so anyone who follows master
>> branch (like we do) does not have to look elsewhere.
>>
>> Thanks!
>>
>> -Max
>>
>> On Tue, Jul 30, 2019 at 10:57 AM Vlad Pătrașcu <noreply at github.com>
>> wrote:
>>
>>>   Branch: refs/heads/master
>>>   Home:   https://github.com/OpenSIPS/opensips
>>>   Commit: 525b30a2a08e4c960e2448d746d5926cca33cbe1
>>>
>>> https://github.com/OpenSIPS/opensips/commit/525b30a2a08e4c960e2448d746d5926cca33cbe1
>>>   Author: Vlad Patrascu <vladp at opensips.org>
>>>   Date:   2019-07-30 (Tue, 30 Jul 2019)
>>>
>>>   Changed paths:
>>>     M action.c
>>>     M action.h
>>>     M cfg.lex
>>>     M cfg.y
>>>     A cmds.c
>>>     A cmds.h
>>>     A core_cmds.c
>>>     M modules/avpops/avpops_impl.c
>>>     M modules/carrierroute/route_func.c
>>>     M modules/dispatcher/dispatch.c
>>>     M modules/drouting/drouting.c
>>>     M modules/lua/sipapi.c
>>>     M modules/perl/opensipsxs.xs
>>>     M modules/python/python_msgobj.c
>>>     M modules/textops/textops.c
>>>     M msg_translator.c
>>>     M parser/msg_parser.c
>>>     M parser/msg_parser.h
>>>     M pvar.c
>>>     M route.c
>>>     M route_struct.c
>>>     M route_struct.h
>>>     M sr_module.c
>>>     M sr_module.h
>>>     M ut.h
>>>
>>>   Log Message:
>>>   -----------
>>>   port core script functions to the same interface as module functions
>>>
>>>
>>>
>>> _______________________________________________
>>> Devel mailing list
>>> Devel at lists.opensips.org
>>> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20190802/3ddef6ab/attachment.html>


More information about the Devel mailing list