<div dir="ltr"><div dir="ltr">Bogdan & Vlad, just a suggestion in addition to a better documentation, some change control process could be implemented. Maybe for those functions that have to be deprecated in the future instead of killing them completely in one shot you can turn it into the stub for one .x release, i.e. calling say rewriteport(1234) would produce an error something like:<div><br></div><div><span style="color:rgb(241,241,241);font-family:Cousine,monospace;font-size:12px;white-space:pre-wrap;background-color:rgb(68,68,68)">Aug 1 16:32:05 [22649] CRITICAL:core:yyerror: parse error in opensips.cfg:63:23-24: <rewriteport("1234")>, function deprecated: use '$rp = 1234' instead. </span> <br></div><div><br></div><div>And then GC those stubs in one shot in the next minor or major release?</div><div><br></div><div>-Max</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 2, 2019 at 9:57 AM Maxim Sobolev <<a href="mailto:sobomax@sippysoft.com">sobomax@sippysoft.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">Thanks, Bogdan, much appreciated! We are on the right track now.<div><br></div><div><a href="https://travis-ci.org/sippy/voiptests/builds/567030834" target="_blank">https://travis-ci.org/sippy/voiptests/builds/567030834</a> <br></div><div><br></div><div>-Max</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 2, 2019 at 12:41 AM Bogdan-Andrei Iancu <<a href="mailto:bogdan@opensips.org" target="_blank">bogdan@opensips.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<tt>Hi Maxim,<br>
<br>
point taken. Vlad will start working on the migration doc next
week asap. In the mean while, if you have any issues with any of
the functions, just let me know, I will try to help you. <br>
In regards the rewriteport() - I guess it was dropped (I do not
find it in the exported list) as it can simply be replaced with
"$rp = value"<br>
<br>
Thanks and regards,<br>
</tt>
<pre class="gmail-m_703271833587154226gmail-m_-8324372784715819992moz-signature" cols="72">Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
<a class="gmail-m_703271833587154226gmail-m_-8324372784715819992moz-txt-link-freetext" href="https://www.opensips-solutions.com" target="_blank">https://www.opensips-solutions.com</a>
OpenSIPS Summit 2019
<a class="gmail-m_703271833587154226gmail-m_-8324372784715819992moz-txt-link-freetext" href="https://www.opensips.org/events/Summit-2019Amsterdam/" target="_blank">https://www.opensips.org/events/Summit-2019Amsterdam/</a>
</pre>
<div class="gmail-m_703271833587154226gmail-m_-8324372784715819992moz-cite-prefix">On 08/01/2019 08:13 PM, Maxim Sobolev
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi Vlad, this is rather invasive change which is
going to affect lot (most?) of OpenSIPS users. While
understanding the value of re-organization I am having troubles
now what needs to be done to get those functions (such as
rewriteport() for example) to work properly. Please supply some
documentation for conversion ASAP. In general it would be nice
to have some short reference in the commit message itself, so
anyone who follows master branch (like we do) does not have to
look elsewhere.
<div><br>
</div>
<div>Thanks!</div>
<div><br>
</div>
<div>-Max</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Jul 30, 2019 at 10:57
AM Vlad Pătrașcu <<a href="mailto:noreply@github.com" target="_blank">noreply@github.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Branch: refs/heads/master<br>
Home: <a href="https://github.com/OpenSIPS/opensips" rel="noreferrer" target="_blank">https://github.com/OpenSIPS/opensips</a><br>
Commit: 525b30a2a08e4c960e2448d746d5926cca33cbe1<br>
<a href="https://github.com/OpenSIPS/opensips/commit/525b30a2a08e4c960e2448d746d5926cca33cbe1" rel="noreferrer" target="_blank">https://github.com/OpenSIPS/opensips/commit/525b30a2a08e4c960e2448d746d5926cca33cbe1</a><br>
Author: Vlad Patrascu <<a href="mailto:vladp@opensips.org" target="_blank">vladp@opensips.org</a>><br>
Date: 2019-07-30 (Tue, 30 Jul 2019)<br>
<br>
Changed paths:<br>
M action.c<br>
M action.h<br>
M cfg.lex<br>
M cfg.y<br>
A cmds.c<br>
A cmds.h<br>
A core_cmds.c<br>
M modules/avpops/avpops_impl.c<br>
M modules/carrierroute/route_func.c<br>
M modules/dispatcher/dispatch.c<br>
M modules/drouting/drouting.c<br>
M modules/lua/sipapi.c<br>
M modules/perl/opensipsxs.xs<br>
M modules/python/python_msgobj.c<br>
M modules/textops/textops.c<br>
M msg_translator.c<br>
M parser/msg_parser.c<br>
M parser/msg_parser.h<br>
M pvar.c<br>
M route.c<br>
M route_struct.c<br>
M route_struct.h<br>
M sr_module.c<br>
M sr_module.h<br>
M ut.h<br>
<br>
Log Message:<br>
-----------<br>
port core script functions to the same interface as module
functions<br>
<br>
<br>
<br>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@lists.opensips.org" target="_blank">Devel@lists.opensips.org</a><br>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/devel</a><br>
</blockquote>
</div>
<br clear="all">
<div><br></div></blockquote></div></blockquote></div></div>
</blockquote></div><br clear="all"><div><br></div></div>