[OpenSIPS-Devel] mf_process_maxfwd_header is possibly broken in latest master

[Bogdan-Andrei Iancu]

Hi Maxim,

after the changes for data types and var support for the the parameters 
of the functions, the right syntax is:

     24    if (!mf_process_maxfwd_header( 10)) {
     25sl_send_reply( 483,"Too Many Hops");


Regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/

On 04/16/2019 08:22 PM, Maxim Sobolev wrote:
> Hi,
>
> I noticed that our voiptests suite fails in the last few days with 
> opensips/master. The culprit seems to be mf_process_maxfwd_header(), 
> looks like some semantics has changed:
>
> Error code seen:
>
> Apr 16 13:59:27 [22582] INFO:textops:mod_init: initializing...
> Apr 16 13:59:27 [22582] ERROR:core:fix_cmd: Param [1] expected to be 
> an integer or variable
> Apr 16 13:59:27 [22582] ERROR:core:fix_actions: Failed to fix command 
> <mf_process_maxfwd_header>
> Apr 16 13:59:27 [22582] ERROR:core:fix_actions: fixing failed 
> (code=-6) at opensips.cfg:24
> Apr 16 13:59:27 [22582] CRITICAL:core:fix_expr: fix_actions error
> Apr 16 13:59:27 [22582] ERROR:core:main: failed to fix configuration 
> with err code -6
> Apr 16 13:59:27 [22582] INFO:core:cleanup: cleanup
> Apr 16 13:59:27 [22582] NOTICE:core:main: Exiting....
>
> Configuration file in question:
>
>     20route {
>     21xlog("OpenSIPS received a request $rm from $si\n");
>     22## initial sanity checks -- messages with
>     23## max_forwards==0, or excessively long requests
>     24if (!mf_process_maxfwd_header("10")) {
>     25  sl_send_reply("483","Too Many Hops");
>     26  exit;
>     27};
>
> Full log can be seen here:
>
> https://travis-ci.org/sippy/voiptests/jobs/520516533
>
> Thanks and sorry if it's a false positive.
>
> -Max
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20190416/5c0955c5/attachment.html>