<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<tt>Hi Maxim,<br>
<br>
after the changes for data types and var support for the the
parameters of the functions, the right syntax is:<br>
</tt><br>
<div> 24<span style="white-space:pre"> </span> if
(!mf_process_maxfwd_header( 10)) {</div>
<div> 25<span style="white-space:pre"> </span>
sl_send_reply( 483,"Too Many Hops");</div>
<tt><br>
<br>
Regards, <br>
</tt>
<pre class="moz-signature" cols="72">Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
<a class="moz-txt-link-freetext" href="https://www.opensips-solutions.com">https://www.opensips-solutions.com</a>
OpenSIPS Summit 2019
<a class="moz-txt-link-freetext" href="https://www.opensips.org/events/Summit-2019Amsterdam/">https://www.opensips.org/events/Summit-2019Amsterdam/</a>
</pre>
<div class="moz-cite-prefix">On 04/16/2019 08:22 PM, Maxim Sobolev
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAH7qZfsuaQBdEbb+ZNJDgizsTKV=UZZ0wqDL8HDEKdUkvy0x-Q@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi,
<div><br>
</div>
<div>I noticed that our voiptests suite fails in the last
few days with opensips/master. The culprit seems to
be mf_process_maxfwd_header(), looks like some semantics
has changed:</div>
<div><br>
</div>
<div>Error code seen:</div>
<div><br>
</div>
<div>
<div>Apr 16 13:59:27 [22582] <a class="moz-txt-link-freetext" href="INFO:textops:mod_init">INFO:textops:mod_init</a>:
initializing...</div>
<div>Apr 16 13:59:27 [22582] ERROR:core:fix_cmd: Param
[1] expected to be an integer or variable</div>
<div>Apr 16 13:59:27 [22582] ERROR:core:fix_actions:
Failed to fix command <mf_process_maxfwd_header></div>
<div>Apr 16 13:59:27 [22582] ERROR:core:fix_actions:
fixing failed (code=-6) at opensips.cfg:24</div>
<div>Apr 16 13:59:27 [22582] CRITICAL:core:fix_expr:
fix_actions error</div>
<div>Apr 16 13:59:27 [22582] ERROR:core:main: failed to
fix configuration with err code -6</div>
<div>Apr 16 13:59:27 [22582] <a class="moz-txt-link-freetext" href="INFO:core:cleanup">INFO:core:cleanup</a>: cleanup</div>
<div>Apr 16 13:59:27 [22582] NOTICE:core:main:
Exiting....</div>
<div><br>
</div>
<div>Configuration file in question:</div>
<div><br>
</div>
<div>
<div> 20<span style="white-space:pre"> </span>route
{</div>
<div> 21<span style="white-space:pre"> </span>
xlog("OpenSIPS received a request $rm from $si\n");</div>
<div> 22<span style="white-space:pre"> </span>
## initial sanity checks -- messages with</div>
<div> 23<span style="white-space:pre"> </span>
## max_forwards==0, or excessively long requests</div>
<div> 24<span style="white-space:pre"> </span>
if (!mf_process_maxfwd_header("10")) {</div>
<div> 25<span style="white-space:pre"> </span>
sl_send_reply("483","Too Many Hops");</div>
<div> 26<span style="white-space:pre"> </span>
exit;</div>
<div> 27<span style="white-space:pre"> </span>
};</div>
</div>
<div><br>
</div>
<div>Full log can be seen here:</div>
<div><br>
</div>
<div><a
href="https://travis-ci.org/sippy/voiptests/jobs/520516533"
moz-do-not-send="true">https://travis-ci.org/sippy/voiptests/jobs/520516533</a> <br>
</div>
<div><br>
</div>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">Thanks and sorry if it's a false
positive.</div>
<div dir="ltr"><br>
</div>
<div>-Max</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Devel@lists.opensips.org">Devel@lists.opensips.org</a>
<a class="moz-txt-link-freetext" href="http://lists.opensips.org/cgi-bin/mailman/listinfo/devel">http://lists.opensips.org/cgi-bin/mailman/listinfo/devel</a>
</pre>
</blockquote>
<br>
</body>
</html>