[OpenSIPS-Devel] [OpenSIPS/opensips] 75426e: context API: Inline all getter/setter functions

Liviu Chircu liviu at opensips.org
Mon Oct 1 12:35:29 EDT 2018


  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 75426ed8aa07fe6d2b70106ecc970c73fee19fe7
      https://github.com/OpenSIPS/opensips/commit/75426ed8aa07fe6d2b70106ecc970c73fee19fe7
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M context.c
    M context.h

  Log Message:
  -----------
  context API: Inline all getter/setter functions

(cherry picked from commit d41b5da71db487410c7dbae68be100e4fe1a94ca)


  Commit: 386bc61a018a01711f3481e3ed98a671423a6aaf
      https://github.com/OpenSIPS/opensips/commit/386bc61a018a01711f3481e3ed98a671423a6aaf
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/acc/acc_extra.c
    M modules/acc/acc_extra.h
    M modules/acc/acc_logic.c
    M modules/acc/acc_logic.h
    M modules/acc/acc_vars.c

  Log Message:
  -----------
  acc: Improve code quality

    * rename expand_legs() -> push_leg() (self-explanatory)
    * do not use non-paranthesized macros as functions
    * simplify store_acc_table() and avoid shm_realloc() leak on oom
    * do not pass redundant function parameters
    * remove redundant ACC_PUT_CTX() calls
    * use str_strcmp() for added readability
    * acc_onreply_in(): improve readability

(cherry picked from commit 13c8244691db9541c92e45ab74d1e0a57cdbdf63)


  Commit: 51d56f5294d6c1e411a9c227f69ff600f00f2757
      https://github.com/OpenSIPS/opensips/commit/51d56f5294d6c1e411a9c227f69ff600f00f2757
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/acc/acc.c
    M modules/acc/acc.h
    M modules/acc/acc_extra.c
    M modules/acc/acc_extra.h
    M modules/acc/acc_logic.c
    M modules/acc/acc_mod.c

  Log Message:
  -----------
  acc: Improve code quality (part 2)

    * avoid cryptic str concat macros; just use init_str()
    * set_dlg_value(): truncate bogus strings before realloc'ing buffer
    * allow any whitespace chars while parsing type/flags (why not?)
    * remove extraneous function parameters
    * remove redundant conditions
    * improve some error logs
    * rename acc_dlg_ctx_cb() -> acc_merge_contexts()
    * rename acc_dlg_callback() -> acc_dlg_ended()

(cherry picked from commit fc48765ad3c0d72f1a39583970e440343248c69e)


  Commit: f574ae9ecb516cb7f58eb9993945839a1ad9c4fc
      https://github.com/OpenSIPS/opensips/commit/f574ae9ecb516cb7f58eb9993945839a1ad9c4fc
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/dialog/dlg_cb.h

  Log Message:
  -----------
  dialog: Document the callbacks

(cherry picked from commit 849ca807c7792a0598d53907328044718845f282)


  Commit: d8c5ccc7c1d3ed8720f914938432ae0f330c3b05
      https://github.com/OpenSIPS/opensips/commit/d8c5ccc7c1d3ed8720f914938432ae0f330c3b05
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/dialog/dlg_cb.c
    M modules/dialog/dlg_cb.h
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: Remove unused function and parameter

(cherry picked from commit bc840ad7bd2dc4cc785abd0b4df8c06790e2b09e)


  Commit: cd597cb0a07f7785c25f5f0a7e2be2c13cd2a8e3
      https://github.com/OpenSIPS/opensips/commit/cd597cb0a07f7785c25f5f0a7e2be2c13cd2a8e3
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/acc/acc_mod.c

  Log Message:
  -----------
  acc: Inherit db_default_url if db_url is not set

(cherry picked from commit e4747712bc99b6fedf3f2ec35ebf71198466ca35)


  Commit: 91320f7678af357c55ba48d4b5990dc08f33b32a
      https://github.com/OpenSIPS/opensips/commit/91320f7678af357c55ba48d4b5990dc08f33b32a
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/mid_registrar/save.c

  Log Message:
  -----------
  mid_registrar: Fix segfault on invalid AoR parameter

How to reproduce:
    mid_registrar_save("location", , "3600");
	(misplaced parameter: we actually provide a bad AoR SIP URI!)

(cherry picked from commit f24351189abb9acc4da1f0485c173f8f02fded3b)


  Commit: a73128fd5992f6c4dd43edb48d514b7cec089c53
      https://github.com/OpenSIPS/opensips/commit/a73128fd5992f6c4dd43edb48d514b7cec089c53
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/acc/acc.c

  Log Message:
  -----------
  acc: Fix constant-sized pkg leak on startup

(cherry picked from commit 1c60e0e49fd1f53c316fc8affd296f99fa83d39f)


Compare: https://github.com/OpenSIPS/opensips/compare/280a4dafca39...a73128fd5992
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Devel mailing list