[OpenSIPS-Devel] [OpenSIPS/opensips] d41b5d: context API: Inline all getter/setter functions

Liviu Chircu liviu at opensips.org
Mon Oct 1 12:32:40 EDT 2018


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d41b5da71db487410c7dbae68be100e4fe1a94ca
      https://github.com/OpenSIPS/opensips/commit/d41b5da71db487410c7dbae68be100e4fe1a94ca
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M context.c
    M context.h

  Log Message:
  -----------
  context API: Inline all getter/setter functions


  Commit: 13c8244691db9541c92e45ab74d1e0a57cdbdf63
      https://github.com/OpenSIPS/opensips/commit/13c8244691db9541c92e45ab74d1e0a57cdbdf63
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/acc/acc_extra.c
    M modules/acc/acc_extra.h
    M modules/acc/acc_logic.c
    M modules/acc/acc_logic.h
    M modules/acc/acc_vars.c

  Log Message:
  -----------
  acc: Improve code quality

    * rename expand_legs() -> push_leg() (self-explanatory)
    * do not use non-paranthesized macros as functions
    * simplify store_acc_table() and avoid shm_realloc() leak on oom
    * do not pass redundant function parameters
    * remove redundant ACC_PUT_CTX() calls
    * use str_strcmp() for added readability
    * acc_onreply_in(): improve readability


  Commit: 1c60e0e49fd1f53c316fc8affd296f99fa83d39f
      https://github.com/OpenSIPS/opensips/commit/1c60e0e49fd1f53c316fc8affd296f99fa83d39f
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/acc/acc.c

  Log Message:
  -----------
  acc: Fix constant-sized pkg leak on startup


  Commit: fc48765ad3c0d72f1a39583970e440343248c69e
      https://github.com/OpenSIPS/opensips/commit/fc48765ad3c0d72f1a39583970e440343248c69e
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/acc/acc.c
    M modules/acc/acc.h
    M modules/acc/acc_extra.c
    M modules/acc/acc_extra.h
    M modules/acc/acc_logic.c
    M modules/acc/acc_mod.c

  Log Message:
  -----------
  acc: Improve code quality (part 2)

    * avoid cryptic str concat macros; just use init_str()
    * set_dlg_value(): truncate bogus strings before realloc'ing buffer
    * allow any whitespace chars while parsing type/flags (why not?)
    * remove extraneous function parameters
    * remove redundant conditions
    * improve some error logs
    * rename acc_dlg_ctx_cb() -> acc_merge_contexts()
    * rename acc_dlg_callback() -> acc_dlg_ended()


  Commit: 849ca807c7792a0598d53907328044718845f282
      https://github.com/OpenSIPS/opensips/commit/849ca807c7792a0598d53907328044718845f282
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/dialog/dlg_cb.h

  Log Message:
  -----------
  dialog: Document the callbacks


  Commit: bc840ad7bd2dc4cc785abd0b4df8c06790e2b09e
      https://github.com/OpenSIPS/opensips/commit/bc840ad7bd2dc4cc785abd0b4df8c06790e2b09e
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/dialog/dlg_cb.c
    M modules/dialog/dlg_cb.h
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: Remove unused function and parameter


  Commit: 55ef67f949f75c91ba54800e0f02a3885e2a70ee
      https://github.com/OpenSIPS/opensips/commit/55ef67f949f75c91ba54800e0f02a3885e2a70ee
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    A lib/dbg/backtrace.h

  Log Message:
  -----------
  lib: Add log_backtrace() - a stack printing function

Turn on -DEXTRA_DEBUG in Makefile.conf in order to enable it


  Commit: 1bca75345944ec89acb2223331823ca758cb1ea4
      https://github.com/OpenSIPS/opensips/commit/1bca75345944ec89acb2223331823ca758cb1ea4
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/acc/acc.c

  Log Message:
  -----------
  acc: Improve some byte-manipulation macros

We make them both more efficient and more human-friendly.

NOTICE: Do NOT backport this commit!!
    (it's actually backwards-incompatible -- if you reload acc data from
     DB using the new code, opensips will likely crash, since the two
     "length" bytes are stored MSB-LSB now, as opposed to LSB-MSB before)


  Commit: e4747712bc99b6fedf3f2ec35ebf71198466ca35
      https://github.com/OpenSIPS/opensips/commit/e4747712bc99b6fedf3f2ec35ebf71198466ca35
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/acc/acc_mod.c

  Log Message:
  -----------
  acc: Inherit db_default_url if db_url is not set


  Commit: f24351189abb9acc4da1f0485c173f8f02fded3b
      https://github.com/OpenSIPS/opensips/commit/f24351189abb9acc4da1f0485c173f8f02fded3b
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/mid_registrar/save.c

  Log Message:
  -----------
  mid_registrar: Fix segfault on invalid AoR parameter

How to reproduce:
    mid_registrar_save("location", , "3600");
	(misplaced parameter: we actually provide a bad AoR SIP URI!)


Compare: https://github.com/OpenSIPS/opensips/compare/ede41a41d036...f24351189abb
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the Devel mailing list