[OpenSIPS-Devel] ACC - CDR creation - 1.11 vs 2.3

[Răzvan Crainea]

Hi, Adam!

I agree we should have better documented the fields change, and the 
commit you pointed out is one of the changes that have impact to the 
structure of the records: i.e. if you are using db_flatstore, than the 
order of the fields will change.
Thank you for pointing this out, we will try to pay more attention when 
things like this happen, and document them properly.

Best regards,
Răzvan

On 05/30/2018 03:11 PM, Adam Overbeeke wrote:
> Hi Răzvan,
> 
> /Thank you for the reply. The issues is the lack of documentation for a 
> specific commit. Here is the current `List of DB changes` for version 
> 1.11 – 2.1: /
> 
>   * /acc/,*missed_calls*table - NEW columns: "created" and "setuptime"
>     (*94cf5dd* <https://github.com/OpenSIPS/opensips/commit/94cf5dd>)
> 
> This commit (*94cf5dd* 
> <https://github.com/OpenSIPS/opensips/commit/94cf5dd>)has a ‘breaking 
> change’ / ‘undocumented change’ in it. Someone changed the order of 
> acc_duration_col in the db_keys array. Here is the actual commit and line.
> 
> https://github.com/OpenSIPS/opensips/commit/94cf5dd41ce01e9b1d05cb8634dd5cec5fdf0af6#diff-1394446c130358846c82519a3990ad36L479
> 
> This switching of the order was not documented and caused errors in our 
> account system.
> 
> Thanks,
> 
> Adam
> 
> PS. What is the best way to reply to these mailing lists? Should I just 
> send the reply back to the devel list or should I send them directly to 
> the responder?
> 

-- 
Răzvan Crainea
OpenSIPS Core Developer
   http://www.opensips-solutions.com