[OpenSIPS-Devel] [OpenSIPS/opensips] 2d02ff: Fix dialog unref for local BYEs.

[Bogdan-Andrei Iancu]

  Branch: refs/heads/2.3
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2d02ffba4890457ee2f3e0a49b59bea2c7872c7f
      https://github.com/OpenSIPS/opensips/commit/2d02ffba4890457ee2f3e0a49b59bea2c7872c7f
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-04-17 (Tue, 17 Apr 2018)

  Changed paths:
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_req_within.c

  Log Message:
  -----------
  Fix dialog unref for local BYEs.

Instead of unref-ing the dialog when a final reply is received for the local BYE, better wait until the BYE transaction is destroyed. IF not, we will end up with a dangling dailog pointer in the BYE transaction.
Fix for #1330 where a local BYE retransmission in combination with TH ends up acessing the dangling dialog pointer.
Many thanks to Nick Altmann for the support in investigating this issue.

(cherry picked from commit ec52613da12d43299edf0dab26ae80e5d2153854)