[OpenSIPS-Devel] [OpenSIPS/opensips] 9d93c8: Fix dialog unref for local BYEs.

[Bogdan-Andrei Iancu]

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9d93c82560c94e96272277f46cccebf711dd8165
      https://github.com/OpenSIPS/opensips/commit/9d93c82560c94e96272277f46cccebf711dd8165
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-04-17 (Tue, 17 Apr 2018)

  Changed paths:
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_req_within.c

  Log Message:
  -----------
  Fix dialog unref for local BYEs.

Instead of unref-ing the dialog when a final reply is received for the local BYE, better wait until the BYE transaction is destroyed. IF not, we will end up with a dangling dailog pointer in the BYE transaction.
Fix for #1330 where a local BYE retransmission in combination with TH ends up acessing the dangling dialog pointer.
Many thanks to Nick Altmann for the support in investigating this issue.

(cherry picked from commit ec52613da12d43299edf0dab26ae80e5d2153854)


  Commit: 1ed8eeda7b62862829bbcf06e07d8e417529c4e9
      https://github.com/OpenSIPS/opensips/commit/1ed8eeda7b62862829bbcf06e07d8e417529c4e9
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-04-17 (Tue, 17 Apr 2018)

  Changed paths:
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_req_within.c

  Log Message:
  -----------
  Fix CRIT logs back to DBG.

(cherry picked from commit ee7db82ae39eb13fa3675dd05112731af36dfbfc)


Compare: https://github.com/OpenSIPS/opensips/compare/2b66949403ec...1ed8eeda7b62