[OpenSIPS-Devel] [opensips] OpenSIPS accepts broken Contact header, then fails to start (#729)

[Saúl Ibarra Corretgé]

Hi Razvan!

Thanks for the tip!

As for the fix, I think OpenSIPS should make sure the data is correct
before putting it on the DB, so that REGISTER should have been rejected.

Now, data might end up bogus on the DB due to bugs, so ignoring the broken
records on startup sounds like a sensible thing to do IMHO.
On Dec 18, 2015 6:09 PM, "Răzvan Crainea" <notifications at github.com> wrote:

> Hi Saul!
>
> Not sure whether the problem is that opensips accepts the bogus Contact
> header, or it does not start if the contact in the DB is bogus. Probably
> both?
> The first problem can be solved by using the sipmsg_validate() function.
> Not sure if we should explicitly validate the contact before inserting it
> in the database.
> However, the second problem seems more serious, since OpenSIPS does not
> start, no matter where that Contact header ended up in the database.
>
> Will look into this next week.
>
> Best regards,
> Răzvan
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OpenSIPS/opensips/issues/729#issuecomment-165842055>.
>


---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/issues/729#issuecomment-165923461
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20151218/43add406/attachment.htm>