[OpenSIPS-Devel] [opensips] Changes to stop keepalives on unregisters (#366)

David Sanders notifications at github.com
Mon Oct 20 13:12:24 CEST 2014

Observed cases where keepalives from `nat_traversal` continued after unregister were traced back to a few lines of code which prevented stopping keepalives on unregister events.

There are three main changes here:
1. Allow `SIP_Registration_update` to decrease a keepalive time
2. If a successful register reply has no contact field assume no remaining contacts exist and stop keepalives
3. If a successful register reply has no contacts which match the request then it was an unregister and stop keepalives

These changes have been in use in a high traffic production environment for two years now with no known ill effect. Logic should still be double checked to ensure the changes are general enough to incorporate back into OpenSIPS.
You can merge this Pull Request by running:

  git pull https://github.com/dsanders11/opensips patch-2

Or you can view, comment on it, or merge it online at:


-- Commit Summary --

  * Changes to stop keepalives on unregisters

-- File Changes --

    M modules/nat_traversal/nat_traversal.c (20)

-- Patch Links --


Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20141020/dab2213f/attachment.htm>

More information about the Devel mailing list