[OpenSIPS-Devel] Cachedb_Couchbase questions

[Ryan Bullock]

Ok, I need to dig into this anyways so I will see what I can find and work
up a patch based on that.

Regards,

Ryan




On Thu, Apr 18, 2013 at 7:41 AM, Vlad Paiu <vladpaiu at opensips.org> wrote:

> **
> Hi Ryan,
>
> Wondered about that myself when the module was built, about why they would
> have two different mechanisms for reporting errors. I included both just
> for the sake of reporting all errors, but didn't see the
> lcb_get_last_error() triggering.
> I guess we need the help of some libcouchbase devs here, or dig into the
> libcouchbase code to see when lcb_get_last_error() triggers and error.
>
> Best Regards,
>
> Vlad Paiu
> OpenSIPS Developerhttp://www.opensips-solutions.com
>
>
> On 04/18/2013 12:54 AM, Ryan Bullock wrote:
>
>   Hey all,
>
>  I am doing some work with opensips + couchbase and have started on a
> patchset for the opensips couchbase driver to clean up a few things (better
> error outputs, etc) and make some changes that we require before going
> production.
>
>  One thing I am noticing are calls to lcb_get_last_error() after every
> operation, even though the error on the callback is being stored in
> last_error. In my quick testing the response from lcb_get_last_error()
> seems to always be success even if the operation failed (such as due to a
> connection failure), last_error shows the correct failure.
>
> I am wondering if the checks to lcb_get_last_error could be removed? Or
> are their instances where it would show an error not caught by last_error?
> I don't see many uses of lcb_get_last_error in the libcouchbase examples
> and they seem to all go off the error in the callback. The benefit I see is
> being able to more easily report useful and relevant errors.
>
>  Input welcome.
>
>  Regards,
>
> Ryan
>
>
>
> _______________________________________________
> Devel mailing listDevel at lists.opensips.orghttp://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20130418/21f25f8f/attachment.htm>