[OpenSIPS-Devel] [ opensips-Patches-3042432 ] [pua] add a "publish" queue to avoid deadlock

[Anca Vamanu]

On 08/16/2010 01:45 PM, Alex Hermann wrote:
> I have tesetd the new implementation and have a few comments and patches. I
> post them here, because SF doesn't allow me to attach patches to the ticket.
>
>
> 1) fix for a segfault in build_pending_publ.
>
>
> 2) Add queueing. In your implementation you only keep one extra publish. I'd
> prefer that the presence server receives all publishes, so i updated the patch
> from csollet to put them in a queue.
>
>
> 3) update_pua still needs to be rewritten to also queue publishes. Now it does
> nothing and thus the hash is never cleaned.
>
>    
Hi Alex,

Thank you very much for the patches and observations.
1) I kept getting a crash also - something with shm memory corrupted, 
but couldn't find the source - I wonder if this is the cause for it also.
2) Ok, I did it without queues to keep it simple, but if you were 
willing include the queues, it's just great.
3) Good observation - the serialization mechanism must also be included 
in the update_pua function. I will do this.

Regards,

-- 
Anca Vamanu
www.voice-system.ro