[OpenSIPS-Devel] Refactoring in db_uri module.

[Sergio Gutierrez]

Hi Bogdan.

Thanks for your answer. I will start working in this issue, and in case of
trouble, I will be contacting you.

Thanks and regards.

Sergio G.


On Fri, Oct 24, 2008 at 11:47 AM, Bogdan-Andrei Iancu <
bogdan at voice-system.ro> wrote:

> Hi Sergio,
>
> I think using the DB API instead of local function will be benefic to code
> maintenance; and a module should accept only one version :) it is safer.
>
> If you want to start this work, If needed, I offer my help on this.
>
> Regards,
> Bogdan
>
> Sergio Gutierrez wrote:
>
>> Hello all.
>>
>> Trying to fix some little things, and starting to dive into the code, I
>> found an issue related to redundant code in uri_db module, and I would like
>> to ask your opinion about it, and in case you consider it right, I would
>> like to offer to make this refactoring.
>>
>> I can see that DB API has a function which performs the table version
>> validation, in a generic way, but in uri_db module are other specific
>> functions which perform the same task; the only difference is that funcion
>> in API validates that version on database must be equal to version in
>> module, not allowing values greater than, as functions in module do allow.
>>
>> Do you think that it is worth to refactor the module, so that it uses the
>> generic version check functions instead having redundant functions within
>> module?
>>
>> Thanks in advance for your attention.
>>
>> Awaiting for your comments,
>>
>> Sergio Gutiérrez.
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Devel mailing list
>> Devel at lists.opensips.org
>> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.opensips.org/pipermail/devel/attachments/20081024/ded19e10/attachment.htm