Hi Bogdan.<br><br>Thanks for your answer. I will start working in this issue, and in case of trouble, I will be contacting you.<br><br>Thanks and regards.<br><br>Sergio G.<br><br><br><div class="gmail_quote">On Fri, Oct 24, 2008 at 11:47 AM, Bogdan-Andrei Iancu <span dir="ltr"><<a href="mailto:bogdan@voice-system.ro">bogdan@voice-system.ro</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi Sergio,<br>
<br>
I think using the DB API instead of local function will be benefic to code maintenance; and a module should accept only one version :) it is safer.<br>
<br>
If you want to start this work, If needed, I offer my help on this.<br>
<br>
Regards,<br>
Bogdan<br>
<br>
Sergio Gutierrez wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div></div><div class="Wj3C7c">
Hello all.<br>
<br>
Trying to fix some little things, and starting to dive into the code, I found an issue related to redundant code in uri_db module, and I would like to ask your opinion about it, and in case you consider it right, I would like to offer to make this refactoring.<br>
<br>
I can see that DB API has a function which performs the table version validation, in a generic way, but in uri_db module are other specific functions which perform the same task; the only difference is that funcion in API validates that version on database must be equal to version in module, not allowing values greater than, as functions in module do allow.<br>
<br>
Do you think that it is worth to refactor the module, so that it uses the generic version check functions instead having redundant functions within module?<br>
<br>
Thanks in advance for your attention.<br>
<br>
Awaiting for your comments,<br>
<br>
Sergio Gutiérrez.<br></div></div>
------------------------------------------------------------------------<br>
<br>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@lists.opensips.org" target="_blank">Devel@lists.opensips.org</a><br>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/devel" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/devel</a><br>
<br>
</blockquote>
<br>
</blockquote></div><br>