[OpenSIPS-Devel] SF.net SVN: opensips:[5022] trunk/modules/auth_db/authorize.c

[Sergio Gutierrez]

Hi Dan.

You are completely right. I apologize or commiting changes without rigorous
enough testing.

It will not happen again.

Regards.

Sergio.


On 11/24/08, Dan Pascu <dan at ag-projects.com> wrote:
>
> On Sunday 23 November 2008, Sergio Gutierrez wrote:
> > Revision: 5022
> >
> > http://opensips.svn.sourceforge.net/opensips/?rev=5022&view=rev Author:
> >   saguti
> > Date:     2008-11-23 21:14:36 +0000 (Sun, 23 Nov 2008)
> >
> > Log Message:
> > -----------
> > - free_result is correctly called at other point. Code not necessary.
>
> It would be nice to test these changes before committing them, to avoid
> polluting the svn history with pointless patches. 2 of the 4 patches that
> were committed (for a net null end result) could have been avoided by
> compiling the module after the change (as they were related to syntax and
> type errors that the compiler would have revealed). The other 2 could be
> avoided by a better inspection of the code before making changes.
>
> --
> Dan
>



-- 
Sergio Gutiérrez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.opensips.org/pipermail/devel/attachments/20081124/99dc4a24/attachment.htm