<div>Hi Dan.</div>
<div> </div>
<div>You are completely right. I apologize or commiting changes without rigorous enough testing.</div>
<div> </div>
<div>It will not happen again.</div>
<div> </div>
<div>Regards.</div>
<div> </div>
<div>Sergio.<br><br> </div>
<div><span class="gmail_quote">On 11/24/08, <b class="gmail_sendername">Dan Pascu</b> <<a href="mailto:dan@ag-projects.com">dan@ag-projects.com</a>> wrote:</span>
<blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">On Sunday 23 November 2008, Sergio Gutierrez wrote:<br>> Revision: 5022<br>><br>> <a href="http://opensips.svn.sourceforge.net/opensips/?rev=5022&view=rev">http://opensips.svn.sourceforge.net/opensips/?rev=5022&view=rev</a> Author:<br>
> saguti<br>> Date: 2008-11-23 21:14:36 +0000 (Sun, 23 Nov 2008)<br>><br>> Log Message:<br>> -----------<br>> - free_result is correctly called at other point. Code not necessary.<br><br>It would be nice to test these changes before committing them, to avoid<br>
polluting the svn history with pointless patches. 2 of the 4 patches that<br>were committed (for a net null end result) could have been avoided by<br>compiling the module after the change (as they were related to syntax and<br>
type errors that the compiler would have revealed). The other 2 could be<br>avoided by a better inspection of the code before making changes.<br><br>--<br>Dan<br></blockquote></div><br><br clear="all"><br>-- <br>Sergio Gutiérrez