<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<tt>Hi Pete,<br>
<br>
I already raised a comment on the culprit commit.<br>
<br>
Regards,<br>
</tt>
<pre class="moz-signature" cols="72">Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
<a class="moz-txt-link-freetext" href="https://www.opensips-solutions.com">https://www.opensips-solutions.com</a>
OpenSIPS Summit 2019
<a class="moz-txt-link-freetext" href="https://www.opensips.org/events/Summit-2019Amsterdam/">https://www.opensips.org/events/Summit-2019Amsterdam/</a>
</pre>
<div class="moz-cite-prefix">On 08/14/2019 10:46 AM, Pete Kelly
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAEWH9M9aHykxtVCFzwcJYqOWdhEr9Ee+26+kXep20HAeQH1Ziw@mail.gmail.com">
<div>
<div dir="auto">Aha.</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">Thanks for finding that Bodgan. Setting to 0 does
indeed work.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Should I raise a bug report about this?</div>
<div dir="auto"><br>
</div>
<div dir="auto">Pete </div>
<div><br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, 13 Aug 2019 at
11:42, Bogdan-Andrei Iancu <<a
href="mailto:bogdan@opensips.org" moz-do-not-send="true">bogdan@opensips.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> <tt>OK, the issue
was introduced with this commit:<br>
<a class="m_1507167353564477720moz-txt-link-freetext"
href="https://github.com/OpenSIPS/opensips/commit/045eea09bfb294f5a615d508bd3fc70317389563#diff-077e335c49f591dee316bb34fbddcd98"
target="_blank" moz-do-not-send="true">https://github.com/OpenSIPS/opensips/commit/045eea09bfb294f5a615d508bd3fc70317389563#diff-077e335c49f591dee316bb34fbddcd98</a><br>
<br>
This commit moved the "received" param to the second
Path header (when doing interface switching), but this
second hdr is optional, it is added only if different
(as interface) from the first one.<br>
So, if you have a single Path hdr to be added, the
"received" will be missed, as it is added to a hdr what
will be discarded at the end (not included in the SIP
message).<br>
<br>
Regards,<br>
</tt></div>
<div bgcolor="#FFFFFF" text="#000000">
<pre class="m_1507167353564477720moz-signature" cols="72">Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
<a class="m_1507167353564477720moz-txt-link-freetext" href="https://www.opensips-solutions.com" target="_blank" moz-do-not-send="true">https://www.opensips-solutions.com</a>
OpenSIPS Summit 2019
<a class="m_1507167353564477720moz-txt-link-freetext" href="https://www.opensips.org/events/Summit-2019Amsterdam/" target="_blank" moz-do-not-send="true">https://www.opensips.org/events/Summit-2019Amsterdam/</a>
</pre>
<div class="m_1507167353564477720moz-cite-prefix">On
08/13/2019 12:54 PM, Bogdan-Andrei Iancu wrote:<br>
</div>
<blockquote type="cite"> <tt>And in your case, it is a
double Path scenario, or you get only one added ?<br>
<br>
Regards,<br>
</tt>
<pre class="m_1507167353564477720moz-signature" cols="72">Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
<a class="m_1507167353564477720moz-txt-link-freetext" href="https://www.opensips-solutions.com" target="_blank" moz-do-not-send="true">https://www.opensips-solutions.com</a>
OpenSIPS Summit 2019
<a class="m_1507167353564477720moz-txt-link-freetext" href="https://www.opensips.org/events/Summit-2019Amsterdam/" target="_blank" moz-do-not-send="true">https://www.opensips.org/events/Summit-2019Amsterdam/</a>
</pre>
<div class="m_1507167353564477720moz-cite-prefix">On
08/13/2019 11:17 AM, Pete Kelly wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi Bogdan
<div><br>
</div>
<div>It's set to 1 (as is use_received)</div>
<div><br>
</div>
<div>Pete</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, 13 Aug
2019 at 07:53, Bogdan-Andrei Iancu <<a
href="mailto:bogdan@opensips.org"
target="_blank" moz-do-not-send="true">bogdan@opensips.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px
0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF"> <tt>Hi Pete,<br>
<br>
What is the setting for the
`enable_double_path` modparam ?<br>
<br>
Regards,<br>
</tt>
<pre class="m_1507167353564477720gmail-m_1274885756521063392moz-signature" cols="72">Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
<a class="m_1507167353564477720gmail-m_1274885756521063392moz-txt-link-freetext" href="https://www.opensips-solutions.com" target="_blank" moz-do-not-send="true">https://www.opensips-solutions.com</a>
OpenSIPS Summit 2019
<a class="m_1507167353564477720gmail-m_1274885756521063392moz-txt-link-freetext" href="https://www.opensips.org/events/Summit-2019Amsterdam/" target="_blank" moz-do-not-send="true">https://www.opensips.org/events/Summit-2019Amsterdam/</a>
</pre>
<div
class="m_1507167353564477720gmail-m_1274885756521063392moz-cite-prefix">On
08/12/2019 04:34 PM, Pete Kelly wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hello!
<div><br>
</div>
<div>I am using add_path_received() when
"proxying" REGISTERs through an edge
proxy, and have been successfully using it
with earlier versions of OpenSIPS (1.x,
2.1, 2.2, 2.3) with the same script.</div>
<div><br>
</div>
<div>However I have noticed that since at
least 2.4.5 it does not seem to be
behaving, the add_path_received() function
is *not* adding the received param - it's
behaving exactly as add_path() would
behave.</div>
<div><br>
</div>
<div>I've tried checking the return code and
also increasing debugging, but there is no
output to suggest that the function call
itself is failing.</div>
<div><br>
</div>
<div>I also noticed this ticket, but it
shouldn't affect 2.4 <a
href="https://github.com/OpenSIPS/opensips/issues/1739"
target="_blank" moz-do-not-send="true">https://github.com/OpenSIPS/opensips/issues/1739</a></div>
<div><br>
</div>
<div><br>
</div>
<div>Are there any suggestions?</div>
<div><br>
</div>
<div>Pete</div>
</div>
<br>
<fieldset
class="m_1507167353564477720gmail-m_1274885756521063392mimeAttachmentHeader"></fieldset>
<br>
<pre>_______________________________________________
Users mailing list
<a class="m_1507167353564477720gmail-m_1274885756521063392moz-txt-link-abbreviated" href="mailto:Users@lists.opensips.org" target="_blank" moz-do-not-send="true">Users@lists.opensips.org</a>
<a class="m_1507167353564477720gmail-m_1274885756521063392moz-txt-link-freetext" href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" target="_blank" moz-do-not-send="true">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a>
</pre>
</blockquote>
<br>
</div>
</blockquote>
</div>
</blockquote>
<br>
<br>
<fieldset
class="m_1507167353564477720mimeAttachmentHeader"></fieldset>
<br>
<pre>_______________________________________________
Users mailing list
<a class="m_1507167353564477720moz-txt-link-abbreviated" href="mailto:Users@lists.opensips.org" target="_blank" moz-do-not-send="true">Users@lists.opensips.org</a>
<a class="m_1507167353564477720moz-txt-link-freetext" href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" target="_blank" moz-do-not-send="true">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a>
</pre>
</blockquote>
<br>
</div>
</blockquote>
</div>
</div>
-- <br>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">Sent from Gmail Mobile</div>
</blockquote>
<br>
</body>
</html>