<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p><tt>Hi Sebastian,</tt></p>
    <p><tt>It seems something has gone terribly wrong during the
        backport of the "NAT fixes" patch to 2.3. I ran my "master"
        branch tests over the latest "2.3" branch, and, indeed, the
        Received is not getting saved.</tt></p>
    <p><tt>Will update you asap with more info.</tt></p>
    <p><tt>Best regards,<br>
      </tt></p>
    <pre class="moz-signature" cols="72">Liviu Chircu
OpenSIPS Developer
<a class="moz-txt-link-freetext" href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a></pre>
    <div class="moz-cite-prefix">On 20.03.2018 03:03, Sebastian Sastre
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAB=UX=A4V6T8a30XvUM49E95duEPi+8wv4m24ZZWxDeeYGLVng@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_default" style="font-family:tahoma,sans-serif">​sorry
          for the delay, needed to make sure nothing else could be
          creating a problem. </div>
        <div class="gmail_default" style="font-family:tahoma,sans-serif"><br>
        </div>
        <div class="gmail_default" style="font-family:tahoma,sans-serif">
          <div class="gmail_default">Yes. I am setting received avp on
            all modules (nathelper, registrar and mid registrar) . </div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default">These are my config parameters ( I
            tried all 3 modes and the insertion modes too) </div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default">
            <div class="gmail_default">#### Nathelper protocol</div>
            <div class="gmail_default">loadmodule "nathelper.so"</div>
            <div class="gmail_default">modparam("nathelper",
              "natping_interval", 10)</div>
            <div class="gmail_default">modparam("nathelper",
              "ping_nated_only", 1)</div>
            <div class="gmail_default">modparam("nathelper",
              "sipping_method", "OPTIONS")</div>
            <div class="gmail_default">modparam("nathelper",
              "received_avp", "$avp(rcv)") </div>
            <div class="gmail_default"><br>
            </div>
            <div class="gmail_default">#### REGISTRAR module</div>
            <div class="gmail_default">loadmodule "registrar.so"</div>
            <div class="gmail_default">modparam("registrar",
              "tcp_persistent_flag", "TCP_PERSIST_REGISTER")</div>
            <div class="gmail_default">modparam("registrar",
              "max_contacts", 1)</div>
            <div class="gmail_default">modparam("registrar",
              "received_avp", "$avp(rcv)") </div>
            <div class="gmail_default"><br>
            </div>
            <div class="gmail_default">loadmodule "mid_registrar.so"</div>
            <div class="gmail_default">modparam("mid_registrar", "mode",
              2<span class="gmail-Apple-tab-span" style="white-space:pre">    </span>) </div>
            <div class="gmail_default">modparam("mid_registrar",
              "outgoing_expires", 7200)</div>
            <div class="gmail_default">modparam("mid_registrar",
              "insertion_mode", 1)</div>
            <div class="gmail_default">modparam("mid_registrar",
              "tcp_persistent_flag", "TCP_PERSIST_REGISTER")</div>
            <div class="gmail_default">modparam(“mid_registrar”,
              "received_avp", "$avp(rcv)") </div>
            <div class="gmail_default"><br>
            </div>
          </div>
        </div>
        <div class="gmail_default" style="font-family:tahoma,sans-serif">I
          created a simple config first calling mid_registrar save and I
          got this location . </div>
        <div class="gmail_default" style="font-family:tahoma,sans-serif"><br>
        </div>
        <div class="gmail_default" style="font-family:tahoma,sans-serif">
          <div class="gmail_default">root@registrar151:~$ opensipsctl ul
            show</div>
          <div class="gmail_default">Domain:: location hash_size=512</div>
          <div class="gmail_default">        AOR:: <a
              href="mailto:user@domain.com" moz-do-not-send="true">user@domain.com</a></div>
          <div class="gmail_default">                Contact:: <a
              href="mailto:sip%3Apj1f3tuc@192.0.2.13"
              moz-do-not-send="true">sip:pj1f3tuc@192.0.2.13</a>;transport=wss
            Q=</div>
          <div class="gmail_default">                        ContactID::
            1722063907515807930</div>
          <div class="gmail_default">                        Expires::
            590</div>
          <div class="gmail_default">                        Callid::
            di99pe3jion673q2oudcpr</div>
          <div class="gmail_default">                        Cseq:: 96</div>
          <div class="gmail_default">                       
            User-agent:: SIP.js/0.7.8 BB</div>
          <div class="gmail_default">                        State::
            CS_NEW</div>
          <div class="gmail_default">                        Flags:: 0</div>
          <div class="gmail_default">                        Cflags:: </div>
          <div class="gmail_default">                        Socket::
            wss:<a href="http://10.101.10.151:443"
              moz-do-not-send="true">10.101.10.151:443</a></div>
          <div class="gmail_default">                        Methods::
            5439</div>
          <div class="gmail_default">                       
            SIP_instance::
            <urn:uuid:5d79c3cf-599f-4773-ae40-fcc1789f9452></div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default">I changed mid_registrar_save for
            save, restarted opensips and after the register,  the
            received is there. </div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default">root@gegistrar151:~$ opensipsctl ul
            show<br>
          </div>
          <div class="gmail_default">Domain:: location hash_size=512</div>
          <div class="gmail_default">        AOR:: <a
              href="mailto:user@domain.com" moz-do-not-send="true">user@domain.com</a></div>
          <div class="gmail_default">                Contact:: <a
              href="mailto:sip%3Apj1f3tuc@192.0.2.13"
              moz-do-not-send="true">sip:pj1f3tuc@192.0.2.13</a>;transport=wss
            Q=</div>
          <div class="gmail_default">                        ContactID::
            1722063907515802973</div>
          <div class="gmail_default">                        Expires::
            580</div>
          <div class="gmail_default">                        Callid::
            di99pe3jion673q2oudcpr</div>
          <div class="gmail_default">                        Cseq:: 102</div>
          <div class="gmail_default">                       
            User-agent:: SIP.js/0.7.8 BB</div>
          <div class="gmail_default">                        Received::
            sip:192.168.91.2:59384;transport=WSS</div>
          <div class="gmail_default">                        State::
            CS_NEW</div>
          <div class="gmail_default">                        Flags:: 0</div>
          <div class="gmail_default">                        Cflags:: </div>
          <div class="gmail_default">                        Socket::
            wss:<a href="http://10.101.10.151:443"
              moz-do-not-send="true">10.101.10.151:443</a></div>
          <div class="gmail_default">                        Methods::
            5439</div>
          <div class="gmail_default">                       
            SIP_instance::
            <urn:uuid:5d79c3cf-599f-4773-ae40-fcc1789f9452></div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default">If I print $avp(rcv) to xlog , it
            contains the correct information every time.</div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default">
            <div class="gmail_default">    fix_nated_register();        
                </div>
            <div class="gmail_default">    xlog("L_INFO"," Value of
              REcevied after fix nated : $avp(rcv) ... ");</div>
          </div>
          <div class="gmail_default">    …..</div>
          <div class="gmail_default">    Value of REcevied after fix
            nated : sip:192.168.91.2:59384;transport=WSS …<br>
          </div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default">So it would seem the variable is
            set correctly but mid_registrar_save does save it.  </div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default">Thanks ! </div>
          <div class="gmail_default"><br>
          </div>
          <div class="gmail_default"><br>
          </div>
        </div>
      </div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Sat, Mar 17, 2018 at 1:40 AM, Liviu
          Chircu <span dir="ltr"><<a
              href="mailto:liviu@opensips.org" target="_blank"
              moz-do-not-send="true">liviu@opensips.org</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div bgcolor="#FFFFFF" text="#000000">
              <p><tt>A git clone will definitely give you the latest
                  code, as well as the 2.3.3 RPMs.</tt></p>
              <p><tt>Are you sure you are also setting the
                  "received_avp" for the mid-registrar? If yes, please
                  let me know the exact modparams of your mid-registrar
                  and I will try to reproduce the issue.</tt></p>
              <tt>Best regards,</tt><span class="">
                <pre class="m_2211654724609151810moz-signature" cols="72">Liviu Chircu
OpenSIPS Developer
<a class="m_2211654724609151810moz-txt-link-freetext" href="http://www.opensips-solutions.com" target="_blank" moz-do-not-send="true">http://www.opensips-solutions.<wbr>com</a></pre>
              </span><span class="">
                <div class="m_2211654724609151810moz-cite-prefix">On
                  16.03.2018 21:58, Sebastian Sastre wrote:<br>
                </div>
              </span>
              <blockquote type="cite"><span class="">
                  <div dir="ltr">
                    <div class="gmail_default"
                      style="font-family:tahoma,sans-serif">Liviu, </div>
                    <div class="gmail_default"
                      style="font-family:tahoma,sans-serif"><br>
                    </div>
                    <div class="gmail_default"
                      style="font-family:tahoma,sans-serif">I tried
                      again and i’m pretty sure im cloning 2.3.3 but it
                      sill not working. You mentioned the fix on the RPM
                      packages but im using Debian 8 and I’m compiling
                      from source. Is it only fixed on RPM packages? </div>
                    <div class="gmail_default"
                      style="font-family:tahoma,sans-serif"><br>
                    </div>
                    <div class="gmail_default"
                      style="font-family:tahoma,sans-serif">
                      <div class="gmail_default">I also tried looking on
                        the pull request or commits in git but I can’t
                        see a comit for a mid_registrar and WSS missing
                        the received parameter problem. </div>
                      <div><br>
                      </div>
                    </div>
                    <div class="gmail_default"
                      style="font-family:tahoma,sans-serif">I might not
                      be looking correctly, do you mind sending me a
                      link to the comit where it got fixed please ? That
                      way I can make sure that the code I use has that
                      fix. </div>
                    <div class="gmail_default"
                      style="font-family:tahoma,sans-serif"><br>
                    </div>
                    <div class="gmail_default"
                      style="font-family:tahoma,sans-serif">Thanks again
                      ! <br>
                    </div>
                  </div>
                </span>
                <pre>______________________________<wbr>_________________
Users mailing list
<a class="m_2211654724609151810moz-txt-link-abbreviated" href="mailto:Users@lists.opensips.org" target="_blank" moz-do-not-send="true">Users@lists.opensips.org</a>
<a class="m_2211654724609151810moz-txt-link-freetext" href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" target="_blank" moz-do-not-send="true">http://lists.opensips.org/cgi-<wbr>bin/mailman/listinfo/users</a>
</pre>
              </blockquote>
              <br>
            </div>
            <br>
            ______________________________<wbr>_________________<br>
            Users mailing list<br>
            <a href="mailto:Users@lists.opensips.org"
              moz-do-not-send="true">Users@lists.opensips.org</a><br>
            <a
              href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users"
              rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.opensips.org/cgi-<wbr>bin/mailman/listinfo/users</a><br>
            <br>
          </blockquote>
        </div>
        <br>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
Users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Users@lists.opensips.org">Users@lists.opensips.org</a>
<a class="moz-txt-link-freetext" href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>