<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><tt>Yup<tt>, it's include<tt>d in 2.3.3<tt>. <tt>We'll l<tt>ook
into the db_virtual issue asap.</tt></tt></tt></tt></tt></tt></p>
<p><tt><tt><tt><tt><tt><tt><tt>Ch<tt>eers,</tt></tt></tt></tt><tt></tt></tt></tt></tt></tt><br>
</p>
<pre class="moz-signature" cols="72">Liviu Chircu
OpenSIPS Developer
<a class="moz-txt-link-freetext" href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a></pre>
<div class="moz-cite-prefix">On 20.02.2018 18:23, Ben Newlin wrote:<br>
</div>
<blockquote type="cite"
cite="mid:92A22F6B-4080-4044-83F5-07B7A016F946@genesys.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
tt
{mso-style-priority:99;
font-family:"Courier New";}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">My
apologies. I tried to verify the change history for that
file since I am not on the newest version and I didn’t see
any commits after the one I reported. I must have been
looking at it wrong. Was that commit included in 2.3.3?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">I am
currently testing the migration with 2.3.2 due to an
incompatibility between db_virtual and avpops in 2.3.3. I
have reported to this list already last week. So
unfortunately this makes me stuck as I cannot use the newer
version with the fix for this issue as it will break my DB
access.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Ben Newlin<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:black">From: </span></b><span
style="color:black">Users
<a class="moz-txt-link-rfc2396E" href="mailto:users-bounces@lists.opensips.org"><users-bounces@lists.opensips.org></a> on behalf of
Liviu Chircu <a class="moz-txt-link-rfc2396E" href="mailto:liviu@opensips.org"><liviu@opensips.org></a><br>
<b>Reply-To: </b>OpenSIPS users mailling list
<a class="moz-txt-link-rfc2396E" href="mailto:users@lists.opensips.org"><users@lists.opensips.org></a><br>
<b>Date: </b>Tuesday, February 20, 2018 at 11:04 AM<br>
<b>To: </b><a class="moz-txt-link-rfc2396E" href="mailto:users@lists.opensips.org">"users@lists.opensips.org"</a>
<a class="moz-txt-link-rfc2396E" href="mailto:users@lists.opensips.org"><users@lists.opensips.org></a><br>
<b>Subject: </b>Re: [OpenSIPS-Users] dr_is_gw parameters
wrong when not using partitions<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
</div>
<p><a name="_MailOriginalBody" moz-do-not-send="true"><tt><span
style="font-size:10.0pt">Hi Ben,</span></tt><o:p></o:p></a></p>
<p><span style="mso-bookmark:_MailOriginalBody"><tt><span
style="font-size:10.0pt">I hope you're running off the
release packages, because this 2.3 issue has been
reported & fixed here [1], a month ago. Otherwise,
we'll have to do some more digging.</span></tt><o:p></o:p></span></p>
<p><span style="mso-bookmark:_MailOriginalBody"><tt><span
style="font-size:10.0pt">Best regards,</span></tt><o:p></o:p></span></p>
<p><span style="mso-bookmark:_MailOriginalBody"><tt><span
style="font-size:10.0pt">[1]:
</span></tt></span><a
href="https://github.com/OpenSIPS/opensips/commit/d448ab6e3599d"
moz-do-not-send="true"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:10.0pt;font-family:"Courier
New"">https://github.com/OpenSIPS/opensips/commit/d448ab6e3599d</span></span><span
style="mso-bookmark:_MailOriginalBody"></span></a><span
style="mso-bookmark:_MailOriginalBody"><o:p></o:p></span></p>
<pre><span style="mso-bookmark:_MailOriginalBody">Liviu Chircu<o:p></o:p></span></pre>
<pre><span style="mso-bookmark:_MailOriginalBody">OpenSIPS Developer<o:p></o:p></span></pre>
<pre><span style="mso-bookmark:_MailOriginalBody"></span><a href="http://www.opensips-solutions.com" moz-do-not-send="true"><span style="mso-bookmark:_MailOriginalBody">http://www.opensips-solutions.com</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><o:p></o:p></span></pre>
<div>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody">On 20.02.2018
17:51, Ben Newlin wrote:<o:p></o:p></span></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt">Hi,</span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt">I am running into an issue
migrating from 1.11 to 2.3. It appears the dr_is_gw
function is broken in 2.3.x.</span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt">When not using partitions, the
function parameters are not being translated properly
before being passed to the internal function. With this
command:</span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:10.0pt">dr_is_gw("$avp(src_uri)", "2",
"inc", "$avp(gw_attr)");</span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt">I get the following error:</span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:10.0pt">CRITICAL:core:fixup_get_svalue:
bogus type 4 in gparam</span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:10.0pt">ERROR:drouting:_is_dr_gw_w_part:
invalid flags parameter</span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt">I believe the problem was
introduced with this commit in master, which was pulled
back into 2.3:</span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"></span><a
href="https://github.com/OpenSIPS/opensips/commit/991b3ef4fabb4a21dd0f95ea18a5e934261be01c"
moz-do-not-send="true"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt">https://github.com/OpenSIPS/opensips/commit/991b3ef4fabb4a21dd0f95ea18a5e934261be01c</span></span><span
style="mso-bookmark:_MailOriginalBody"></span></a><span
style="mso-bookmark:_MailOriginalBody"><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt">This commit changed the
parameters being passed through so that the names
matched what is expected, but when the partition is not
present all arguments must be shifted over by one. As
far as I can tell the logic was already correct prior to
that commit.</span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt">Thanks,</span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt">Ben Newlin</span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"> </span><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"> <o:p></o:p></span></p>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"><br>
<br>
<br>
<o:p></o:p></span></span></p>
<pre><span style="mso-bookmark:_MailOriginalBody">_______________________________________________<o:p></o:p></span></pre>
<pre><span style="mso-bookmark:_MailOriginalBody">Users mailing list<o:p></o:p></span></pre>
<pre><span style="mso-bookmark:_MailOriginalBody"></span><a href="mailto:Users@lists.opensips.org" moz-do-not-send="true"><span style="mso-bookmark:_MailOriginalBody">Users@lists.opensips.org</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><o:p></o:p></span></pre>
<pre><span style="mso-bookmark:_MailOriginalBody"></span><a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" moz-do-not-send="true"><span style="mso-bookmark:_MailOriginalBody">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><o:p></o:p></span></pre>
</blockquote>
<p class="MsoNormal"><span
style="mso-bookmark:_MailOriginalBody"><span
style="font-size:11.0pt"><br>
<br>
</span></span><span style="font-size:11.0pt"><o:p></o:p></span></p>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Users@lists.opensips.org">Users@lists.opensips.org</a>
<a class="moz-txt-link-freetext" href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a>
</pre>
</blockquote>
<br>
</body>
</html>