<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>> <span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">Please
take a look if everything is fine</span></p>
<p><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">I
will give you feedback on GitHub<br>
</span></p>
<p>> <span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">Let
me know if I need to update the documentation</span></p>
<p><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">It
would be nice. You only have to edit
"modules/rest_client/doc/rest_client_admin.xml". Rebuild with
"make modules-readme modules=modules/rest_client". Rather than
updating this Pull Request with the above, it might be easier
for you to make a separate Pull Request for the doc part.<br>
</span></p>
<p><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">>
</span><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">generic
function fixup_rest_methods()</span></p>
<p><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">Definitely!<br>
</span></p>
<pre class="moz-signature" cols="72">Liviu Chircu
OpenSIPS Developer
<a class="moz-txt-link-freetext" href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a></pre>
<div class="moz-cite-prefix">On 19.10.2016 16:54, Ramachandran,
Agalya (Contractor) wrote:<br>
</div>
<blockquote
cite="mid:7109c48906a045f192ba69d5868ca1ba@COPDCEX28.cable.comcast.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
tt
{mso-style-priority:99;
font-family:"Courier New",serif;}
p.emailquote, li.emailquote, div.emailquote
{mso-style-name:emailquote;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:1.0pt;
border:none;
padding:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:602417147;
mso-list-template-ids:-325951534;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">Hi
Liviu,
<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">I
have added code for REST_PUT API and did Pull Request.
<b>The Pull request no is #968.</b> <o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">I
have not updated documentation yet. Please take a look if
everything is fine.
<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">Let
me know if I need to update the documentation or you will
take care of it.
<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">One
suggestion for the code base in rest_client.c file.
<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">fixup_rest_get(),
fixup_rest_put(), fixup_rest_post() all three functions are
doing the same job, hence code duplication.
<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">If
we can make this as generic function fixup_rest_methods()
and can use the same for all three methods.
<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:blue">Agalya<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
Liviu Chircu [<a class="moz-txt-link-freetext" href="mailto:liviu@opensips.org">mailto:liviu@opensips.org</a>]
<br>
<b>Sent:</b> Thursday, October 13, 2016 4:10 AM<br>
<b>To:</b> Ramachandran, Agalya (Contractor)
<a class="moz-txt-link-rfc2396E" href="mailto:Agalya_Ramachandran@comcast.com"><Agalya_Ramachandran@comcast.com></a>; OpenSIPS users
mailling list <a class="moz-txt-link-rfc2396E" href="mailto:users@lists.opensips.org"><users@lists.opensips.org></a><br>
<b>Subject:</b> Re: [OpenSIPS-Users] Pending OpenSIPS
minor releases: Last minute bug fixes!<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p><tt><span style="font-size:10.0pt">Hi, Agalya!</span></tt><o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">If
I get green signal from my management, I will contribute
code for REST_PUT. Can you share me the process to
contribute code ?<o:p></o:p></span></p>
</div>
</blockquote>
<p class="MsoNormal"><span
style="font-size:10.0pt;font-family:"Calibri",sans-serif">First,
you create a GitHub account. Then you fork the OpenSIPS repo
[1] to your account. This allows you to work on it
independently and push changes back to GitHub when you're
done, so they are visible for everyone.<br>
<br>
Once the fork is done, you clone the forked project on your
machine so you can work on its code. You then apply your
custom patch(es), make the necessary commits and push these
changes back to GitHub.<br>
<br>
The process of proposing the merge of a forked project back
into the main project is called a "Pull Request" [2]. This
is the final step of contributing code, and you can easily
do it with a few clicks via GitHub's web interface.<br>
<br>
</span><o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:red">Out
of 2 times, I tested I observed the below issue for
once. Before I used to have it for every test.</span><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:0in;text-indent:-.25in;mso-list:l0
level1 lfo1">
<!--[if !supportLists]--><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif"><span
style="mso-list:Ignore">1.<span style="font:7.0pt
"Times New Roman"">
</span></span></span><!--[endif]--><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">Tried
to load 100,000 calls - But route[resume_http] is called
only for 99986 calls.<o:p></o:p></span></p>
<div>
<p class="MsoNormal" style="text-indent:.25in"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">Every
time approximately 10-20 calls, route[resume_http] is
not called. But if I see the tcpdump, I am seeing
100,000 HTTP request and 100,000 HTTP 200 OK responses.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-indent:.25in"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">When
printing the response in resume_http for every call-id,
10-20 calls response is not printed - which means resume
is not called for these calls.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-indent:.25in"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">Am
not filtering any response code.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="text-indent:.25in"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">Any
clue on this one?<o:p></o:p></span></p>
</div>
</blockquote>
<p class="MsoNormal"><br>
<span
style="font-size:10.0pt;font-family:"Calibri",sans-serif">Just
to be sure: we're talking about REST POST now, right?<br>
<br>
Regarding the issue: are there any OpenSIPS log errors that
might help us? Also, did you deduce the 99986 number by
grepping the logs, or by looking at the completed SIP calls?
I'd recommend the latter, since log lines may be
rate-limited / overlapped, etc.<br>
<br>
[1]: <a moz-do-not-send="true"
href="https://github.com/OpenSIPS/opensips">https://github.com/OpenSIPS/opensips</a><br>
[2]: <a moz-do-not-send="true"
href="https://github.com/OpenSIPS/opensips/pulls">https://github.com/OpenSIPS/opensips/pulls</a></span><o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>