<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
tt
{mso-style-priority:99;
font-family:"Courier New";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Consolas","serif";
color:black;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-GB link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Bogdan,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><br>Are you able to say which releases of OpenSIPS this is valid for? I have been testing on 1.8.2, but I applied the changes manually up to now.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>John<o:p></o:p></span></p></div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal style='margin-left:36.0pt'><b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'>From:</span></b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'> Bogdan-Andrei Iancu [mailto:bogdan@opensips.org] <br><b>Sent:</b> 08 April 2014 14:06<br><b>To:</b> John Quick<br><b>Cc:</b> 'OpenSIPS users mailling list'<br><b>Subject:</b> Re: [OpenSIPS-Users] radius_send_auth returns Vendor Specific Attributes<o:p></o:p></span></p></div></div><p class=MsoNormal style='margin-left:36.0pt'><o:p> </o:p></p><div><p class=MsoNormal style='margin-left:36.0pt'><tt><span style='font-size:10.0pt'>John,</span></tt><span style='font-size:10.0pt;font-family:"Courier New"'><br><br><tt>I made the change (with the param stuff). See trunk commit:</tt><br><tt> <a href="https://github.com/OpenSIPS/opensips/commit/0ba0bf059d67fa28e1b9b4f40d4af86db77f5593">https://github.com/OpenSIPS/opensips/commit/0ba0bf059d67fa28e1b9b4f40d4af86db77f5593</a></tt><br><br><tt>Could you please have it tested so I can do the backport ?</tt><br><br><tt>Thanks and regards,</tt><br><br></span><o:p></o:p></p><pre style='margin-left:36.0pt'>Bogdan-Andrei Iancu<o:p></o:p></pre><pre style='margin-left:36.0pt'>OpenSIPS Founder and Developer<o:p></o:p></pre><pre style='margin-left:36.0pt'><a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><o:p></o:p></pre><p class=MsoNormal style='margin-left:36.0pt'>On 08.04.2014 13:11, Bogdan-Andrei Iancu wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><div><p class=MsoNormal style='margin-left:36.0pt'>Fair enough..... I will take care of it and push it as a fix for a logical bug.<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:36.0pt'><o:p> </o:p></p></div><div><p class=MsoNormal style='margin-left:36.0pt'>Thanks and regards,<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:36.0pt'>Bogdan<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:36.0pt'><o:p> </o:p></p></div><div><p class=MsoNormal style='margin-left:36.0pt'><o:p> </o:p></p></div><div><div><p class=MsoNormal style='margin-left:36.0pt'><span style='font-size:7.0pt;color:#575757'>Sent from Samsung Mobile<o:p></o:p></span></p></div></div><p class=MsoNormal style='margin-left:36.0pt'><br><br><br><o:p></o:p></p><pre style='margin-left:36.0pt'>Fair enough..... I will take care of it and push it as a fix for a logical bug.<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Thanks and regards,<o:p></o:p></pre><pre style='margin-left:36.0pt'>Bogdan<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Sent from Samsung Mobile<o:p></o:p></pre><p class=MsoNormal style='margin-left:36.0pt'><br><br><br><o:p></o:p></p><pre style='margin-left:36.0pt'><br><br>-------- Original message --------<br>From: John Quick <a href="mailto:john.quick@smartvox.co.uk"><john.quick@smartvox.co.uk></a> <br>Date:08/04/2014 11:38 (GMT+01:00) <br>To: 'Bogdan-Andrei Iancu' <a href="mailto:bogdan@opensips.org"><bogdan@opensips.org></a> <br>Cc: 'OpenSIPS users mailling list' <a href="mailto:users@lists.opensips.org"><users@lists.opensips.org></a> <br>Subject: RE: [OpenSIPS-Users] radius_send_auth returns Vendor Specific Attributes <br><br><o:p></o:p></pre><p class=MsoNormal style='margin-left:36.0pt'><br><br>You could add a modparam option to make it keep working as before or in the<br>new way, then set default for that parameter to "old way".<br><br>John<br><br>-----Original Message-----<br>From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>] <br>Sent: 07 April 2014 23:00<br>To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a><br>Cc: 'OpenSIPS users mailling list'<br>Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor Specific<br>Attributes<br><br>I'm glad it works.<br><br>I definitely think this must be pushed as bug fix (as it poses serious<br>limitations) , but we need to be very careful to backward compatibility<br>(which may be affected)...do you see any way nicely deal with this ?<br><br>Regards,<br><br>Bogdan-Andrei Iancu<br>OpenSIPS Founder and Developer<br><a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><br><br>On 07.04.2014 18:22, John Quick wrote:<br>> Bogdan,<br>><br>> That seems to have fixed it. Thanks.<br>><br>> John<br>><br>><br>> -----Original Message-----<br>> From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>]<br>> Sent: 04 April 2014 16:15<br>> To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a><br>> Cc: 'OpenSIPS users mailling list'<br>> Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor Specific <br>> Attributes<br>><br>> Hi John,<br>><br>> There was a small bug - please test this new attached patch (remove <br>> the prev one).<br>><br>> Regards,<br>><br>> Bogdan-Andrei Iancu<br>> OpenSIPS Founder and Developer<br>> <a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><br>><br>> On 04.04.2014 17:29, John Quick wrote:<br>>> Hi Bogdan,<br>>><br>>> From my initial testing, I think the inner while loop never terminates.<br>>> Luckily I added a trap using an integer counter with a limit of 40 <br>>> iterations.<br>>> What is it in the call to rc_avpair_get() that allows it to cycle <br>>> through each instance with a matching name rather than just keep <br>>> getting the first instance?<br>>><br>>> John<br>>><br>>><br>>> -----Original Message-----<br>>> From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>]<br>>> Sent: 03 April 2014 17:21<br>>> To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a><br>>> Cc: 'OpenSIPS users mailling list'<br>>> Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor <br>>> Specific Attributes<br>>><br>>> John - please try the attached patch, with all the disclaimers it was <br>>> not tested :)<br>>><br>>> Regards,<br>>><br>>> Bogdan-Andrei Iancu<br>>> OpenSIPS Founder and Developer<br>>> <a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><br>>><br>>> On 03.04.2014 19:13, John Quick wrote:<br>>>> Hi Bogdan,<br>>>><br>>>> If the variable is a var, at the moment you would only get the first<br>>> value.<br>>>> After modification, you would only get the last value. I agree this <br>>>> is changed behaviour, but one case does not seem to me to be any <br>>>> worse than the other. The advantage that multiple values *can* be <br>>>> returned in an AVP seems to me to outweigh the risk of changed <br>>>> behaviour on the next release of OpenSIPS. For me, it would be a <br>>>> great advantage to be able to retrieve multiple values where this is <br>>>> not<br>> possible at the moment.<br>>>> If you are able to send me the diff file (or simply a description) <br>>>> for the changes, I would be happy to test it here.<br>>>><br>>>> Thanks for responding.<br>>>><br>>>> John<br>>>><br>>>> -----Original Message-----<br>>>> From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>]<br>>>> Sent: 03 April 2014 16:53<br>>>> To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a><br>>>> Cc: 'OpenSIPS users mailling list'<br>>>> Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor <br>>>> Specific Attributes<br>>>><br>>>> John,<br>>>><br>>>> We could do that (pushing back to OpenSIPS all values for that <br>>>> RADIUS AVP), but it may be dangerous if you use on the OpenSIPS side <br>>>> a variable that does not support multiple values - actually the AVPs <br>>>> are the<br>>> only one doing that.<br>>>> Imagine the RADIUS reply returns multiple instances on an RADIUS AVP.<br>>>> And you use a $var() variable to get the value - each value will be <br>>>> pushed to that $var(), but as it can hold only one value, it will <br>>>> keep being overwritten -> only last value will be actually available.<br>>>> If this behavior is not a problem, we can fix the code and iterate <br>>>> through the entire list of RADIUS AVP and get all instances.<br>>>><br>>>> Regards,<br>>>><br>>>> Bogdan-Andrei Iancu<br>>>> OpenSIPS Founder and Developer<br>>>> <a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><br>>>><br>>>> On 02.04.2014 10:20, John Quick wrote:<br>>>>> Bogdan,<br>>>>><br>>>>> I was hoping to get all the values returned in 1 avp, the avp <br>>>>> defined for Cisco-AVPairs in set2. This takes advantage of the <br>>>>> ability of OpenSIPS avps to hold multiple indexed values and also <br>>>>> means minimal changes to the documentation of the aaa_radius module.<br>>>>> If you add a numeric index in the set definition, you must know <br>>>>> which position the required attribute is in and it is even possible <br>>>>> the server may return<br>>>> them in a different order.<br>>>>> Also, if you want to retrieve 10 values this makes the set2 <br>>>>> definition very big and clumsy. Adding an index in the set <br>>>>> definition would only be a good solution if the index was a string <br>>>>> identifying the Attribute name within Cisco-AVPairs.<br>>>>><br>>>>> I would be very happy to test if you can show me what changes need <br>>>>> to be made in the sources. I would have tried it already, but <br>>>>> wasn't sure how to add multiple values to the avp.<br>>>>><br>>>>> John<br>>>>><br>>>>> -----Original Message-----<br>>>>> From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>]<br>>>>> Sent: 01 April 2014 22:49<br>>>>> To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a><br>>>>> Cc: 'OpenSIPS users mailling list'<br>>>>> Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor <br>>>>> Specific Attributes<br>>>>><br>>>>> John,<br>>>>><br>>>>> I understand the issue and agree over the need of a solution. Two <br>>>>> possible<br>>>>> approaches:<br>>>>> - return all the values for that radius AVP<br>>>>> - include an index in the set definition - to say which <br>>>>> instance of the radius AVP you are looking for<br>>>>><br>>>>> Regards,<br>>>>><br>>>>> Bogdan-Andrei Iancu<br>>>>> OpenSIPS Founder and Developer<br>>>>> <a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><br>>>>><br>>>>> On 01.04.2014 21:29, John Quick wrote:<br>>>>>> Hi Bogdan,<br>>>>>><br>>>>>> Yes absolutely certain. I used Wireshark to check.<br>>>>>><br>>>>>> I did make a little progress with this problem after finding some <br>>>>>> info on the Internet.<br>>>>>> The name that has to be used in set2 is "Cisco-AVPair". This <br>>>>>> allows me to retrieve just one VSA value.<br>>>>>> The *real* problem is that you cannot retrieve values 2, 3, 4, etc.<br>>>>>> This is because multiple instances are returned using the same VSA.<br>>>>>> They are all returned by the server in the attribute called <br>>>>>> h323-ivr-in. I even found the code in the sources that retrieves them.<br>>>>>> It loops through every instance in<br>>>>>> set2 and looks for 1 matching value. So even if you add "Cisco-AVPair"<br>>>>>> several times into set2 all you get is the first matching value <br>>>>>> many<br>>>>> times.<br>>>>>> John<br>>>>>><br>>>>>> -----Original Message-----<br>>>>>> From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>]<br>>>>>> Sent: 01 April 2014 19:15<br>>>>>> To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a>; OpenSIPS users mailling list<br>>>>>> Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor <br>>>>>> Specific Attributes<br>>>>>><br>>>>>> Hi John,<br>>>>>><br>>>>>> It may be a stupid question, but are you sure the AVP does exist <br>>>>>> in the RADIUS reply ?<br>>>>>><br>>>>>> Regards,<br>>>>>><br>>>>>> Bogdan-Andrei Iancu<br>>>>>> OpenSIPS Founder and Developer<br>>>>>> <a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><br>>>>>><br>>>>>> On 28.03.2014 13:23, John Quick wrote:<br>>>>>>> Hi,<br>>>>>>><br>>>>>>> With help from this forum, I have just got radius_send_auth working.<br>>>>>>> I needed some extra dictionaries including dictionary.cisco In <br>>>>>>> that dictionary, there are vendor specific attributes like this:<br>>>>>>> ATTRIBUTE h323-ivr-in 100 string<br>>>>>>> Cisco<br>>>>>>> ATTRIBUTE h323-credit-amount 101 string<br>>>>>>> Cisco<br>>>>>>><br>>>>>>> My Radius server returns some data using these VSA's. In <br>>>>>>> particular, it returns many values using the same VSA - <br>>>>>>> h323-ivr-in<br>>>>>>><br>>>>>>> I am having trouble recovering the returned values using set2 of <br>>>>>>> radius_send_auth Can anyone advise me how I should define set2 to <br>>>>>>> get at these returned values? I have tried the following with no<br>>>> success:<br>>>>>>> modparam("aaa_radius", "sets", "set2 = <br>>>>>>> (h323-return-code=$avp(retcode),<br>>>>>>> h323-ivr-in=$avp(authretvals))")<br>>>>>>><br>>>>>>> After the function is called, there are no values in<br>>>>>>> $avp(authretvals)<br>>>>>>><br>>>>>>> Thanks.<br>>>>>>><br>>>>>>> John Quick<br>>>>>>> Smartvox Limited<br>>>>>>> Web: <a href="http://www.smartvox.co.uk">www.smartvox.co.uk</a><br>>>>>>><br>>>>>>><br>>>>>>><br>>>>>>><br>>>>>>> _______________________________________________<br>>>>>>> Users mailing list<br>>>>>>> <a href="mailto:Users@lists.opensips.org">Users@lists.opensips.org</a><br>>>>>>> <a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a><br>>>>>>><br>>>>>>><br>>><br>><br>><br><br><br><br><br><br><br><o:p></o:p></p><pre style='margin-left:36.0pt'>You could add a modparam option to make it keep working as before or in the<o:p></o:p></pre><pre style='margin-left:36.0pt'>new way, then set default for that parameter to "old way".<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>John<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>-----Original Message-----<o:p></o:p></pre><pre style='margin-left:36.0pt'>From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>] <o:p></o:p></pre><pre style='margin-left:36.0pt'>Sent: 07 April 2014 23:00<o:p></o:p></pre><pre style='margin-left:36.0pt'>To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a><o:p></o:p></pre><pre style='margin-left:36.0pt'>Cc: 'OpenSIPS users mailling list'<o:p></o:p></pre><pre style='margin-left:36.0pt'>Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor Specific<o:p></o:p></pre><pre style='margin-left:36.0pt'>Attributes<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>I'm glad it works.<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>I definitely think this must be pushed as bug fix (as it poses serious<o:p></o:p></pre><pre style='margin-left:36.0pt'>limitations) , but we need to be very careful to backward compatibility<o:p></o:p></pre><pre style='margin-left:36.0pt'>(which may be affected)...do you see any way nicely deal with this ?<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Regards,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Bogdan-Andrei Iancu<o:p></o:p></pre><pre style='margin-left:36.0pt'>OpenSIPS Founder and Developer<o:p></o:p></pre><pre style='margin-left:36.0pt'><a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>On 07.04.2014 18:22, John Quick wrote:<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>Bogdan,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>That seems to have fixed it. Thanks.<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>John<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>-----Original Message-----<o:p></o:p></pre><pre style='margin-left:36.0pt'>From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>]<o:p></o:p></pre><pre style='margin-left:36.0pt'>Sent: 04 April 2014 16:15<o:p></o:p></pre><pre style='margin-left:36.0pt'>To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a><o:p></o:p></pre><pre style='margin-left:36.0pt'>Cc: 'OpenSIPS users mailling list'<o:p></o:p></pre><pre style='margin-left:36.0pt'>Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor Specific <o:p></o:p></pre><pre style='margin-left:36.0pt'>Attributes<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Hi John,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>There was a small bug - please test this new attached patch (remove <o:p></o:p></pre><pre style='margin-left:36.0pt'>the prev one).<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Regards,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Bogdan-Andrei Iancu<o:p></o:p></pre><pre style='margin-left:36.0pt'>OpenSIPS Founder and Developer<o:p></o:p></pre><pre style='margin-left:36.0pt'><a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>On 04.04.2014 17:29, John Quick wrote:<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>Hi Bogdan,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'> From my initial testing, I think the inner while loop never terminates.<o:p></o:p></pre><pre style='margin-left:36.0pt'>Luckily I added a trap using an integer counter with a limit of 40 <o:p></o:p></pre><pre style='margin-left:36.0pt'>iterations.<o:p></o:p></pre><pre style='margin-left:36.0pt'>What is it in the call to rc_avpair_get() that allows it to cycle <o:p></o:p></pre><pre style='margin-left:36.0pt'>through each instance with a matching name rather than just keep <o:p></o:p></pre><pre style='margin-left:36.0pt'>getting the first instance?<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>John<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>-----Original Message-----<o:p></o:p></pre><pre style='margin-left:36.0pt'>From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>]<o:p></o:p></pre><pre style='margin-left:36.0pt'>Sent: 03 April 2014 17:21<o:p></o:p></pre><pre style='margin-left:36.0pt'>To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a><o:p></o:p></pre><pre style='margin-left:36.0pt'>Cc: 'OpenSIPS users mailling list'<o:p></o:p></pre><pre style='margin-left:36.0pt'>Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor <o:p></o:p></pre><pre style='margin-left:36.0pt'>Specific Attributes<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>John - please try the attached patch, with all the disclaimers it was <o:p></o:p></pre><pre style='margin-left:36.0pt'>not tested :)<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Regards,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Bogdan-Andrei Iancu<o:p></o:p></pre><pre style='margin-left:36.0pt'>OpenSIPS Founder and Developer<o:p></o:p></pre><pre style='margin-left:36.0pt'><a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>On 03.04.2014 19:13, John Quick wrote:<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>Hi Bogdan,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>If the variable is a var, at the moment you would only get the first<o:p></o:p></pre></blockquote><pre style='margin-left:36.0pt'>value.<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>After modification, you would only get the last value. I agree this <o:p></o:p></pre><pre style='margin-left:36.0pt'>is changed behaviour, but one case does not seem to me to be any <o:p></o:p></pre><pre style='margin-left:36.0pt'>worse than the other. The advantage that multiple values *can* be <o:p></o:p></pre><pre style='margin-left:36.0pt'>returned in an AVP seems to me to outweigh the risk of changed <o:p></o:p></pre><pre style='margin-left:36.0pt'>behaviour on the next release of OpenSIPS. For me, it would be a <o:p></o:p></pre><pre style='margin-left:36.0pt'>great advantage to be able to retrieve multiple values where this is <o:p></o:p></pre><pre style='margin-left:36.0pt'>not<o:p></o:p></pre></blockquote></blockquote><pre style='margin-left:36.0pt'>possible at the moment.<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>If you are able to send me the diff file (or simply a description) <o:p></o:p></pre><pre style='margin-left:36.0pt'>for the changes, I would be happy to test it here.<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Thanks for responding.<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>John<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>-----Original Message-----<o:p></o:p></pre><pre style='margin-left:36.0pt'>From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>]<o:p></o:p></pre><pre style='margin-left:36.0pt'>Sent: 03 April 2014 16:53<o:p></o:p></pre><pre style='margin-left:36.0pt'>To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a><o:p></o:p></pre><pre style='margin-left:36.0pt'>Cc: 'OpenSIPS users mailling list'<o:p></o:p></pre><pre style='margin-left:36.0pt'>Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor <o:p></o:p></pre><pre style='margin-left:36.0pt'>Specific Attributes<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>John,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>We could do that (pushing back to OpenSIPS all values for that <o:p></o:p></pre><pre style='margin-left:36.0pt'>RADIUS AVP), but it may be dangerous if you use on the OpenSIPS side <o:p></o:p></pre><pre style='margin-left:36.0pt'>a variable that does not support multiple values - actually the AVPs <o:p></o:p></pre><pre style='margin-left:36.0pt'>are the<o:p></o:p></pre></blockquote><pre style='margin-left:36.0pt'>only one doing that.<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>Imagine the RADIUS reply returns multiple instances on an RADIUS AVP.<o:p></o:p></pre><pre style='margin-left:36.0pt'>And you use a $var() variable to get the value - each value will be <o:p></o:p></pre><pre style='margin-left:36.0pt'>pushed to that $var(), but as it can hold only one value, it will <o:p></o:p></pre><pre style='margin-left:36.0pt'>keep being overwritten -> only last value will be actually available.<o:p></o:p></pre><pre style='margin-left:36.0pt'>If this behavior is not a problem, we can fix the code and iterate <o:p></o:p></pre><pre style='margin-left:36.0pt'>through the entire list of RADIUS AVP and get all instances.<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Regards,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Bogdan-Andrei Iancu<o:p></o:p></pre><pre style='margin-left:36.0pt'>OpenSIPS Founder and Developer<o:p></o:p></pre><pre style='margin-left:36.0pt'><a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>On 02.04.2014 10:20, John Quick wrote:<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>Bogdan,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>I was hoping to get all the values returned in 1 avp, the avp <o:p></o:p></pre><pre style='margin-left:36.0pt'>defined for Cisco-AVPairs in set2. This takes advantage of the <o:p></o:p></pre><pre style='margin-left:36.0pt'>ability of OpenSIPS avps to hold multiple indexed values and also <o:p></o:p></pre><pre style='margin-left:36.0pt'>means minimal changes to the documentation of the aaa_radius module.<o:p></o:p></pre><pre style='margin-left:36.0pt'>If you add a numeric index in the set definition, you must know <o:p></o:p></pre><pre style='margin-left:36.0pt'>which position the required attribute is in and it is even possible <o:p></o:p></pre><pre style='margin-left:36.0pt'>the server may return<o:p></o:p></pre></blockquote><pre style='margin-left:36.0pt'>them in a different order.<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>Also, if you want to retrieve 10 values this makes the set2 <o:p></o:p></pre><pre style='margin-left:36.0pt'>definition very big and clumsy. Adding an index in the set <o:p></o:p></pre><pre style='margin-left:36.0pt'>definition would only be a good solution if the index was a string <o:p></o:p></pre><pre style='margin-left:36.0pt'>identifying the Attribute name within Cisco-AVPairs.<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>I would be very happy to test if you can show me what changes need <o:p></o:p></pre><pre style='margin-left:36.0pt'>to be made in the sources. I would have tried it already, but <o:p></o:p></pre><pre style='margin-left:36.0pt'>wasn't sure how to add multiple values to the avp.<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>John<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>-----Original Message-----<o:p></o:p></pre><pre style='margin-left:36.0pt'>From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>]<o:p></o:p></pre><pre style='margin-left:36.0pt'>Sent: 01 April 2014 22:49<o:p></o:p></pre><pre style='margin-left:36.0pt'>To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a><o:p></o:p></pre><pre style='margin-left:36.0pt'>Cc: 'OpenSIPS users mailling list'<o:p></o:p></pre><pre style='margin-left:36.0pt'>Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor <o:p></o:p></pre><pre style='margin-left:36.0pt'>Specific Attributes<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>John,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>I understand the issue and agree over the need of a solution. Two <o:p></o:p></pre><pre style='margin-left:36.0pt'>possible<o:p></o:p></pre><pre style='margin-left:36.0pt'>approaches:<o:p></o:p></pre><pre style='margin-left:36.0pt'> - return all the values for that radius AVP<o:p></o:p></pre><pre style='margin-left:36.0pt'> - include an index in the set definition - to say which <o:p></o:p></pre><pre style='margin-left:36.0pt'>instance of the radius AVP you are looking for<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Regards,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Bogdan-Andrei Iancu<o:p></o:p></pre><pre style='margin-left:36.0pt'>OpenSIPS Founder and Developer<o:p></o:p></pre><pre style='margin-left:36.0pt'><a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>On 01.04.2014 21:29, John Quick wrote:<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>Hi Bogdan,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Yes absolutely certain. I used Wireshark to check.<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>I did make a little progress with this problem after finding some <o:p></o:p></pre><pre style='margin-left:36.0pt'>info on the Internet.<o:p></o:p></pre><pre style='margin-left:36.0pt'>The name that has to be used in set2 is "Cisco-AVPair". This <o:p></o:p></pre><pre style='margin-left:36.0pt'>allows me to retrieve just one VSA value.<o:p></o:p></pre><pre style='margin-left:36.0pt'>The *real* problem is that you cannot retrieve values 2, 3, 4, etc.<o:p></o:p></pre><pre style='margin-left:36.0pt'>This is because multiple instances are returned using the same VSA.<o:p></o:p></pre><pre style='margin-left:36.0pt'>They are all returned by the server in the attribute called <o:p></o:p></pre><pre style='margin-left:36.0pt'>h323-ivr-in. I even found the code in the sources that retrieves them.<o:p></o:p></pre><pre style='margin-left:36.0pt'>It loops through every instance in<o:p></o:p></pre><pre style='margin-left:36.0pt'>set2 and looks for 1 matching value. So even if you add "Cisco-AVPair"<o:p></o:p></pre><pre style='margin-left:36.0pt'>several times into set2 all you get is the first matching value <o:p></o:p></pre><pre style='margin-left:36.0pt'>many<o:p></o:p></pre></blockquote><pre style='margin-left:36.0pt'>times.<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>John<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>-----Original Message-----<o:p></o:p></pre><pre style='margin-left:36.0pt'>From: Bogdan-Andrei Iancu [<a href="mailto:bogdan@opensips.org">mailto:bogdan@opensips.org</a>]<o:p></o:p></pre><pre style='margin-left:36.0pt'>Sent: 01 April 2014 19:15<o:p></o:p></pre><pre style='margin-left:36.0pt'>To: <a href="mailto:john.quick@smartvox.co.uk">john.quick@smartvox.co.uk</a>; OpenSIPS users mailling list<o:p></o:p></pre><pre style='margin-left:36.0pt'>Subject: Re: [OpenSIPS-Users] radius_send_auth returns Vendor <o:p></o:p></pre><pre style='margin-left:36.0pt'>Specific Attributes<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Hi John,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>It may be a stupid question, but are you sure the AVP does exist <o:p></o:p></pre><pre style='margin-left:36.0pt'>in the RADIUS reply ?<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Regards,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Bogdan-Andrei Iancu<o:p></o:p></pre><pre style='margin-left:36.0pt'>OpenSIPS Founder and Developer<o:p></o:p></pre><pre style='margin-left:36.0pt'><a href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a><o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>On 28.03.2014 13:23, John Quick wrote:<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>Hi,<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>With help from this forum, I have just got radius_send_auth working.<o:p></o:p></pre><pre style='margin-left:36.0pt'>I needed some extra dictionaries including dictionary.cisco In <o:p></o:p></pre><pre style='margin-left:36.0pt'>that dictionary, there are vendor specific attributes like this:<o:p></o:p></pre><pre style='margin-left:36.0pt'>ATTRIBUTE h323-ivr-in 100 string<o:p></o:p></pre><pre style='margin-left:36.0pt'>Cisco<o:p></o:p></pre><pre style='margin-left:36.0pt'>ATTRIBUTE h323-credit-amount 101 string<o:p></o:p></pre><pre style='margin-left:36.0pt'>Cisco<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>My Radius server returns some data using these VSA's. In <o:p></o:p></pre><pre style='margin-left:36.0pt'>particular, it returns many values using the same VSA - <o:p></o:p></pre><pre style='margin-left:36.0pt'>h323-ivr-in<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>I am having trouble recovering the returned values using set2 of <o:p></o:p></pre><pre style='margin-left:36.0pt'>radius_send_auth Can anyone advise me how I should define set2 to <o:p></o:p></pre><pre style='margin-left:36.0pt'>get at these returned values? I have tried the following with no<o:p></o:p></pre></blockquote></blockquote></blockquote><pre style='margin-left:36.0pt'>success:<o:p></o:p></pre><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><pre style='margin-left:36.0pt'>modparam("aaa_radius", "sets", "set2 = <o:p></o:p></pre><pre style='margin-left:36.0pt'>(h323-return-code=$avp(retcode),<o:p></o:p></pre><pre style='margin-left:36.0pt'>h323-ivr-in=$avp(authretvals))")<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>After the function is called, there are no values in<o:p></o:p></pre><pre style='margin-left:36.0pt'>$avp(authretvals)<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>Thanks.<o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>John Quick<o:p></o:p></pre><pre style='margin-left:36.0pt'>Smartvox Limited<o:p></o:p></pre><pre style='margin-left:36.0pt'>Web: <a href="http://www.smartvox.co.uk">www.smartvox.co.uk</a><o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'>_______________________________________________<o:p></o:p></pre><pre style='margin-left:36.0pt'>Users mailing list<o:p></o:p></pre><pre style='margin-left:36.0pt'><a href="mailto:Users@lists.opensips.org">Users@lists.opensips.org</a><o:p></o:p></pre><pre style='margin-left:36.0pt'><a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a><o:p></o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre></blockquote></blockquote></blockquote></blockquote><pre style='margin-left:36.0pt'><o:p> </o:p></pre></blockquote><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre></blockquote><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre><pre style='margin-left:36.0pt'><o:p> </o:p></pre></blockquote><p class=MsoNormal style='margin-left:36.0pt'><o:p> </o:p></p></div></body></html>