<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="color: rgb(0, 0, 0); margin: 0px;"><font face="Helvetica">Hi All,</font></div><div id="bloop_customfont" style="color: rgb(0, 0, 0); margin: 0px;"><font face="Helvetica"><br></font></div><div id="bloop_customfont" style="color: rgb(0, 0, 0); margin: 0px;"><font face="Helvetica">Already sent it to David in private, but will post it here to be complete.</font></div><div id="bloop_customfont" style="color: rgb(0, 0, 0); margin: 0px;"><font face="Helvetica"><br></font></div><div id="bloop_customfont" style="margin: 0px;"><font face="Helvetica">We have trouble with the patch for call control. We get:</font></div><div id="bloop_customfont" style="margin: 0px;"><font face="Helvetica"><br></font></div><div id="bloop_customfont" style="margin: 0px;"><font color="#141414" face="Helvetica"><span style="line-height: 14px;">Feb 18 12:51:09 node04 call-control[19257]: error: 'Request' object has no attribute ‘application'</span></font></div><div id="bloop_customfont" style="color: rgb(0, 0, 0); margin: 0px;"><span style="color: rgb(20, 20, 20); line-height: 14px;"><font face="Helvetica"><br></font></span></div><div id="bloop_customfont" style="color: rgb(0, 0, 0); margin: 0px;"><span style="color: rgb(20, 20, 20); line-height: 14px;"><font face="Helvetica">I looked into in and the call_control module of OpenSIPS seems to be not passing the application type. So is this module also patched ? </font></span></div><div id="bloop_customfont" style="color: rgb(0, 0, 0); margin: 0px;"><span style="color: rgb(20, 20, 20); line-height: 14px;"><font face="Helvetica"><br></font></span></div><font face="Helvetica"> </font><div id="bloop_sign_1392727651505414912" class="bloop_sign"><font face="Helvetica">-- <br>Tijmen de Mes<br>AG-Projects</font></div> <br><p style="color:#A0A0A8;">On 12 februari 2014 at 21:05:32, David M. Lee (<a href="mailto:dlee@digium.com">dlee@digium.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div></div><div>
<title></title>
For everyone following along at home:
<div><br></div>
<div>I’ve updated my CDRTool patch (again) to fix MaxSessionTime
and ShowPrice commands, and fix some minor issues that cropped up
with DebitBalance.</div>
<div><br></div>
<div>CDRTool patch - <a href="https://gist.github.com/leedm777/8585690">https://gist.github.com/leedm777/8585690</a></div>
<div><br></div>
<div>I’ve also discovered that the call_control daemon also needs
to be patched to pass through the SIP Application Type from the
call_control module onto the CDRTool prepaid engine.</div>
<div><br></div>
<div>callcontrol patch - <a href="https://gist.github.com/leedm777/8926025">https://gist.github.com/leedm777/8926025</a></div>
<div><br></div>
<div>I’ll be sending both patches to <a href="mailto:devel@ag-projects.com">devel@ag-projects.com</a>. Feedback
welcome on both!</div>
<div><br>
<div>
<div>-- <br>
David M. Lee<br>
Digium, Inc. | Software Developer<br>
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA<br>
Check us out at: <a href="http://www.digium.com">www.digium.com</a> & <a href="http://www.asterisk.org">www.asterisk.org</a></div>
</div>
<br>
<div>
<div>On Feb 6, 2014, at 9:29 AM, David M. Lee <<a href="mailto:dlee@digium.com">dlee@digium.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
I figured that out. I’ve updated the patch on my gist, and updated
the rating doc to include a description of how the subtypes work.
<div><br></div>
<div>I’m sending the patch to <a href="mailto:devel@ag-projects.com">devel@ag-projects.com</a> now.</div>
<div><br></div>
<div>Thanks!<br>
<div>
<div>-- <br>
David M. Lee<br>
Digium, Inc. | Software Developer<br>
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA<br>
Check us out at: <a href="http://www.digium.com/">www.digium.com</a> & <a href="http://www.asterisk.org/">www.asterisk.org</a></div>
</div>
<br>
<div>
<div>On Jan 28, 2014, at 6:12 AM, Tijmen de Mes <<a href="mailto:tijmen@ag-projects.com">tijmen@ag-projects.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="font-family: Helvetica, Arial; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
Hi,</div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<br></div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">I
run into trouble and reversed the patch. In the rating engine
(telnet) DebitBalance function does not return anything anymore
with the patch applied, so something goes wrong.</div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<br></div>
<div id="bloop_sign_1390911047844851968" class="bloop_sign">
-- <br>
Tijmen de Mes<br>
AG-Projects</div>
<br>
<p style="color: rgb(160, 160, 168);">On 27 januari 2014 at
17:55:01, Tijmen de Mes (<a href="mailto:tijmen@ag-projects.com">tijmen@ag-projects.com</a>)
wrote:</p>
<blockquote type="cite" class="clean_bq">
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span>Hi</span></div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span><br></span></div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span>I tested the patch and for now I don’t see any problem with
it. Before adding it to trunk, can you update the rating docs and
record all changes in 1 patch using darcs? After that I can apply
it directly on trunk with your credentials.</span></div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span><br></span></div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span>These instructions to submit the patch also apply on
CDRTool:</span></div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span><br></span></div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span><a href="http://sipsimpleclient.org/projects/sipsimpleclient/wiki/SipSupport">
http://sipsimpleclient.org/projects/sipsimpleclient/wiki/SipSupport</a></span></div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span><br></span></div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span>You don’t need to open a ticket however, just tell me after
you send the patch.</span></div>
<div id="bloop_customfont" style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span> </span></div>
<div id="bloop_sign_1390840988356192000" class="bloop_sign">
<span>-- <br>
Tijmen de Mes<br>
AG-Projects</span></div>
<span><br></span>
<p style="color: rgb(160, 160, 168);"><span>On 26 januari 2014 at
02:08:50, Duane Larson (<a href="mailto:duane.larson@gmail.com">duane.larson@gmail.com</a>)
wrote:</span></p>
<blockquote type="cite" class="clean_bq">
<div dir="ltr"><span><span>Ugh.... Nevermind. My "Max
Duration" was set to 6 on the Destinations rate setup. I set
it to zero and I think things are looking better now. Think
I'm done for the day. Good work David! Really
appreciate the patch.</span></span></div>
<div class="gmail_extra"><span><br>
<br></span>
<div class="gmail_quote"><span>On Sat, Jan 25, 2014 at 6:56 PM,
Duane Larson<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:duane.larson@gmail.com" target="_blank">duane.larson@gmail.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br></span>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div dir="ltr">Not sure my "price" is being calculated correctly.
<div><br></div>
<div>My audio.outbound should be $0.005</div>
<div>My audio.inbound should be $0.0035</div>
<div><br></div>
<div>Here is an example of a call that lasted 2:06 minutes and is
audio.outbound</div>
<div>
<div>Increment=6 MinDuration=6 MaxDuration=6 ConnectFee=0.0000
CallId=dc1e32b1ba18ff91a3</div>
<div><a href="mailto:67aa8df81e8e3c@0:0:0:0:0:0:0:0">67aa8df81e8e3c@0:0:0:0:0:0:0:0</a>
Span=1 Duration=6 DestId=1 default Profile=USA_Default
Period=weekend Rate=USA_Default Interval=0-24 Cos</div>
<div>t=0.0050/60 Price=0.0005 PriceIn=0.0000</div>
</div>
<div><br></div>
<div>Here is an example of a call that lasted 1:33 minutes and is
audio.inbound</div>
<div>
<div>Increment=6 MinDuration=6 MaxDuration=6 ConnectFee=0.0000
CallId=2e0334513a34964e7c0</div>
<div><a href="http://a18cd3be449dd@108.166.97.17:5060/" target="_blank">a18cd3be449dd@108.166.97.17:5060</a><span class="Apple-converted-space"> </span>Span=1 Duration=6 DestId=1
default Profile=USA_Default Period=weekend Rate=USA_Default
Interval=0-24 C</div>
<div>ost=0.0035/60 Price=0.0003 PriceIn=0.0000</div>
</div>
<div><br></div>
<div>Looks like no matter what the duration is for the inbound
calls it costs $0.0003 and the outbound calls all cost
$0.0005.</div>
<div><br></div>
<div><br></div>
</div>
<div class="HOEnZb">
<div class="h5">
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Sat, Jan 25, 2014 at 6:24 PM, Duane
Larson<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:duane.larson@gmail.com" target="_blank">duane.larson@gmail.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div dir="ltr">David/Tijmen/Adrian,
<div><br></div>
<div>It is working for me too. Both inbound and outbound are
being recognized and the different rates are being applied. I
will keep looking at it while more calls are being made to make
sure there are no unforeseen issues. </div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">
<div>On Fri, Jan 24, 2014 at 5:35 AM, Tijmen de Mes<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:tijmen@ag-projects.com" target="_blank">tijmen@ag-projects.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br></div>
<div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">
<div style="word-wrap: break-word;">
<div style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">Hi
David,</div>
<div style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<br></div>
<div style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
Thanks for the patch. If have some time Monday I will analyze it
and give you some feedback so we include this in CDRTool.</div>
<div style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<br></div>
<div style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
Besides the rating, I’ve to check if the code that now sets the the
‘route’ for the CDRs and if there are no problems.</div>
<div style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span><font color="#888888"><br></font></span></div>
<div style="font-family: Helvetica, Arial; font-size: 13px; margin: 0px;">
<span><font color="#888888"> </font></span></div>
<div><span><font color="#888888">-- <br>
Tijmen de Mes<br>
AG-Projects</font></span></div>
<div><br>
<p style="color: rgb(160, 160, 168);">On 23 januari 2014 at
21:21:26, David M. Lee (<a href="mailto:dlee@digium.com" target="_blank">dlee@digium.com</a>) wrote:</p>
<blockquote type="cite"><span>I’ve got a first attempt at a
patch:<br>
<a href="https://gist.github.com/leedm777/8585690" target="_blank">https://gist.github.com/leedm777/8585690</a><br>
<br>
To get this to work, your CDR’s will have to record the
application<br>
subtype. For me, I set $avp(s:call_class) = “audio.inbound”
or<br>
“audio.outbound” as appropriate in the routes, and added<br>
Sip-Application-Type=$avp(s:call_class) to “radius_extra”.<br>
<br>
Billing rates will be matched on the full application,
allowing<br>
different rates depending on the application subtype.<br>
<br>
It works with the simple testing I’ve been able to do on my
desktop.<br>
Feedback, of course, is greatly appreciated.<br>
<br>
Duane - Does the patch work for you?<br>
<br>
Adrian - Any objections/concerns with this approach?<br>
<br>
If it looks good, I’ll work on updating the docs.<br>
<br>
Thanks!<br>
--<br>
David M. Lee<br>
Digium, Inc. | Software Developer<br>
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA<br>
Check us out at:<span class="Apple-converted-space"> </span><a href="http://www.digium.com/" target="_blank">www.digium.com</a><span class="Apple-converted-space"> </span>&<span class="Apple-converted-space"> </span><a href="http://www.asterisk.org/" target="_blank">www.asterisk.org</a><br>
<br>
On Jan 23, 2014, at 4:43 AM, Adrian Georgescu <<a href="mailto:ag@ag-projects.com" target="_blank">ag@ag-projects.com</a>> wrote:<br>
<br>
> I think it would be a good idea.<br>
><br>
> Adrian<br>
><br>
> On 22 Jan 2014, at 16:58, David Lee (digium) <<a href="mailto:dlee@digium.com" target="_blank">dlee@digium.com</a>>
wrote:<br>
><br>
>> Duane Larson wrote:<br>
>>> I have been playing with CDRTool for a while but I am
not sure if it is<br>
>>> possible to rate Origination (Inbound) calls
differently than Termination<br>
>>> (Outbound) calls from my SIP Provider. For Origination
I pay 0.0035 and<br>
>>> for Termination I pay 0.005. Keep in mind these costs
are for destination<br>
>>> "1”.<br>
>><br>
>> I've recently run into nearly the same situation.<br>
>><br>
>> I tried overloading the Sip-Application-Type field, but
it's limited<br>
>> by the supportedApplicationTypes array in cdr_generic.php.
There also<br>
>> seems to be hard coded logic for the different application
types.<br>
>><br>
>> I think I will patch CDRTool so that you can have subtypes
of<br>
>> application types (audio.inbound, audio.outbound, etc.).
This would<br>
>> allow the billing rates to be a bit more specific for
these<br>
>> situations.<br>
>><br>
>> Thoughts?<br>
>> --<br>
>> David M. Lee<br>
>> Digium, Inc. | Software Developer<br>
>> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA<br>
>> Check us out at:<span class="Apple-converted-space"> </span><a href="http://www.digium.com/" target="_blank">www.digium.com</a><span class="Apple-converted-space"> </span>&<span class="Apple-converted-space"> </span><a href="http://www.asterisk.org/" target="_blank">www.asterisk.org</a><br>
>> _______________________________________________<br>
>> Users mailing list<br>
>><span class="Apple-converted-space"> </span><a href="mailto:Users@lists.opensips.org" target="_blank">Users@lists.opensips.org</a><br>
>><span class="Apple-converted-space"> </span><a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a><br>
><br>
> _______________________________________________<br>
> Users mailing list<br>
><span class="Apple-converted-space"> </span><a href="mailto:Users@lists.opensips.org" target="_blank">Users@lists.opensips.org</a><br>
><span class="Apple-converted-space"> </span><a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a><br>
<br>
<br>
_______________________________________________<br>
Users mailing list<br>
<a href="mailto:Users@lists.opensips.org" target="_blank">Users@lists.opensips.org</a><br>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a><br>
</span></blockquote>
</div>
</div>
<br>
_______________________________________________<br>
Users mailing list<br>
<a href="mailto:Users@lists.opensips.org" target="_blank">Users@lists.opensips.org</a><br>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a><br>
<br></blockquote>
</div>
</div>
<br>
<br clear="all">
<div>
<div><br></div>
--<br>
--<br>
*--*--*--*--*--*<br>
Duane<br>
*--*--*--*--*--*<br>
--</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br></div>
--<br>
--<br>
*--*--*--*--*--*<br>
Duane<br>
*--*--*--*--*--*<br>
--</div>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br></div>
--<br>
--<br>
*--*--*--*--*--*<br>
Duane<br>
*--*--*--*--*--*<br>
--</div>
_______________________________________________<br>
Users mailing list<br>
<a href="mailto:Users@lists.opensips.org">Users@lists.opensips.org</a><br>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a><br>
</blockquote>
_______________________________________________ <br>
Users mailing list <br>
<a href="mailto:Users@lists.opensips.org">Users@lists.opensips.org</a> <br>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a> <br>
</blockquote>
_______________________________________________<br>
Users mailing list<br>
<a href="mailto:Users@lists.opensips.org">Users@lists.opensips.org</a><br>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a></div>
</blockquote>
</div>
<br></div>
</div>
</blockquote>
</div>
<br></div>
_______________________________________________
<br>Users mailing list
<br>Users@lists.opensips.org
<br>http://lists.opensips.org/cgi-bin/mailman/listinfo/users
<br></div></div></span></blockquote></body></html>