<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Hi</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">I tested the patch and for now I don’t see any problem with it. Before adding it to trunk, can you update the rating docs and record all changes in 1 patch using darcs? After that I can apply it directly on trunk with your credentials.</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">These instructions to submit the patch also apply on CDRTool:</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">http://sipsimpleclient.org/projects/sipsimpleclient/wiki/SipSupport</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">You don’t need to open a ticket however, just tell me after you send the patch.</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"> </div> <div id="bloop_sign_1390840988356192000" class="bloop_sign"><span style="font-family:helvetica,arial;font-size:13px"></span>-- <br>Tijmen de Mes<br>AG-Projects</div> <br><p style="color:#A0A0A8;">On 26 januari 2014 at 02:08:50, Duane Larson (<a href="mailto:duane.larson@gmail.com">duane.larson@gmail.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div>
<title></title>
<div dir="ltr">Ugh.... Nevermind. My "Max Duration" was set
to 6 on the Destinations rate setup. I set it to zero and I
think things are looking better now. Think I'm done for the
day. Good work David! Really appreciate the
patch.</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Sat, Jan 25, 2014 at 6:56 PM, Duane
Larson <span dir="ltr"><<a href="mailto:duane.larson@gmail.com" target="_blank">duane.larson@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Not sure my "price" is being calculated correctly.
<div><br></div>
<div>My audio.outbound should be $0.005</div>
<div>My audio.inbound should be $0.0035</div>
<div><br></div>
<div>Here is an example of a call that lasted 2:06 minutes and is
audio.outbound</div>
<div>
<div>Increment=6 MinDuration=6 MaxDuration=6 ConnectFee=0.0000
CallId=dc1e32b1ba18ff91a3</div>
<div>67aa8df81e8e3c@0:0:0:0:0:0:0:0 Span=1 Duration=6 DestId=1
default Profile=USA_Default Period=weekend Rate=USA_Default
Interval=0-24 Cos</div>
<div>t=0.0050/60 Price=0.0005 PriceIn=0.0000</div>
</div>
<div><br></div>
<div>Here is an example of a call that lasted 1:33 minutes and is
audio.inbound</div>
<div>
<div>Increment=6 MinDuration=6 MaxDuration=6 ConnectFee=0.0000
CallId=2e0334513a34964e7c0</div>
<div><a href="http://a18cd3be449dd@108.166.97.17:5060" target="_blank">a18cd3be449dd@108.166.97.17:5060</a> Span=1 Duration=6
DestId=1 default Profile=USA_Default Period=weekend
Rate=USA_Default Interval=0-24 C</div>
<div>ost=0.0035/60 Price=0.0003 PriceIn=0.0000</div>
</div>
<div><br></div>
<div>Looks like no matter what the duration is for the inbound
calls it costs $0.0003 and the outbound calls all cost
$0.0005.</div>
<div><br></div>
<div><br></div>
</div>
<div class="HOEnZb">
<div class="h5">
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Sat, Jan 25, 2014 at 6:24 PM, Duane
Larson <span dir="ltr"><<a href="mailto:duane.larson@gmail.com" target="_blank">duane.larson@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">David/Tijmen/Adrian,
<div><br></div>
<div>It is working for me too. Both inbound and outbound are
being recognized and the different rates are being applied. I
will keep looking at it while more calls are being made to make
sure there are no unforeseen issues. </div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">
<div>On Fri, Jan 24, 2014 at 5:35 AM, Tijmen de Mes <span dir="ltr"><<a href="mailto:tijmen@ag-projects.com" target="_blank">tijmen@ag-projects.com</a>></span> wrote:<br></div>
<div>
<div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
Hi David,</div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<br></div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
Thanks for the patch. If have some time Monday I will analyze it
and give you some feedback so we include this in CDRTool.</div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<br></div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
Besides the rating, I’ve to check if the code that now sets the the
‘route’ for the CDRs and if there are no problems.</div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<span><font color="#888888"><br></font></span></div>
<div style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<span><font color="#888888"> </font></span></div>
<div><span><font color="#888888">-- <br>
Tijmen de Mes<br>
AG-Projects</font></span></div>
<div>
<div><br>
<p style="color:#a0a0a8">On 23 januari 2014 at 21:21:26, David M.
Lee (<a href="mailto:dlee@digium.com" target="_blank">dlee@digium.com</a>) wrote:</p>
<blockquote type="cite">
<div>
<div><span>I’ve got a first attempt at a patch:<br>
<a href="https://gist.github.com/leedm777/8585690" target="_blank">https://gist.github.com/leedm777/8585690</a><br>
<br>
To get this to work, your CDR’s will have to record the
application<br>
subtype. For me, I set $avp(s:call_class) = “audio.inbound”
or<br>
“audio.outbound” as appropriate in the routes, and added<br>
Sip-Application-Type=$avp(s:call_class) to “radius_extra”.<br>
<br>
Billing rates will be matched on the full application,
allowing<br>
different rates depending on the application subtype.<br>
<br>
It works with the simple testing I’ve been able to do on my
desktop.<br>
Feedback, of course, is greatly appreciated.<br>
<br>
Duane - Does the patch work for you?<br>
<br>
Adrian - Any objections/concerns with this approach?<br>
<br>
If it looks good, I’ll work on updating the docs.<br>
<br>
Thanks!<br>
--<br>
David M. Lee<br>
Digium, Inc. | Software Developer<br>
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA<br>
Check us out at: <a href="http://www.digium.com" target="_blank">www.digium.com</a> & <a href="http://www.asterisk.org" target="_blank">www.asterisk.org</a><br>
<br>
On Jan 23, 2014, at 4:43 AM, Adrian Georgescu <<a href="mailto:ag@ag-projects.com" target="_blank">ag@ag-projects.com</a>> wrote:<br>
<br>
> I think it would be a good idea.<br>
><br>
> Adrian<br>
><br>
> On 22 Jan 2014, at 16:58, David Lee (digium) <<a href="mailto:dlee@digium.com" target="_blank">dlee@digium.com</a>>
wrote:<br>
><br>
>> Duane Larson wrote:<br>
>>> I have been playing with CDRTool for a while but I am
not sure if it is<br>
>>> possible to rate Origination (Inbound) calls
differently than Termination<br>
>>> (Outbound) calls from my SIP Provider. For Origination
I pay 0.0035 and<br>
>>> for Termination I pay 0.005. Keep in mind these costs
are for destination<br>
>>> "1”.<br>
>><br>
>> I've recently run into nearly the same situation.<br>
>><br>
>> I tried overloading the Sip-Application-Type field, but
it's limited<br>
>> by the supportedApplicationTypes array in cdr_generic.php.
There also<br>
>> seems to be hard coded logic for the different application
types.<br>
>><br>
>> I think I will patch CDRTool so that you can have subtypes
of<br>
>> application types (audio.inbound, audio.outbound, etc.).
This would<br>
>> allow the billing rates to be a bit more specific for
these<br>
>> situations.<br>
>><br>
>> Thoughts?<br>
>> --<br>
>> David M. Lee<br>
>> Digium, Inc. | Software Developer<br>
>> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA<br>
>> Check us out at: <a href="http://www.digium.com" target="_blank">www.digium.com</a> & <a href="http://www.asterisk.org" target="_blank">www.asterisk.org</a><br>
>> _______________________________________________<br>
>> Users mailing list<br>
>> <a href="mailto:Users@lists.opensips.org" target="_blank">Users@lists.opensips.org</a><br>
>> <a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a><br>
><br>
> _______________________________________________<br>
> Users mailing list<br>
> <a href="mailto:Users@lists.opensips.org" target="_blank">Users@lists.opensips.org</a><br>
> <a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a><br>
<br>
<br>
_______________________________________________<br>
Users mailing list<br>
<a href="mailto:Users@lists.opensips.org" target="_blank">Users@lists.opensips.org</a><br>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a><br>
</span></div>
</div>
</blockquote>
</div>
</div>
</div>
<br>
_______________________________________________<br>
Users mailing list<br>
<a href="mailto:Users@lists.opensips.org" target="_blank">Users@lists.opensips.org</a><br>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a><br>
<br></blockquote>
</div>
</div>
</div>
<br>
<br clear="all">
<div>
<div><br></div>
--<br>
--<br>
*--*--*--*--*--*<br>
Duane<br>
*--*--*--*--*--*<br>
--</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br></div>
--<br>
--<br>
*--*--*--*--*--*<br>
Duane<br>
*--*--*--*--*--*<br>
--</div>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br></div>
--<br>
--<br>
*--*--*--*--*--*<br>
Duane<br>
*--*--*--*--*--*<br>
--</div>
_______________________________________________
<br>Users mailing list
<br>Users@lists.opensips.org
<br>http://lists.opensips.org/cgi-bin/mailman/listinfo/users
<br></div></div></span></blockquote></body></html>