<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
Hi Kennard,<br>
<br>
You are right - this is the only place when presence_xml also sends a
reply. I will fix this now.<br>
<br>
Thanks and regards,<br>
Anca<br>
<br>
On 09/10/2010 07:44 PM, <a class="moz-txt-link-abbreviated" href="mailto:Kennard_White@logitech.com">Kennard_White@logitech.com</a> wrote:
<blockquote
cite="mid:OF0A570788.FC9EE711-ON8825779A.005AE3D7-8825779A.005BF6A8@logitech.com"
type="cite">
<p>Hi,<br>
<br>
Running opensips HEAD code, it seems that in at least one case the
presence PUBLISH handling code attempts to generate two replies. Please
see log trace below.<br>
<br>
In this particular case, I think presence_xml needs to return some flag
to let the core presence module know that it has already replied. Or
perhaps the core presence code could query sig/tm to see if a reply has
already been sent.<br>
<br>
I'm happy to make the changes and submit patch if that is helpful, but
please let me know which direction I should take so that the patch will
be accepted.<br>
<br>
One other minor request: would be helpful if the "bad body format"
message could also log the from address (or perhaps the callid --
something to make to traceable).<br>
<br>
Thanks,<br>
Kennard<br>
<br>
<br>
Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:presence_xml:xml_publ_handl: bad body format<br>
Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:presence:handle_publish: in event specific publish handling<br>
Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:tm:_reply_light: failed to generate 500 reply when a final 415
was sent out<br>
Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:signaling:sig_send_reply_mod: failed to send reply with tm module<br>
Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:presence:send_error_reply: sending 500 Server Internal Error reply<br>
Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:presence:handle_publish: failed to send error reply <br>
</p>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Users@lists.opensips.org">Users@lists.opensips.org</a>
<a class="moz-txt-link-freetext" href="http://lists.opensips.org/cgi-bin/mailman/listinfo/users">http://lists.opensips.org/cgi-bin/mailman/listinfo/users</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Anca Vamanu
<a class="moz-txt-link-abbreviated" href="http://www.voice-system.ro">www.voice-system.ro</a>
</pre>
</body>
</html>