[OpenSIPS-Users] Pending OpenSIPS minor releases: Last minute bug fixes!

[Ramachandran, Agalya (Contractor)]

Sure Liviu, Will update and then post a message.

Regards,
Agalya

From: users-bounces at lists.opensips.org [mailto:users-bounces at lists.opensips.org] On Behalf Of Liviu Chircu
Sent: Wednesday, October 19, 2016 10:03 AM
To: Ramachandran, Agalya (Contractor) <Agalya_Ramachandran at comcast.com>; OpenSIPS users mailling list <users at lists.opensips.org>
Subject: Re: [OpenSIPS-Users] Pending OpenSIPS minor releases: Last minute bug fixes!


> Please take a look if everything is fine

I will give you feedback on GitHub

> Let me know if I need to update the documentation

It would be nice. You only have to edit "modules/rest_client/doc/rest_client_admin.xml". Rebuild with "make modules-readme modules=modules/rest_client". Rather than updating this Pull Request with the above, it might be easier for you to make a separate Pull Request for the doc part.

> generic function fixup_rest_methods()

Definitely!

Liviu Chircu

OpenSIPS Developer

http://www.opensips-solutions.com
On 19.10.2016 16:54, Ramachandran, Agalya (Contractor) wrote:
Hi Liviu,

I have added code for REST_PUT API and did Pull Request. The Pull request no is #968.
I have not updated documentation yet. Please take a look if everything is fine.
Let me know if I need to update the documentation or you will take care of it.

One suggestion for the code base in rest_client.c file.
fixup_rest_get(), fixup_rest_put(), fixup_rest_post() all three functions are doing the same job, hence code duplication.
If we can make this as generic function fixup_rest_methods() and can use the same for all three methods.

Regards,
Agalya

From: Liviu Chircu [mailto:liviu at opensips.org]
Sent: Thursday, October 13, 2016 4:10 AM
To: Ramachandran, Agalya (Contractor) <Agalya_Ramachandran at comcast.com><mailto:Agalya_Ramachandran at comcast.com>; OpenSIPS users mailling list <users at lists.opensips.org><mailto:users at lists.opensips.org>
Subject: Re: [OpenSIPS-Users] Pending OpenSIPS minor releases: Last minute bug fixes!


Hi, Agalya!
If I get green signal from my management, I will contribute code for REST_PUT. Can you share me  the process to contribute code ?
First, you create a GitHub account. Then you fork the OpenSIPS repo [1] to your account. This allows you to work on it independently and push changes back to GitHub when you're done, so they are visible for everyone.

Once the fork is done, you clone the forked project on your machine so you can work on its code. You then apply your custom patch(es), make the necessary commits and push these changes back to GitHub.

The process of proposing the merge of a forked project back into the main project is called a "Pull Request" [2]. This is the final step of contributing code, and you can easily do it with a few clicks via GitHub's web interface.


Out of 2 times, I tested I observed the below issue for once. Before I used to have it for every test.

1.      Tried to load 100,000 calls - But route[resume_http] is called only for 99986 calls.
Every time approximately 10-20 calls, route[resume_http]  is not called. But if I see the tcpdump, I am seeing 100,000 HTTP request and 100,000 HTTP 200 OK responses.
When printing the response in resume_http for every call-id, 10-20 calls response is not printed - which means resume is not called for these calls.
Am not filtering any response code.

Any clue on this one?

Just to be sure: we're talking about REST POST now, right?

Regarding the issue: are there any OpenSIPS log errors that might help us? Also, did you deduce the 99986 number by grepping the logs, or by looking at the completed SIP calls? I'd recommend the latter, since log lines may be rate-limited / overlapped, etc.

[1]: https://github.com/OpenSIPS/opensips
[2]: https://github.com/OpenSIPS/opensips/pulls

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/users/attachments/20161019/caf58c31/attachment-0001.htm>