[OpenSIPS-Users] IS_MYSELF() always uses 5060 if received port is 0

[Bogdan-Andrei Iancu]

Hi,

The patch is part of the latest release on 1.11 branch, the 1.11.7 version.
Here is the commits for that:
https://github.com/OpenSIPS/opensips/commit/f91441d43e814d06ebf325e637206be411112879
https://github.com/OpenSIPS/opensips/commit/d39cfb73ed01b349c235949a16ccc5b559003a81

Apply them both !

Or simply use 1.11.7

Regards,

Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com

On 07.06.2016 16:10, Ravitez Ravi wrote:
> Hello Bogdan,
>                     Good Morning,
>                     I missed to updated that we are using 1.11.5 and 
> not sure if the patch was targeted for that.
>                     can you please share a patch for "OpenSIPS 
> (1.11.5-tls (x86_64/linux))"
>                     Thank you for the help.
>
> Regards,
> Ravitez.D
>
> On Tue, May 17, 2016 at 11:51 AM, Bogdan-Andrei Iancu 
> <bogdan at opensips.org <mailto:bogdan at opensips.org>> wrote:
>
>     Hi,
>
>     That is a great catch, thank you for finding and reporting this.
>     See the attach patch that should address the problem. Could you
>     please give it a try to see if it really solves the problem ?
>
>     Best Regards,
>
>     Bogdan-Andrei Iancu
>     OpenSIPS Founder and Developer
>     http://www.opensips-solutions.com
>
>     On 13.05.2016 22:30, Ravitez Ravi wrote:
>>     Hi All,
>>             Good Day,
>>             Here's the problem i'm facing and would be a great help
>>     if you could comment.
>>             Thank you.
>>
>>     is_myself() does not check for SIPS port if connection type is TLS
>>     *Configuration :*
>>     - Opensips V1.11.5 running in secure mode on port 5061
>>     - Avaya trying to communicate with Opensips server.
>>     - Opensips server ip 192.168.1.11
>>     - Avaya ip : 192.168.1.20
>>
>>
>>     *Steps :*
>>     - Avaya sends INVITE to Opensips with route header
>>     Route: <sip:192.168.1.11;transport=tls;lr;phase=terminating>
>>     - Opensips tries to process it but fails.
>>     *DBG:rr:is_preloaded: is_preloaded: Yes*
>>     *DBG:core:grep_sock_info: checking if host==us: 14==14 &&
>>      [192.168.1.11] == [192.168.1.11]*
>>     *DBG:core:grep_sock_info: checking if port 5061 matches port 5060*
>>     *DBG:core:check_self: host != me*
>>     *DBG:rr:after_loose: Topmost URI is NOT myself*
>>     ....
>>     ....
>>     ....
>>     SIP/2.0 403 Preload Route denied
>>     *Code Snippet :*
>>     /*
>>      * Check if URI is myself
>>      */
>>     #ifdef ENABLE_USER_CHECK
>>     static inline int is_myself(str *_user, str* _host, unsigned
>>     short _port)
>>     #else
>>     static inline int is_myself(str* _host, unsigned short _port)
>>     #endif
>>     {
>>     int ret;
>>
>>     *ret = check_self(_host, _port ? _port : SIP_PORT, 0);/* match
>>     all protos*/*
>>     if (ret < 0) return 0;
>>
>>     *Should is_myself() check for connection type and then decide to
>>     either use SIP or SIPS port.*
>>     *
>>     *
>>     *
>>     *
>>     *
>>     *
>>     Regards,
>>     Ravitez.D
>>
>>
>>     _______________________________________________
>>     Users mailing list
>>     Users at lists.opensips.org <mailto:Users at lists.opensips.org>
>>     http://lists.opensips.org/cgi-bin/mailman/listinfo/users
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/users/attachments/20160607/d01f4c9b/attachment.htm>