[OpenSIPS-Users] IPv6 RTPProxy Bug

[Sidwell, David]

The pull request has been opened.


From: users-bounces at lists.opensips.org [mailto:users-bounces at lists.opensips.org] On Behalf Of Razvan Crainea
Sent: Friday, December 12, 2014 3:28 AM
To: users at lists.opensips.org
Subject: Re: [OpenSIPS-Users] IPv6 RTPProxy Bug

Hi, Dave!

Can you please open a pull request in github[1] with this fix?

[1] https://github.com/OpenSIPS/opensips

Thanks!


Răzvan Crainea

OpenSIPS Solutions

www.opensips-solutions.com<http://www.opensips-solutions.com>
On 12/11/2014 05:40 PM, Sidwell, David wrote:

I have discovered a bug in the 1.11 RTPProxy Module when using IPv6 addressing.
When the command to RTPProxy is discovered to contain an IPv6 address in “rtpproxy.c” function:

“int force_rtp_proxy_body(struct sip_msg* msg, struct force_rtpp_args *args, pv_spec_p var)”

The option “6” is appended to the options being passed to RTP Proxy, however the length component within the I/O vector is not increased.
Therefore the option is not detected by the RTPProxy process and the IPv6 is not preloaded which can result in an RTP Proxy deadlock.

@Line 3725 (rtpproxy.c)

            /* XXX must compare address families in all addresses */
            if (pf == AF_INET6) {
                if (append_opts(&opts, '6') == -1) {
                    LM_ERR("out of pkg memory\n");
                    goto error;
                }
==>         //DAVES - Accommodate new opts length
==>         v[1].iov_len++;
            }

I have currently added the above change to my opensips source code in order to work past this problem.

Regards.

Dave




_______________________________________________

Users mailing list

Users at lists.opensips.org<mailto:Users at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/users

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/users/attachments/20141212/91dc3df1/attachment.htm>