[OpenSIPS-Users] [PATCH] Disable adding the GRUU to Contact header

[Vlad Paiu]

Hello,

Just double checked, the parser was enhanced to recognise GRUU in the 
Supported header, but it seems it's not used, and pub & temp gruus are 
generated whenever there's a sip.instance param in the contact. I'll fix 
this.

Also, the approach with the two parameters, one to disable GRUU globally 
and a flag to disable GRUU for the current registration, sounds like a 
good idea to me.

Regards,

Vlad Paiu
OpenSIPS Developer
http://www.opensips-solutions.com


On 04/23/2012 02:12 PM, Saúl Ibarra Corretgé wrote:
> Hi, Mohammad,
>
> On Apr 23, 2012, at 11:21 AM, Mohammad Amin Navid wrote:
>
>> Hi Saúl,
>>
>> Thanks for your reply.
>>
>>> As for the modparam name, may I suggest "disable_gruu", with a default value of 0?
>> The reason I chose add_gruu_to_contact, because it's suggesting adding to contact is being disabled, the whole GRUU is not disabled, we can still see the value of sip_instance being saved in the usrloc.
>>
> Indeed this would be a temporary fix. Actually, +sip.instance doesn't necessarily mean that GRUU is requested at all, if RFC5626 (aka outbound) is used then +sip.instance is needed, but GRUU might not be used.
>
> The way to request GRUU is to add the +sip.instance parameter to the Contat header in the REGISTER and *also* add a Supported: gruu header. I'm not sure if OpenSIPS currently does that check. Vlad?
>
> When OpenSIPS supports outbound this will need to be changed anyway, and we should have a way to disable GRUU but keep the outbound functionality, that is, keep the +sip.instance.
>
> At a back of a napkin design level I'd say we'll need 2 new modparams: disable_gruu and disable_gruu_flag. disable_gruu would be gobal and disable_gruu_flag would indicate a flag which if set before calling save() would prevent GRUU from being used. Take this idea with a grain of salt, I thought about it while typing this email ;-)
>
> To summarize, I think a disable_gruu modparam with the functionality you implemented makes sense right now :-)
>
>
> Regards,
>
> --
> Saúl Ibarra Corretgé
> AG Projects
>
>
>
>
> _______________________________________________
> Users mailing list
> Users at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/users