[OpenSIPS-Users] double reply by presence

[Kennard_White at logitech.com]

Hi,

Running opensips HEAD code, it seems that in at least one case the presence
PUBLISH handling code attempts to generate two replies. Please see log
trace below.

 In this particular case, I think presence_xml needs to return some flag to
let the core presence module know that it has already replied. Or perhaps
the core presence code could query sig/tm to see if a reply has already
been sent.

I'm happy to make the changes and submit patch if that is helpful, but
please let me know which direction I should take so that the patch will be
accepted.

One other minor request: would be helpful if the "bad body format" message
could also log the from address (or perhaps the callid -- something to make
to traceable).

Thanks,
Kennard


Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:presence_xml:xml_publ_handl: bad body format
Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:presence:handle_publish: in event specific publish handling
Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:tm:_reply_light: failed to generate 500 reply when a final 415 was
sent out
Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:signaling:sig_send_reply_mod: failed to send reply with tm module
Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:presence:send_error_reply: sending 500 Server Internal Error reply
Sep 10 09:14:37 sdc01sip01 /var/run/openser/opensips-pres[15704]:
ERROR:presence:handle_publish: failed to send error reply
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.opensips.org/pipermail/users/attachments/20100910/9f3db335/attachment.htm