[OpenSIPS-Users] IP check in FixContact (nat_traversal.c)

[Bogdan-Andrei Iancu]

Hi Iñaki,

to be honest, I'm note 100% sure about this. If you consider that the 
reply has to be routed back via the same TCP connection, what you have 
in VIA is the origin of the TCP conn (used by client to open the 
connection) and not the listening info (for receiving new connections).

In such a case, the port should match...but again, I'm not 100% what you 
should put in VIA when doing TCP - the desctiption of the TCP connection 
or the description of the listening interface.

Regards,
Bogdan

Iñaki Baz Castillo wrote:
> El Martes, 24 de Febrero de 2009, Bogdan-Andrei Iancu escribió:
>   
>> Hi Thomas,
>>
>> this looks like a bug to me - indeed both IP and port should be checked
>> in order to make sense to the check. Dan? any comments here?
>>
>> I know for sure that the fix_nated_contact() from nathepler module works
>> ok in such a scenario.
>>     
>
> Please take in account the TCP case in which the source port will never match 
> the listening port (Via port) or Contact port:
>
>   
> http://sourceforge.net/tracker/index.php?func=detail&aid=2474548&group_id=232389&atid=1086410
>
>
>