[OpenSIPS-Users] SST module: Min-SE optional in request

[Bogdan-Andrei Iancu]

Perfect - I will backport the fix on OpenSIPS 1.4 branch .

Thanks for testing,
Bogdan

Schumann Sebastian wrote:
> OK, it works. I checked the log output in addition (sth I should have done sooner :-\) and it shows that it is now as expected.
>
> The previous debug output was
> Oct  8 18:45:59 [9470] DBG:sst:sst_check_min: No MIN-SE header found.
> Oct  8 18:45:59 [9470] DBG:sst:sst_check_min: Session-Expires: 300; MIN-SE: 300
> Oct  8 18:45:59 [9470] DBG:sst:sst_check_min: Sending 422: MIN-SE:120
> Oct  8 18:45:59 [9470] DBG:sst:sst_check_min: Done returning true (1)
>
> Line 2 sets somehow the MIN-SE as SE and returns thus 422 (as required lower bound is 120).
>
> To compare, old was with Min-SE 90 this output:
> Oct  8 18:47:33 [9470] DBG:sst:sst_check_min: Session-Expires: 300; MIN-SE: 90
> Oct  8 18:47:33 [9470] DBG:sst:sst_check_min: Done returning false (-1)
>
> Now the output for non-existing Min-SE is:
> Oct  8 18:48:32 [9478] DBG:sst:sst_check_min: No MIN-SE header found.
> Oct  8 18:48:32 [9478] DBG:sst:sst_check_min: Session-Expires: 300; MIN-SE: 90
> Oct  8 18:48:32 [9478] DBG:sst:sst_check_min: Done returning false (-1)
>
> Thus correct and it also works for me.
>
> Thanks!
>
> Sebastian 
>
>   
>> -----Original Message-----
>> From: Bogdan-Andrei Iancu [mailto:bogdan at voice-system.ro] 
>> Sent: Wednesday, 08. October 2008 16:12
>> Cc: Schumann Sebastian; users at lists.opensips.org
>> Subject: Re: [OpenSIPS-Users] SST module: Min-SE optional in request
>>
>> OK - I found the bug (hopefully :) ) and uploaded the fix on 
>> the trunk - could you test and confirm that now it works as expected?
>>
>> Regards.
>> Bogdan
>>
>> Bogdan-Andrei Iancu wrote:
>>     
>>> I see...let me dig a bit through the module to see what is 
>>>       
>> the default 
>>     
>>> value when no Min-SE is advertise in the INVITE.
>>>
>>> Regards,
>>> Bogdan
>>>
>>> Schumann Sebastian wrote:
>>>   
>>>       
>>>> Yes exactly. I mean the following though:
>>>>
>>>>  UAC -> Proxy
>>>>  INVITE
>>>>  Supported: timer
>>>>  SE: 300
>>>>  Min-SE: 90 is present
>>>>  
>>>>  Proxy -> UAS works correctly
>>>>
>>>>  UAC -> Proxy
>>>>  INVITE
>>>>  Supported: timer
>>>>  SE: 300
>>>>  Min-SE: 90 is not present (default 90 should be expected 
>>>>         
>> by OpenSER)
>>     
>>>> 422 rejected anser from Proxy, i.e. OpenSER
>>>>
>>>> There I see the issue...
>>>>
>>>>   
>>>>     
>>>>         
>>>>> IMO, the following is the correct behavior:
>>>>>
>>>>> UAC -> Proxy
>>>>> INVITE
>>>>> Supported: timer
>>>>> SE: 300
>>>>> (Min-SE: 90, default)
>>>>>
>>>>> Proxy -> UAS
>>>>> INVITE
>>>>> SE: 120
>>>>> (Min-SE: 90, default)
>>>>>
>>>>> --
>>>>> Victor Pascual Ávila
>>>>>
>>>>>     
>>>>>       
>>>>>           
>>> _______________________________________________
>>> Users mailing list
>>> Users at lists.opensips.org
>>> http://lists.opensips.org/cgi-bin/mailman/listinfo/users
>>>
>>>   
>>>       
>>     
>
>