<p>I've added PJSIP to Coverity static code analysis scanner and fixed most critical security bugs in 1.11 branch. 471 defect were found in total by Coverity, 436 still to fix. </p>
<p>I think branch 1.11 is still used in the wild. Please review my security fixes. They are mainly fixes in memory corruption (overflows, invalid read), null dereferences and resource leakage. </p>
<p>You might consider adding PJSIP to Coverity also, only thing you need is to register project at Coverity and modify <code>.travis.yml</code>.</p>
<p>I will continue with fixing the bugs from most critical to less. After fixing branch 1.11 I am going to do the same with master branch.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/OpenSIPS/opensips/pull/719'>https://github.com/OpenSIPS/opensips/pull/719</a></p>
<h4>Commit Summary</h4>
<ul>
<li>fixing coverity found defects - invalid memory access / memory corruptions</li>
<li>fixing coverity found defects - resource leakage</li>
<li>fixing coverity found defects - processing initialized variables, control flow, invalid expressions</li>
<li>fixing coverity found defects - logical fix in ul callback check type, null dereference</li>
<li>fixing coverity found defects - null dereference, break missing</li>
<li>fixing coverity found defects - null dereference, invalid e164 number check</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-0">daemonize.c</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-1">db/db.c</a>
(13)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-2">evi/event_interface.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-3">flags.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-4">ip_addr.h</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-5">main.c</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-6">modules/acc/acc.c</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-7">modules/alias_db/alookup.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-8">modules/auth/challenge.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-9">modules/call_center/call_center.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-10">modules/db_text/dbt_file.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-11">modules/dialog/dlg_tophiding.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-12">modules/dispatcher/dispatcher.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-13">modules/drouting/drouting.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-14">modules/mi_datagram/datagram_fnc.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-15">modules/mi_fifo/fifo_fnc.c</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-16">modules/mi_xmlrpc/xr_parser.c</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-17">modules/presence/presentity.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-18">modules/pua/send_subscribe.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-19">modules/rtpproxy/rtpproxy.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-20">modules/tm/t_reply.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-21">modules/uac/uac.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-22">modules/uri/checks.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-23">modules/usrloc/dlist.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-24">modules/usrloc/ucontact.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-25">modules/usrloc/ul_callback.h</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-26">proxy.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSIPS/opensips/pull/719/files#diff-27">rw_locking.h</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/OpenSIPS/opensips/pull/719.patch'>https://github.com/OpenSIPS/opensips/pull/719.patch</a></li>
<li><a href='https://github.com/OpenSIPS/opensips/pull/719.diff'>https://github.com/OpenSIPS/opensips/pull/719.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/OpenSIPS/opensips/pull/719">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AFOcibAW82qq30XLquWtkhM9CnUSnjw-ks5pMvXLgaJpZM4GvcUS.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/OpenSIPS/opensips/pull/719"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>