<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>On 25 Nov 2014, at 08:04, David Sanders <<a href="mailto:notifications@github.com">notifications@github.com</a>> wrote:</div><div><div><blockquote type="cite"><p><a href="https://github.com/saghul" class="user-mention">@saghul</a>, fair points.</p>
<blockquote><p>This problem is known, but it never seemed worth fixing because it would involve keeping track of the registered AoR for NAT_Contact.</p>
</blockquote><p>It was worth fixing for us, hence this fix which worked for our needs. It would seem that the multiple accounts from the same IP and port would be more of a corner case than the main use case.</p></blockquote></div><div>Well, your corner case may be other's main usage scenario.</div><div><br></div><div>My main usage is multiple accounts on the same client and I will not be reachable at any of them by using the current patch. We have users on sip2sip.info using several accounts registered at the same time from the same end-point as a normal use case.</div><div><br></div><div>The patch should improve things and fix also your problem but without sacrificing existing functionality that you don't care much about, others do.</div><div><br></div><div><div>Adrian</div><blockquote type="cite"><p>In ensuring the multiple accounts case works you're sacrificing the main use case. Without this change keepalives just continue for user agents that unregister after registering for a long period.</p><p>In a production environment with ~70,000 user agents registering and unregistering constantly this was basically unacceptable behavior due to the continued keepalives.</p></blockquote></div><div><blockquote type="cite"><p>At the least there should probably be a high-visibility note in the documentation for the module that explains that keepalives will continue to a user agent after unregister.</p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/OpenSIPS/opensips/pull/366#issuecomment-64352901">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AFOciRgjEKjspa-Wo6mh5_FxBeIgsNvqks5nREuWgaJpZM4Cwn4u.gif" width="1"></p>
<div itemscope="" itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope="" itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/OpenSIPS/opensips/pull/366#issuecomment-64352901">
<meta itemprop="name" content="View Pull Request">
</div>
<meta itemprop="description" content="View this Pull Request on GitHub">
</div>
_______________________________________________<br>Devel mailing list<br><a href="mailto:Devel@lists.opensips.org">Devel@lists.opensips.org</a><br>http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<br></blockquote></div><br><div>
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">--<br>Adrian<br><br><br></div>
</div>
<br></div></body></html>