Excellent, thank you for the feedback<br><br><div class="gmail_quote">On Tue, Feb 5, 2013 at 3:29 PM, Vlad Paiu <span dir="ltr"><<a href="mailto:vladpaiu@opensips.org" target="_blank">vladpaiu@opensips.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u>
<div bgcolor="#ffffff" text="#000000">
Hi Julien,<br>
<br>
I've successfully replicated the issue, and it seems the issue is
that there's a memcached 'bug', so that when you try to fetch the
counter as a string,it returns the length as being the biggest
number of digits that the counter has ever had.<br>
<br>
In OpenSIPS 1.9 and trunk, the fix was fairly straight-forwards,
since in the CacheDB interface there is a separate function that
should be using when fetching a counter, so the mitigation for this
memcached issue was done in the cachedb_memcached module.<br>
<br>
In OpenSIPS 1.8, we had a single function responsible for fetching
keys & counters, and thus I fixed this issue my right&left
trimming spaces in the dialog module when fetching what we expect to
be a counter.<div class="im"><br>
<br>
Regards,<br>
<pre cols="72">Vlad Paiu
OpenSIPS Developer
<a href="http://www.opensips-solutions.com" target="_blank">http://www.opensips-solutions.com</a> </pre>
<br></div><div><div class="h5">
On 02/05/2013 02:08 PM, Vlad Paiu wrote:
<blockquote type="cite">
Hello Julien,<br>
<br>
This bug seems to have fallen through the cracks while we were
preparing for the release, so sorry for this. <br>
Next time, for bug reporting, could you please use the SF tracker
?<br>
<br>
About the actual bug, not sure if I entirely get your last
message's point, and how would incrementing by 0 help solve the
issue ?<br>
As far as I understand, the issue appears when you get more than
10 dialogs ongoing and you try to get the profile size ?<br>
<br>
I will try to replicate this locally, but I'd appreciate a little
bit more details about the issue.<br>
<br>
Best Regards,<br>
<pre cols="72">Vlad Paiu
OpenSIPS Developer
<a href="http://www.opensips-solutions.com" target="_blank">http://www.opensips-solutions.com</a> </pre>
<br>
On 01/14/2013 01:46 PM, Julien Chavanton wrote:
<blockquote type="cite">One option would be to increment by 0 using a
memcached_increment and use the return value, this way we keep
the atomic feature provided by memcached.<br>
<br>
However this would break the cachedb abstraction since we would
not use a normal "cdb_func.get" but a cdb_func.add "0"<br>
<br>
dialog profile -get-> | cachedb | memcached<br>
<br>
Cachedb specific feature like increment may not be easily
abstracted.<br>
<br>
<br>
<br>
<br>
<br>
<div class="gmail_quote">On Mon, Jan 14, 2013 at 11:52 AM,
Julien Chavanton <span dir="ltr"><<a href="mailto:jchavanton@gmail.com" target="_blank">jchavanton@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I found out that the problem is taking
place in memcached, once the size of a value is not lowered
when decrementing. <br>
<br>
This is what we have int memcached after having reached a
dialog profile of a number with more then 2 digits (10+)<br>
<br>
# Increment<br>
incr dlg_val_caller_ODA1MQ== 1.<br>
1.<br>
<br>
# Get the value (size 2 !!)<br>
get dlg_val_caller_ODA1MQ== .<br>
VALUE dlg_val_caller_ODA1MQ== 0 2.<br>
1 .<br>
END.<br>
<br>
# Decrement<br>
decr dlg_size_caller 1.<br>
0.<br>
<br>
----------------------------------------------------------<br>
<br>
Then str2int is failing in dlg_profile.c <br>
<br>
if (str2int(&ret, &n) < 0) {<br>
LM_ERR("invalid int value in CacheDB
<%.*s>\n",
<div>
<div><br>
<br>
<br>
<br>
<br>
<div class="gmail_quote">On Mon, Jan 14, 2013 at 10:34
AM, Julien Chavanton <span dir="ltr"><<a href="mailto:jchavanton@gmail.com" target="_blank">jchavanton@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Hi, I found a problem
that may require more investigation but just in case
I do not look into it further I wanted to raise the
issue.<br>
<br>
Problem found while testing dialog profiles :<br>
<br>
ERROR:dialog:get_profile_size: invalid int value in
CacheDB <1 > <br>
ERROR:dialog:get_profile_size: invalid int value in
CacheDB <0 > <br>
<br>
This problem with the white space as triggered while
testing when the profile get higher then 10 ?<br>
<br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
<pre><fieldset></fieldset>
_______________________________________________
Devel mailing list
<a href="mailto:Devel@lists.opensips.org" target="_blank">Devel@lists.opensips.org</a>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/devel" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/devel</a>
</pre>
</blockquote>
<pre><fieldset></fieldset>
_______________________________________________
Devel mailing list
<a href="mailto:Devel@lists.opensips.org" target="_blank">Devel@lists.opensips.org</a>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/devel" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/devel</a>
</pre>
</blockquote>
</div></div></div>
<br>_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@lists.opensips.org">Devel@lists.opensips.org</a><br>
<a href="http://lists.opensips.org/cgi-bin/mailman/listinfo/devel" target="_blank">http://lists.opensips.org/cgi-bin/mailman/listinfo/devel</a><br>
<br></blockquote></div><br>