<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<tt>Hello Rick,<br>
<br>
I just uploaded your patch on SVN trunk (once tested, it will me
backported to 1.8 also).<br>
<br>
I reworked a bit the part for param escaping to strictly follow
the RFC list (of chars that should not be escaped). See my commit
on SVN.<br>
<br>
If you find any issues with my changes, please let me know.<br>
<br>
In the meanwhile, thanks a lot for your patch!<br>
<br>
Regards,<br>
</tt>
<pre class="moz-signature" cols="72">Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
<a class="moz-txt-link-freetext" href="http://www.opensips-solutions.com">http://www.opensips-solutions.com</a></pre>
<br>
On 09/17/2012 03:01 PM, Rick van Rein wrote:
<blockquote cite="mid:20120917110141.GA14786@newphantom.local"
type="cite">
<pre wrap="">Hello,
When packing a SIP URI into a parameter, I noticed that the contained
@ was not escaped by {s.escape.param}. Chasing this to strcommon.c I
found that it deviates from the -unreserved specifications in the BNF
of RFC 3261. Attached is a patch relative to 1.8.0 that corrects the
user and parameter escapes to the RFC-prescribed BNF-based escapes.
Note well:
- The & in parameters was escaped, which this patch removes.
- The / in user parts was escaped, which this patch removes.
If these were added for pragmatic reasons (dealing with devices that
do not adhere to the RFC) then please overrule that part of my patch!
Other than this, changes to become RFC3621-compliant are:
- Additional parameter escaping for # % < > @ \ ^ ` { | }
- Additional user part escaping was not needed
I hope this is useful. Just consider it a thank you for all the
wonderful work that the OpenSIPS developers are doing.
Best wishes,
Rick van Rein
OpenFortress
</pre>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Devel@lists.opensips.org">Devel@lists.opensips.org</a>
<a class="moz-txt-link-freetext" href="http://lists.opensips.org/cgi-bin/mailman/listinfo/devel">http://lists.opensips.org/cgi-bin/mailman/listinfo/devel</a>
</pre>
</blockquote>
</body>
</html>