<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Hello Saúl,<br>
<br>
Cool friday night :)<br>
I also saw the sip_instance typo after the commit, but I got caught
up with some other things and forgot to fix it. Thanks for fixing
it.<br>
<br>
About the GRUU generation, yes, it still needs a little bit of work.
In case of setting the use_domain param in the usrloc module, the
AOR also contains the domain. So in this case you shouldn't attach
the '@sock' part. If use_domain is not set, the '@sock' part should
be added to create a valid URI.<br>
<br>
Sound ok ? Will commit a fix for this today.<br>
<br>
Regards,<br>
<pre class="moz-signature" cols="72">Vlad Paiu
OpenSIPS Developer</pre>
<br>
On 10/01/2011 01:40 AM, Saúl Ibarra Corretgé wrote:
<blockquote
cite="mid:0ACD99BB-E0D7-4B43-A211-E8A28D233C08@ag-projects.com"
type="cite">
<pre wrap="">Hi,
On Sep 28, 2011, at 12:00 PM, Vlad Paiu wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hello Saúl,
Ok, I have removed the Call Control feature from the 1.8 page if you say it is already in 1.7. My impression was that it was only added in trunk, sorry.
I have just committed in trunk a first version of GRUU, check it out :)
</pre>
</blockquote>
<pre wrap="">
I just tested it, there is nothing cooler you can do on a friday night, is there? ;-)
I did find a couple of issues:
1 - There was a typo in the sip_instance field name (it read sip_instace) so tables were created wrong. I went ahead and commited a fix for this.
2 - The public GRUU is not a valid SIP URI. See below.
I received the following public GRUU:
;pub-gruu=<a class="moz-txt-link-rfc2396E" href="mailto:sip:saghul@sipdoc.net@91.121.117.27;gr=urn:uuid:...">"sip:saghul@sipdoc.net@91.121.117.27;gr=urn:uuid:..."</a>
By checking the code I saw that the socket address is being printed. Is this intentional? RFC says no. If I remove that part and dial it just works as expected:
;pub-gruu=<a class="moz-txt-link-rfc2396E" href="mailto:sip:saghul@sipdoc.net;gr=urn:uuid:...">"sip:saghul@sipdoc.net;gr=urn:uuid:..."</a>
Please find attached a patch for this second issue. It's just removing some lines, but you are far more familiar with that code :-)
TLDR; it works!
Great work guys!
Regards,
</pre>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
--
Saúl Ibarra Corretgé
AG Projects
</pre>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Devel@lists.opensips.org">Devel@lists.opensips.org</a>
<a class="moz-txt-link-freetext" href="http://lists.opensips.org/cgi-bin/mailman/listinfo/devel">http://lists.opensips.org/cgi-bin/mailman/listinfo/devel</a>
</pre>
</blockquote>
</body>
</html>