[OpenSIPS-Devel] [OpenSIPS/opensips] 6daee1: proto_tls: report real ports when the write is que...

[Răzvan Crainea]

  Branch: refs/heads/3.6
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 6daee180973ce723b10a70158c287a68761d1984
      https://github.com/OpenSIPS/opensips/commit/6daee180973ce723b10a70158c287a68761d1984
  Author: Jasper Hafkenscheid <jasper.hafkenscheid at voys.nl>
  Date:   2026-09-29 (Tue, 29 Sep 2026)

  Changed paths:
    M modules/proto_tls/proto_tls.c

  Log Message:
  -----------
  proto_tls: report real ports when the write is queued on async connect

proto_tls_send() only updated last_outgoing_tcp_id and
send_sock->last_real_ports on the send_it path. When tls_async is
enabled and no connection exists yet, the first message is attached as a
write chunk to the pending connection and the function returns via
con_release, leaving both stale from a previous send on that listener.

The tracer module reads them when building the trace, so the very first
request over a new outbound TLS connection (typically the INVITE) is
logged with the ports and connection id of an unrelated peer. Every
later message on that connection goes through send_it and is correct.

proto_tcp already does this on both of its async paths.

Co-Authored-By: Claude Opus 5 (1M context) <noreply at anthropic.com>
Close: #4226


  Commit: 5c872c07e5debb3c3ff5fd5786eed5b584bc6cb7
      https://github.com/OpenSIPS/opensips/commit/5c872c07e5debb3c3ff5fd5786eed5b584bc6cb7
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2026-09-29 (Tue, 29 Sep 2026)

  Changed paths:
    M forward.h

  Log Message:
  -----------
  core: reset TCP tracing state before each send

Clear the per-process connection ID and per-socket real ports before invoking a TCP-based transport, so failed sends fall back to their intended destination instead of inheriting an unrelated connection.

Thanks to Richard Robson for reporting this issue.

Closes #4274


Compare: https://github.com/OpenSIPS/opensips/compare/95c5d3211216...5c872c07e5de

To unsubscribe from these emails, change your notification settings at https://github.com/OpenSIPS/opensips/settings/notifications