[OpenSIPS-Devel] [OpenSIPS/opensips] 6bed78: docs: correct function and statistic names the mod...

[Bogdan Andrei IANCU]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 6bed7816fb5a631daa1b94ecd215382fad03ac52
      https://github.com/OpenSIPS/opensips/commit/6bed7816fb5a631daa1b94ecd215382fad03ac52
  Author: Denys Ivonenko <denys.i at didww.com>
  Date:   2026-09-08 (Tue, 08 Sep 2026)

  Changed paths:
    M modules/event_sqs/README.md
    M modules/janus/README.md
    M modules/registrar/README.md

  Log Message:
  -----------
  docs: correct function and statistic names the modules do not export [skip ci]

The same defect as #4241 in the sections it did not cover. Three names,
three modules: janus documents janus_send_requeest() while the module
exports janus_send_request(); event_sqs documents sqs_publish_message(),
which is the static C function behind the script command, exported as
sqs_send_message(); registrar documents the statistic defaults_expires
while stat_export_t declares default_expire.

Documentation only, no behaviour change. The code is right in all three.


  Commit: e5e5fe7514f2d34baeaf5ec72880b40038639dd1
      https://github.com/OpenSIPS/opensips/commit/e5e5fe7514f2d34baeaf5ec72880b40038639dd1
  Author: Denys Ivonenko <denys.i at didww.com>
  Date:   2026-09-11 (Fri, 11 Sep 2026)

  Changed paths:
    M modules/registrar/README.md
    M modules/registrar/reg_mod.c

  Log Message:
  -----------
  registrar: fix the default_expire statistic name

The statistic is registered as "default_expire" while the modparam whose
value it exposes is "default_expires", and the module's other statistics
match their parameters. Register it under the correct name and keep the
old one for backwards-compatibility, as requested in #4250.

The old name is a STAT_IS_FUNC alias rather than a second stat_var. Two
export entries sharing one stat_var** do not work: __register_stat()
allocates a new stat_var per entry and overwrites *pvar, so update_stat()
reaches only the last one and the other name reports 0 for ever. Reading
through a function keeps one source of truth, and the two names follow
the parameter together.

Documented under the correct name only; the compatibility alias lives in
the code, as in c84312c2.


  Commit: 7e6e45a32a8ccc604ce1ea4acaee8f3108abfa78
      https://github.com/OpenSIPS/opensips/commit/7e6e45a32a8ccc604ce1ea4acaee8f3108abfa78
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2026-09-11 (Fri, 11 Sep 2026)

  Changed paths:
    M modules/event_sqs/README.md
    M modules/janus/README.md
    M modules/registrar/README.md
    M modules/registrar/reg_mod.c

  Log Message:
  -----------
  Merge pull request #4250 from denys-i-didww/docs/names-the-code-does-not-export

docs: correct function and statistic names the modules do not export


Compare: https://github.com/OpenSIPS/opensips/compare/0a33489dc54f...7e6e45a32a8c

To unsubscribe from these emails, change your notification settings at https://github.com/OpenSIPS/opensips/settings/notifications